From nobody Thu Apr 2 15:02:04 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF56C07E9D for ; Sat, 24 Sep 2022 22:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230201AbiIXWDm (ORCPT ); Sat, 24 Sep 2022 18:03:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234039AbiIXWDb (ORCPT ); Sat, 24 Sep 2022 18:03:31 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7001533350 for ; Sat, 24 Sep 2022 15:03:28 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id 13so7169506ejn.3 for ; Sat, 24 Sep 2022 15:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date; bh=2vbRnOhD8TPYnS7wkqyA/FaN1lEvknTEkNYcBwkBWSw=; b=lyabth+2ha6CI/abNAc0A4hmmYmtoIj9qZeycWPA6WTN8GPMch3AIIeBePGKAWY3uE vYUst9GsmyMzTIwDLv7PdBWHz4Qt+EFDNVwhpN0Qre/vaM9Xu5UxcsOKNRLGNxjUmFj8 U6F4mDW1fzy2JtzS91Jm9mpBnr0uNH8AXKpAvyWQQcykRsPphCCyvoz+leFzaYuVkmi0 2ChoaYV7q/JKYjRI49OrgDgdQO9b063QrlAmOtuUgkCZbuwXVpd/NJdGOBZZu7On61PX 1G/Qi7TpxopspgiquyKl5k7pD4D3B9XVAOOY5LvAzBTFq7bf9FydYiZljs8kx6phqSUO JEPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=2vbRnOhD8TPYnS7wkqyA/FaN1lEvknTEkNYcBwkBWSw=; b=UjlhQkQyG4ouNnTs0KGrO61333fDYSOgtiXFfzD8c1vzgyVmz7jlG3FewieUaVQloN GyPy1cyQcxXa7kPQskgExDY4DNNK39egpxZz363HSnGJS7PT29NtQYPx0nZNzZCWST2D UfLNMAFOL5td1qebfiNR4Dlo3Tzqn0VjaHbf1Giqa0aUKOA+VOtb+I4JXyXpgDGdmV8u fintvijG41YIOCVMgF//DFXKd5noiM8IwSwF9XH4pC0/4RtpH7wCSttM9uinZFF+z0TR cTsUk2kxA2/fvTponBN+TdYMbHYWPT7j5t0yA+UXOv1B0JyClC3QaHpEXtTpoRnF8Qwh VppQ== X-Gm-Message-State: ACrzQf0w/jP9ruX+m9ZZNw7Agw2Df1I3SvJEAVcMLNYOqWvamK5n5NEi RpdDq4w880+HfiwgfsatmetLEWC8bog= X-Google-Smtp-Source: AMsMyM75+lCEo4sIZEtqv3OQJGS+riGN/VQQDAADNF5SBwOIs7cNPV2yiT7jUVqGWs8gqmsNCerDNw== X-Received: by 2002:a17:907:75e7:b0:77a:2378:91bb with SMTP id jz7-20020a17090775e700b0077a237891bbmr12425293ejc.329.1664057008012; Sat, 24 Sep 2022 15:03:28 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57ba2cf5.dip0.t-ipconnect.de. [87.186.44.245]) by smtp.gmail.com with ESMTPSA id i21-20020aa7c9d5000000b00452878cba5bsm8114026edt.97.2022.09.24.15.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Sep 2022 15:03:26 -0700 (PDT) Date: Sun, 25 Sep 2022 00:03:24 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/10] staging: rtl8192e: Rename dot11Cur..., bCurTxBW40MHz and bCurrentRT2... Message-ID: <97c4f62da9a98b0ddcdaafae68182e3eb47f9a17.1664055213.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable dot11CurrentPreambleMode to dot11_current_preamble_mode, bCurTxBW40MHz to cur_tx_bw40mhz and bCurrentRT2RTLongSlotTime to current_rt2rt_long_slot_time to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 14 +++++++------- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 4 ++-- drivers/staging/rtl8192e/rtl819x_HT.h | 4 ++-- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index bd2696cdaccd..7391d7cb7a58 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -822,7 +822,7 @@ static void _rtl92e_net_update(struct net_device *dev) =20 net =3D &priv->rtllib->current_network; rtl92e_config_rate(dev, &rate_config); - priv->dot11CurrentPreambleMode =3D PREAMBLE_AUTO; + priv->dot11_current_preamble_mode =3D PREAMBLE_AUTO; priv->basic_rate =3D rate_config &=3D 0x15f; rtl92e_writew(dev, BSSIDR, *(u16 *)net->bssid); rtl92e_writel(dev, BSSIDR + 2, *(u32 *)(net->bssid + 2)); @@ -1998,10 +1998,10 @@ void rtl92e_update_ratr_table(struct net_device *de= v) break; } ratr_value &=3D 0x0FFFFFFF; - if (ieee->pHTInfo->bCurTxBW40MHz && + if (ieee->pHTInfo->cur_tx_bw40mhz && ieee->pHTInfo->bCurShortGI40MHz) ratr_value |=3D 0x80000000; - else if (!ieee->pHTInfo->bCurTxBW40MHz && + else if (!ieee->pHTInfo->cur_tx_bw40mhz && ieee->pHTInfo->bCurShortGI20MHz) ratr_value |=3D 0x80000000; rtl92e_writel(dev, RATR0+rate_index*4, ratr_value); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 52b25df99642..89bc989cffba 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -287,16 +287,16 @@ static void _rtl92e_update_cap(struct net_device *dev= , u16 cap) bool ShortPreamble; =20 if (cap & WLAN_CAPABILITY_SHORT_PREAMBLE) { - if (priv->dot11CurrentPreambleMode !=3D PREAMBLE_SHORT) { + if (priv->dot11_current_preamble_mode !=3D PREAMBLE_SHORT) { ShortPreamble =3D true; - priv->dot11CurrentPreambleMode =3D PREAMBLE_SHORT; + priv->dot11_current_preamble_mode =3D PREAMBLE_SHORT; priv->rtllib->SetHwRegHandler(dev, HW_VAR_ACK_PREAMBLE, (unsigned char *)&ShortPreamble); } } else { - if (priv->dot11CurrentPreambleMode !=3D PREAMBLE_LONG) { + if (priv->dot11_current_preamble_mode !=3D PREAMBLE_LONG) { ShortPreamble =3D false; - priv->dot11CurrentPreambleMode =3D PREAMBLE_LONG; + priv->dot11_current_preamble_mode =3D PREAMBLE_LONG; priv->rtllib->SetHwRegHandler(dev, HW_VAR_ACK_PREAMBLE, (unsigned char *)&ShortPreamble); } @@ -307,7 +307,7 @@ static void _rtl92e_update_cap(struct net_device *dev, = u16 cap) u8 cur_slot_time =3D priv->slot_time; =20 if ((cap & WLAN_CAPABILITY_SHORT_SLOT_TIME) && - (!priv->rtllib->pHTInfo->bCurrentRT2RTLongSlotTime)) { + (!priv->rtllib->pHTInfo->current_rt2rt_long_slot_time)) { if (cur_slot_time !=3D SHORT_SLOT_TIME) { slot_time_val =3D SHORT_SLOT_TIME; priv->rtllib->SetHwRegHandler(dev, @@ -341,7 +341,7 @@ static void _rtl92e_update_beacon(void *data) =20 if (ieee->pHTInfo->bCurrentHTSupport) HT_update_self_and_peer_setting(ieee, net); - ieee->pHTInfo->bCurrentRT2RTLongSlotTime =3D net->bssht.bd_rt2rt_long_slo= t_time; + ieee->pHTInfo->current_rt2rt_long_slot_time =3D net->bssht.bd_rt2rt_long_= slot_time; ieee->pHTInfo->RT2RT_HT_Mode =3D net->bssht.rt2rt_ht_mode; _rtl92e_update_cap(dev, net->capability); } @@ -833,7 +833,7 @@ static void _rtl92e_init_priv_variable(struct net_devic= e *dev) u8 i; =20 priv->AcmMethod =3D eAcmWay2_SW; - priv->dot11CurrentPreambleMode =3D PREAMBLE_AUTO; + priv->dot11_current_preamble_mode =3D PREAMBLE_AUTO; priv->rtllib->status =3D 0; priv->polling_timer_on =3D 0; priv->up_first_time =3D 1; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.h index 093887bcd463..7021f9c435d9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -430,7 +430,7 @@ struct r8192_priv { =20 u16 basic_rate; u8 short_preamble; - u8 dot11CurrentPreambleMode; + u8 dot11_current_preamble_mode; u8 slot_time; u16 SifsTime; =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index a4bffc081857..2394faba3940 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -343,9 +343,9 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_d= evice *dev) =20 if (priv->rtllib->state =3D=3D RTLLIB_LINKED) { =20 - bshort_gi_enabled =3D (pHTInfo->bCurTxBW40MHz && + bshort_gi_enabled =3D (pHTInfo->cur_tx_bw40mhz && pHTInfo->bCurShortGI40MHz) || - (!pHTInfo->bCurTxBW40MHz && + (!pHTInfo->cur_tx_bw40mhz && pHTInfo->bCurShortGI20MHz); =20 pra->upper_rssi_threshold_ratr =3D diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging/rtl819= 2e/rtl819x_HT.h index ce13b41074a7..2ab04469ef4b 100644 --- a/drivers/staging/rtl8192e/rtl819x_HT.h +++ b/drivers/staging/rtl8192e/rtl819x_HT.h @@ -148,7 +148,7 @@ struct rt_hi_throughput { u8 PeerMimoPs; =20 enum ht_extchnl_offset CurSTAExtChnlOffset; - u8 bCurTxBW40MHz; + u8 cur_tx_bw40mhz; u8 PeerBandwidth; =20 u8 bSwBwInProgress; @@ -157,7 +157,7 @@ struct rt_hi_throughput { u8 bRegRT2RTAggregation; u8 RT2RT_HT_Mode; u8 bCurrentRT2RTAggregation; - u8 bCurrentRT2RTLongSlotTime; + u8 current_rt2rt_long_slot_time; u8 szRT2RTAggBuffer[10]; =20 u8 bRegRxReorderEnable; diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 3b8efaf9b88c..1e1364c56163 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -543,7 +543,7 @@ void HTOnAssocRsp(struct rtllib_device *ieee) #endif HTSetConnectBwMode(ieee, (enum ht_channel_width)(pPeerHTCap->ChlWidth), (enum ht_extchnl_offset)(pPeerHTInfo->ExtChlOffset)); - pHTInfo->bCurTxBW40MHz =3D ((pPeerHTInfo->RecommemdedTxWidth =3D=3D 1) ? + pHTInfo->cur_tx_bw40mhz =3D ((pPeerHTInfo->RecommemdedTxWidth =3D=3D 1) ? true : false); =20 pHTInfo->bCurShortGI20MHz =3D ((pHTInfo->bRegShortGI20MHz) ? @@ -633,7 +633,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->bCurrentHTSupport =3D false; =20 pHTInfo->bCurBW40MHz =3D false; - pHTInfo->bCurTxBW40MHz =3D false; + pHTInfo->cur_tx_bw40mhz =3D false; =20 pHTInfo->bCurShortGI20MHz =3D false; pHTInfo->bCurShortGI40MHz =3D false; @@ -660,7 +660,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->ePeerHTSpecVer =3D HT_SPEC_VER_IEEE; =20 pHTInfo->bCurrentRT2RTAggregation =3D false; - pHTInfo->bCurrentRT2RTLongSlotTime =3D false; + pHTInfo->current_rt2rt_long_slot_time =3D false; pHTInfo->RT2RT_HT_Mode =3D (enum rt_ht_capability)0; =20 pHTInfo->IOTPeer =3D 0; @@ -720,12 +720,12 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_devi= ce *ieee, if (pHTInfo->bRegRT2RTAggregation) { pHTInfo->bCurrentRT2RTAggregation =3D pNetwork->bssht.bd_rt2rt_aggregation; - pHTInfo->bCurrentRT2RTLongSlotTime =3D + pHTInfo->current_rt2rt_long_slot_time =3D pNetwork->bssht.bd_rt2rt_long_slot_time; pHTInfo->RT2RT_HT_Mode =3D pNetwork->bssht.rt2rt_ht_mode; } else { pHTInfo->bCurrentRT2RTAggregation =3D false; - pHTInfo->bCurrentRT2RTLongSlotTime =3D false; + pHTInfo->current_rt2rt_long_slot_time =3D false; pHTInfo->RT2RT_HT_Mode =3D (enum rt_ht_capability)0; } =20 @@ -757,7 +757,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device= *ieee, } else { pHTInfo->bCurrentHTSupport =3D false; pHTInfo->bCurrentRT2RTAggregation =3D false; - pHTInfo->bCurrentRT2RTLongSlotTime =3D false; + pHTInfo->current_rt2rt_long_slot_time =3D false; pHTInfo->RT2RT_HT_Mode =3D (enum rt_ht_capability)0; =20 pHTInfo->IOTAction =3D 0; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 9da83531932f..595f9b92ac83 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -384,7 +384,7 @@ static void rtllib_query_BandwidthMode(struct rtllib_de= vice *ieee, =20 if ((tcb_desc->data_rate & 0x80) =3D=3D 0) return; - if (pHTInfo->bCurBW40MHz && pHTInfo->bCurTxBW40MHz && + if (pHTInfo->bCurBW40MHz && pHTInfo->cur_tx_bw40mhz && !ieee->bandwidth_auto_switch.bforced_tx20Mhz) tcb_desc->bPacketBW =3D true; } --=20 2.37.3