From nobody Thu Feb 12 09:32:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897D3EED619 for ; Fri, 15 Sep 2023 16:10:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236501AbjIOQKf (ORCPT ); Fri, 15 Sep 2023 12:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236367AbjIOQKO (ORCPT ); Fri, 15 Sep 2023 12:10:14 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B9561FE5 for ; Fri, 15 Sep 2023 09:09:46 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4046f7d49a9so5754555e9.1 for ; Fri, 15 Sep 2023 09:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694794184; x=1695398984; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VavJ2SF5ZeMDlKp5PL5Yc3lcSs1LF1WWPwssrhVwbYY=; b=hx/ScpUqf5xHqwXxEba2lT07JWMndXJI9r647hEckwIooeQmIMAOFg/+ALHAdLpVgr +y6c6viFhqMp9b6UnY1L+GwYy93HLyXvjCLbzxv4JZQhn5FWD93xAEgxMmseYxcA9Xmx QH1Es9hatuL1nsY0bPO22G1Ly4D92qThLx4nWJ6xTytVP39Wl9+OB1AAPHwg79fEZPD2 N+Lv22x6Pb6w7aRNoqgRwl58hzpa5XHc99w3nn0gJszp2G0gdRZ/UZY0JeI33vjkwDkJ wJjatGaB/Fn+rIozg1vgEO+egfVHEdb+NISkaFf0MHYLXtVLkc/qM5f/Jk2xIJllJDhu ITIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694794184; x=1695398984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VavJ2SF5ZeMDlKp5PL5Yc3lcSs1LF1WWPwssrhVwbYY=; b=VA54OqgiYVYqxutx/sNwrOyYOa8amz0VpqnFpi7u+3WtjIM8OmLljDTsGBFh0Xa196 bVWqiOTV4EZIjfGiHGsLVrlqHHkSJoGeANCtQgUG1+IrSKyfOOwJC5ZmAkaHroCiL5s0 NSi/TJk0qoFF5a2B0RUu9K8urXmn2SecPdkdlxB7bONtEtYEBybmVe0e2mRsdrEFk/V8 ikqgv6WOvbh2kWHjGRQO1h8CHbbTwl/SROmiHAXhR1H/u7yeifP54RqQ3t4xzjDzWQMF IJijzfvrdKV2xHpNv4/OzCYyPEAfoMiR2o5dxB/jzhsHzXm0i1IByZn3su25YfGN6s9Z h0wQ== X-Gm-Message-State: AOJu0YxAzA8Hb/WTz4maW0FWvwQCUcuRApPn6dCKBVCZXfOSNZfxR2q2 OehUJasnSY7noT+vOA9ZCkI= X-Google-Smtp-Source: AGHT+IHCec9x7R+dvyIfgtgsaxRx4aocBt8MndvCOx4yRCWf/5mmkZ8l1SlCU3vRYMW+XOLmy1TDJg== X-Received: by 2002:adf:fdcf:0:b0:319:7624:4c8d with SMTP id i15-20020adffdcf000000b0031976244c8dmr1654013wrs.0.1694794184430; Fri, 15 Sep 2023 09:09:44 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id a4-20020a5d5704000000b0031fc9402b47sm4806845wrv.4.2023.09.15.09.09.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 09:09:44 -0700 (PDT) Date: Fri, 15 Sep 2023 18:09:42 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 14/16] staging: rtl8192e: Replace control subframe types with IEEE80211_STYPE_* Message-ID: <970555ba76dcf3b9896c51aab8ff333a95f12225.1694792595.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace control and data subframe types RTLLIB_STYPE_* with IEEE80211_STYPE_* to avoid proprietary constant names. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 23 ++++------------------- drivers/staging/rtl8192e/rtllib_rx.c | 12 ++++++------ drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++--- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 4 files changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 3cf171a70974..47156eb8f46b 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -350,21 +350,6 @@ enum rt_op_mode { #define RTLLIB_FTYPE_CTL 0x0004 #define RTLLIB_FTYPE_DATA 0x0008 =20 -/* control */ -#define RTLLIB_STYPE_PSPOLL 0x00A0 -#define RTLLIB_STYPE_RTS 0x00B0 -#define RTLLIB_STYPE_CTS 0x00C0 -#define RTLLIB_STYPE_ACK 0x00D0 - -/* data */ -#define RTLLIB_STYPE_DATA 0x0000 -#define RTLLIB_STYPE_DATA_CFACK 0x0010 -#define RTLLIB_STYPE_DATA_CFPOLL 0x0020 -#define RTLLIB_STYPE_DATA_CFACKPOLL 0x0030 -#define RTLLIB_STYPE_NULLFUNC 0x0040 -#define RTLLIB_STYPE_QOS_DATA 0x0080 -#define RTLLIB_STYPE_QOS_NULL 0x00C0 - #define RTLLIB_SCTL_FRAG 0x000F #define RTLLIB_SCTL_SEQ 0xFFF0 =20 @@ -375,8 +360,8 @@ enum rt_op_mode { #define IsDataFrame(pdu) (((pdu[0] & 0x0C) =3D=3D 0x08) ? true : false) #define IsLegacyDataFrame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BIT))) #define IsQoSDataFrame(pframe) \ - ((*(u16 *)pframe&(RTLLIB_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ - (RTLLIB_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) + ((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) =3D=3D \ + (IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) #define Frame_Order(pframe) (*(u16 *)pframe&RTLLIB_FCTL_ORDER) #define SN_LESS(a, b) (((a-b)&0x800) !=3D 0) #define SN_EQUAL(a, b) (a =3D=3D b) @@ -1647,8 +1632,8 @@ static inline int rtllib_get_hdrlen(u16 fc) break; case RTLLIB_FTYPE_CTL: switch (WLAN_FC_GET_STYPE(fc)) { - case RTLLIB_STYPE_CTS: - case RTLLIB_STYPE_ACK: + case IEEE80211_STYPE_CTS: + case IEEE80211_STYPE_ACK: hdrlen =3D RTLLIB_1ADDR_LEN; break; default: diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index cf98b020194b..4d8c3869eb83 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -997,12 +997,12 @@ static int rtllib_rx_data_filter(struct rtllib_device= *ieee, u16 fc, * hostap_handle_sta_rx() before being dropped here. */ if (!ieee->intel_promiscuous_md_info.promiscuous_on) { - if (stype !=3D RTLLIB_STYPE_DATA && - stype !=3D RTLLIB_STYPE_DATA_CFACK && - stype !=3D RTLLIB_STYPE_DATA_CFPOLL && - stype !=3D RTLLIB_STYPE_DATA_CFACKPOLL && - stype !=3D RTLLIB_STYPE_QOS_DATA) { - if (stype !=3D RTLLIB_STYPE_NULLFUNC) + if (stype !=3D IEEE80211_STYPE_DATA && + stype !=3D IEEE80211_STYPE_DATA_CFACK && + stype !=3D IEEE80211_STYPE_DATA_CFPOLL && + stype !=3D IEEE80211_STYPE_DATA_CFACKPOLL && + stype !=3D IEEE80211_STYPE_QOS_DATA) { + if (stype !=3D IEEE80211_STYPE_NULLFUNC) netdev_dbg(ieee->dev, "RX: dropped data frame with no data (type=3D0x%02x, subtype=3D0x%= 02x)\n", type, stype); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index 14f402308ecd..87626c15d0d6 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -273,7 +273,7 @@ softmac_ps_mgmt_xmit(struct sk_buff *skb, type =3D WLAN_FC_GET_TYPE(fc); stype =3D WLAN_FC_GET_STYPE(fc); =20 - if (stype !=3D RTLLIB_STYPE_PSPOLL) + if (stype !=3D IEEE80211_STYPE_PSPOLL) tcb_desc->queue_index =3D MGNT_QUEUE; else tcb_desc->queue_index =3D HIGH_QUEUE; @@ -927,7 +927,7 @@ static struct sk_buff *rtllib_null_func(struct rtllib_d= evice *ieee, short pwr) ether_addr_copy(hdr->addr3, ieee->current_network.bssid); =20 hdr->frame_control =3D cpu_to_le16(RTLLIB_FTYPE_DATA | - RTLLIB_STYPE_NULLFUNC | RTLLIB_FCTL_TODS | + IEEE80211_STYPE_NULLFUNC | RTLLIB_FCTL_TODS | (pwr ? RTLLIB_FCTL_PM : 0)); =20 return skb; @@ -950,7 +950,7 @@ static struct sk_buff *rtllib_pspoll_func(struct rtllib= _device *ieee) ether_addr_copy(hdr->ta, ieee->dev->dev_addr); =20 hdr->aid =3D cpu_to_le16(ieee->assoc_id | 0xc000); - hdr->frame_control =3D cpu_to_le16(RTLLIB_FTYPE_CTL | RTLLIB_STYPE_PSPOLL= | + hdr->frame_control =3D cpu_to_le16(RTLLIB_FTYPE_CTL | IEEE80211_STYPE_PSP= OLL | RTLLIB_FCTL_PM); =20 return skb; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 4b730b2c9fef..8b8f4f90ea35 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -660,9 +660,9 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) fc =3D RTLLIB_FTYPE_DATA; =20 if (qos_activated) - fc |=3D RTLLIB_STYPE_QOS_DATA; + fc |=3D IEEE80211_STYPE_QOS_DATA; else - fc |=3D RTLLIB_STYPE_DATA; + fc |=3D IEEE80211_STYPE_DATA; =20 if (ieee->iw_mode =3D=3D IW_MODE_INFRA) { fc |=3D RTLLIB_FCTL_TODS; --=20 2.42.0