From nobody Wed Dec 17 10:26:54 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5922D1C863C for ; Fri, 21 Mar 2025 14:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742567737; cv=none; b=KT03fdW3WNvS8xcGvxnmFjP+BLg7PA+iBptIGjFQQPDexyVtp/S3kiJveLkMr/T9R5zA9FJ78KMHvA3k7fqUUuISsl+RStTEakDWOoRzvOAir06XggALggY8IlUlqpFjEgKlGD1seWZwpcJIzxnLl3ibE+kHN1lNEvvU+nJE83o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742567737; c=relaxed/simple; bh=jOvj8sUhQOnWWb9RP/PYMDVrKj4dgjPG61k1ISynHeY=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=p8Vy1BoCWxL9h/PVYWlluREZlZHnJlqLoajyFs88RKFstz0q/pbhnUOBeXeL0XxrtgbEJkarPw687ufZe8dKCTFiybEFKTe+gQMIpbMXNIFbbneBw07SNH/IbNN18b2uUFvK1pHV8aimWCXFbnY5gycFZamwnWhJAH2rMWFOYes= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=IHAc0U9f; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IHAc0U9f" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43cf06eabdaso19557425e9.2 for ; Fri, 21 Mar 2025 07:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742567734; x=1743172534; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ePP2nkQSnuEG/AnhVnMeNi8KNMe79AtuZeTxXxzHFJo=; b=IHAc0U9f3RG6Wwpu6N7vtMeH50i8WZeu58gJXcBTFuzGgAs4nWodu4GIxCbxrgDrEP juIpsWWU2hi+7KrGOSNBBIQKLP8Zf0RuwkK90NngLHL8xZBLL4+lnYQ9oZSpJu6prA8w prdaO63mRm03h/Psi34Dyxe+M7oyth3aoSDuHFI/HcqyM2klwC+1Nx+X6l4JVjavHTOH mSx9S3QA0oSNpRF/VgyDQIssDDEis8DW2ENXhqNQIORqfvv7O7xn2+S5rB5vJHtgg9A1 skyY/tCiX3pF9qBw55rk/2hqwdXBby261+F5XiUZOTL+4mii0IUU/WXazhDHWh0WVPo7 3egg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742567734; x=1743172534; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePP2nkQSnuEG/AnhVnMeNi8KNMe79AtuZeTxXxzHFJo=; b=WMGSp0pe7D/8DrKlnngqb8wgpNdLqudTJutGx3dsE65hJoO/DSGgSH9jnSDH9RK7Zc dlwRSz+k56o9aOxfHuFVvo+wRlTvQ8KLrN5WNOkWGawdzYONdLMPzhNZZPvnMMzBDkGw IiMsZIHeY24M9Cj7lFXXmih8IHHl6W6BWVzZCvjwPIWvimRxhWlAJ6svih/VXb2sPmXH Amn4522wGPkwPzxiAWgW2JCWwK7QxeyiGQz7uJXeFYxQeyN0XTHS/zvCbmZp/pEYbtXj we9HjNxF5GxdJbxatnOvSG4RG17n9+FYuJfCsKuEQfxXh/SiavkIQonNlYBcAIX1d1lI BBQQ== X-Forwarded-Encrypted: i=1; AJvYcCVBvQkNjg7s8sxUJDZN2EKI9FUUPsXZlaA/DHwLAD4aLNx/QW0BqIsIt1qpQSL7vXO72WnAJg0PNrdRjH8=@vger.kernel.org X-Gm-Message-State: AOJu0YwTu6t4mqK7CdnHvyW1qUvh9ocG2LMHwfSm51YUUrWACHga2BQG h9AeFfG3a4KTvIsNBUNqdTHdmhmEfBu5wd8YqT5bVyqh7FY1aJNbz0eHEknq74w= X-Gm-Gg: ASbGncsBvpnGQoou+DFiEN6R062dKfWL0lHGw5y7czdDoMAyQiWrVF25tjjTpwJyNE2 DRxwLxwoC93I27cski4bjvglbnrN5SbM5AZs63KK4vbUjCODTh776aIsdXZ0KIXiShmH3jNyh+c gBbNsZ3sgXcKFw24P5oB1pdXMoGapJ9J8aqnOlgsBhK3eSTH5PH3NxaRwnhN8MfKZIDWSJnJkJA pG/nbmFevMgNew9If+8JwnTO4QyWoJIMiqqbPuF2k1G9CtE/IQSgGo3cNGnhhelb35nEMdq4hAV xCGqjxhA9NyzaK8N5zob8tg/XfKGs/KWpdLb2f4q68/R8pn2pg== X-Google-Smtp-Source: AGHT+IHo3Yc3MCPOadC9UN49uSmHsJsixyIQa4snXxSgTEg4SRqx8S+qcU3YVR3JJisZ0M7ofeV/DQ== X-Received: by 2002:a05:6000:1842:b0:392:bf8:fc96 with SMTP id ffacd0b85a97d-3997f8f8be6mr3252239f8f.4.1742567733638; Fri, 21 Mar 2025 07:35:33 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3997f9eff6esm2504188f8f.100.2025.03.21.07.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 07:35:33 -0700 (PDT) Date: Fri, 21 Mar 2025 17:35:31 +0300 From: Dan Carpenter To: Nuno Das Neves Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Praveen K Paladugu , Roman Kisel , Jinank Jain , Mukesh Rathor , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] Drivers: hv: mshv: Fix uninitialize variable in mshv_ioctl_passthru_hvcall() Message-ID: <97036225-597d-4a2d-8f51-7310757b9929@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The "ret" variable could be uninitialized on the success path depending on if "is_async" is true of false. Initialized it to zero. Fixes: f5288d14069b ("Drivers: hv: Introduce mshv_root module to expose /de= v/mshv to VMMs") Signed-off-by: Dan Carpenter --- drivers/hv/mshv_root_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c index 29fa6d5a3994..b94d8fe0f691 100644 --- a/drivers/hv/mshv_root_main.c +++ b/drivers/hv/mshv_root_main.c @@ -151,13 +151,14 @@ static int mshv_ioctl_passthru_hvcall(struct mshv_par= tition *partition, void __user *user_args) { u64 status; - int ret, i; bool is_async; struct mshv_root_hvcall args; struct page *page; unsigned int pages_order; void *input_pg =3D NULL; void *output_pg =3D NULL; + int ret =3D 0; + int i; =20 if (copy_from_user(&args, user_args, sizeof(args))) return -EFAULT; --=20 2.47.2