From nobody Tue Feb 10 23:00:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25A07C77B7F for ; Thu, 11 May 2023 09:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236740AbjEKJBn (ORCPT ); Thu, 11 May 2023 05:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbjEKJBl (ORCPT ); Thu, 11 May 2023 05:01:41 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73682270E for ; Thu, 11 May 2023 02:01:40 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6434e263962so6218580b3a.2 for ; Thu, 11 May 2023 02:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683795700; x=1686387700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PpOPhoCRVVr4TLf/GE5sbLeu85r6UE17A7mxhEqx2o0=; b=HHFkKe4JvdA7myvOau9njF7ZmmErc0XVypuKeNk8WMGsuTOFNJXXDeWPDKDQ/yFlE+ hUhKmT6e19CYoH4myEJ3S1m5845Wml4A6K7yEp7k+i4VoijSFXox8xWmJL5cI/AeJO2L 9IAZu6yZwQa3/y79rbrfI9lzAMN+BiVgHNl+WbEEs+OP7OXomdA1ztkOh738D4ltMhip XHUejG/lTTSuunzbSvQMKUbD4tJYOXKMj85K9+VETxEvJ70OM1EbuMRFnZceU12LZppW EY0sCSPw9D5TSAMzOmTgsrk7dkZ0+5m0ZyajLKW9fPhkL+mulrNak7/f+98AV50t1OS4 r7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683795700; x=1686387700; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PpOPhoCRVVr4TLf/GE5sbLeu85r6UE17A7mxhEqx2o0=; b=T/2337rS76hprh5EKfchEVbifH4w+S05Fnxt3W3QoQDU1lKSjxDYeYFvVnbdWYanCk K+LKuRY7dCdkZQGJEsPNqOV24d2JxCcTE6M5KC0TWiCQR4+JI4m1Q7V8vb42foDIfco6 sC3QCfnGKexTZXsoZ5PqAtGlQQS2hoZyW6/ZkgWruItBPAJP83Pf26h40n8x6h4YJ8aK UtyK2IghT8OBdHauYnjTJ1YZB2No7Cw+wopR1650g5RcI4Or1x6QjGYL1CvsnLctP0tl cxhpAXLM8I3GWe9NFH9aDbQPD2mjmuw0VtS8xhJnT7uPrZR2JpIjw0wxjaKA71G5IGL5 p4BA== X-Gm-Message-State: AC+VfDwJ/zwsilaJLsIfFF99m4kji0AEW4J87dty56J/hc3+pThWV7Lj xMi2npxaZ3cxwxKstlpDPhgfwQ== X-Google-Smtp-Source: ACHHUZ6JgoRzqLA2cz+zc9bNBX0BbFPi/HYzdaITNpGUB6ZbCCjPlDjACy775tc0kp2mlbDWsu4LPw== X-Received: by 2002:a05:6a00:2d0e:b0:641:699:f353 with SMTP id fa14-20020a056a002d0e00b006410699f353mr28047084pfb.22.1683795699855; Thu, 11 May 2023 02:01:39 -0700 (PDT) Received: from localhost ([122.172.82.60]) by smtp.gmail.com with ESMTPSA id x9-20020aa784c9000000b006475f831838sm3820037pfn.30.2023.05.11.02.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 02:01:38 -0700 (PDT) From: Viresh Kumar To: "Rafael J. Wysocki" , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , Markus Elfring , linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: sparc: Don't allocate cpufreq_driver dynamically Date: Thu, 11 May 2023 14:31:00 +0530 Message-Id: <96f7ea2c952075030ab8d24ee2d3983e1b144f36.1683795616.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is no point allocating the cpufreq driver dynamically and add so much complexity in the driver. Do what is done for other cpufreq drivers and statically allocate the cpufreq driver. Reported-by: Markus Elfring Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki --- Looks like I wrote this back in April and forgot to send it :( drivers/cpufreq/sparc-us2e-cpufreq.c | 58 ++++++++-------------------- drivers/cpufreq/sparc-us3-cpufreq.c | 58 ++++++++-------------------- 2 files changed, 34 insertions(+), 82 deletions(-) diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-u= s2e-cpufreq.c index 92acbb25abb3..d3510cfdb3eb 100644 --- a/drivers/cpufreq/sparc-us2e-cpufreq.c +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c @@ -20,8 +20,6 @@ #include #include =20 -static struct cpufreq_driver *cpufreq_us2e_driver; - struct us2e_freq_percpu_info { struct cpufreq_frequency_table table[6]; }; @@ -300,12 +298,19 @@ static int __init us2e_freq_cpu_init(struct cpufreq_p= olicy *policy) =20 static int us2e_freq_cpu_exit(struct cpufreq_policy *policy) { - if (cpufreq_us2e_driver) - us2e_freq_target(policy, 0); - + us2e_freq_target(policy, 0); return 0; } =20 +static struct cpufreq_driver cpufreq_us2e_driver =3D { + .name =3D "UltraSPARC-IIe", + .init =3D us2e_freq_cpu_init, + .verify =3D cpufreq_generic_frequency_table_verify, + .target_index =3D us2e_freq_target, + .get =3D us2e_freq_get, + .exit =3D us2e_freq_cpu_exit, +}; + static int __init us2e_freq_init(void) { unsigned long manuf, impl, ver; @@ -319,39 +324,15 @@ static int __init us2e_freq_init(void) impl =3D ((ver >> 32) & 0xffff); =20 if (manuf =3D=3D 0x17 && impl =3D=3D 0x13) { - struct cpufreq_driver *driver; - - ret =3D -ENOMEM; - driver =3D kzalloc(sizeof(*driver), GFP_KERNEL); - if (!driver) - goto err_out; - - us2e_freq_table =3D kzalloc((NR_CPUS * sizeof(*us2e_freq_table)), - GFP_KERNEL); + us2e_freq_table =3D kzalloc(NR_CPUS * sizeof(*us2e_freq_table), + GFP_KERNEL); if (!us2e_freq_table) - goto err_out; - - driver->init =3D us2e_freq_cpu_init; - driver->verify =3D cpufreq_generic_frequency_table_verify; - driver->target_index =3D us2e_freq_target; - driver->get =3D us2e_freq_get; - driver->exit =3D us2e_freq_cpu_exit; - strcpy(driver->name, "UltraSPARC-IIe"); + return -ENOMEM; =20 - cpufreq_us2e_driver =3D driver; - ret =3D cpufreq_register_driver(driver); + ret =3D cpufreq_register_driver(&cpufreq_us2e_driver); if (ret) - goto err_out; + kfree(us2e_freq_table); =20 - return 0; - -err_out: - if (driver) { - kfree(driver); - cpufreq_us2e_driver =3D NULL; - } - kfree(us2e_freq_table); - us2e_freq_table =3D NULL; return ret; } =20 @@ -360,13 +341,8 @@ static int __init us2e_freq_init(void) =20 static void __exit us2e_freq_exit(void) { - if (cpufreq_us2e_driver) { - cpufreq_unregister_driver(cpufreq_us2e_driver); - kfree(cpufreq_us2e_driver); - cpufreq_us2e_driver =3D NULL; - kfree(us2e_freq_table); - us2e_freq_table =3D NULL; - } + cpufreq_unregister_driver(&cpufreq_us2e_driver); + kfree(us2e_freq_table); } =20 MODULE_AUTHOR("David S. Miller "); diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us= 3-cpufreq.c index e41b35b16afd..91d1ed558136 100644 --- a/drivers/cpufreq/sparc-us3-cpufreq.c +++ b/drivers/cpufreq/sparc-us3-cpufreq.c @@ -19,8 +19,6 @@ #include #include =20 -static struct cpufreq_driver *cpufreq_us3_driver; - struct us3_freq_percpu_info { struct cpufreq_frequency_table table[4]; }; @@ -144,12 +142,19 @@ static int __init us3_freq_cpu_init(struct cpufreq_po= licy *policy) =20 static int us3_freq_cpu_exit(struct cpufreq_policy *policy) { - if (cpufreq_us3_driver) - us3_freq_target(policy, 0); - + us3_freq_target(policy, 0); return 0; } =20 +static struct cpufreq_driver cpufreq_us3_driver =3D { + .name =3D "UltraSPARC-III", + .init =3D us3_freq_cpu_init, + .verify =3D cpufreq_generic_frequency_table_verify, + .target_index =3D us3_freq_target, + .get =3D us3_freq_get, + .exit =3D us3_freq_cpu_exit, +}; + static int __init us3_freq_init(void) { unsigned long manuf, impl, ver; @@ -167,39 +172,15 @@ static int __init us3_freq_init(void) impl =3D=3D CHEETAH_PLUS_IMPL || impl =3D=3D JAGUAR_IMPL || impl =3D=3D PANTHER_IMPL)) { - struct cpufreq_driver *driver; - - ret =3D -ENOMEM; - driver =3D kzalloc(sizeof(*driver), GFP_KERNEL); - if (!driver) - goto err_out; - - us3_freq_table =3D kzalloc((NR_CPUS * sizeof(*us3_freq_table)), - GFP_KERNEL); + us3_freq_table =3D kzalloc(NR_CPUS * sizeof(*us3_freq_table), + GFP_KERNEL); if (!us3_freq_table) - goto err_out; - - driver->init =3D us3_freq_cpu_init; - driver->verify =3D cpufreq_generic_frequency_table_verify; - driver->target_index =3D us3_freq_target; - driver->get =3D us3_freq_get; - driver->exit =3D us3_freq_cpu_exit; - strcpy(driver->name, "UltraSPARC-III"); + return -ENOMEM; =20 - cpufreq_us3_driver =3D driver; - ret =3D cpufreq_register_driver(driver); + ret =3D cpufreq_register_driver(&cpufreq_us3_driver); if (ret) - goto err_out; + kfree(us3_freq_table); =20 - return 0; - -err_out: - if (driver) { - kfree(driver); - cpufreq_us3_driver =3D NULL; - } - kfree(us3_freq_table); - us3_freq_table =3D NULL; return ret; } =20 @@ -208,13 +189,8 @@ static int __init us3_freq_init(void) =20 static void __exit us3_freq_exit(void) { - if (cpufreq_us3_driver) { - cpufreq_unregister_driver(cpufreq_us3_driver); - kfree(cpufreq_us3_driver); - cpufreq_us3_driver =3D NULL; - kfree(us3_freq_table); - us3_freq_table =3D NULL; - } + cpufreq_unregister_driver(&cpufreq_us3_driver); + kfree(us3_freq_table); } =20 MODULE_AUTHOR("David S. Miller "); --=20 2.31.1.272.g89b43f80a514