From nobody Wed Dec 17 06:13:36 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D99D33E34C for ; Mon, 15 Dec 2025 14:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808283; cv=none; b=gE6J+qVQD0bYK0EW1wzqckOqLSObnY9gOL94kvTSjyoPi27eS/6ye7S0X0Nwerwlr2SOgqHlKTXi/QT7MTA/HKyqs9XQ1HI61DxnyLtYvkMpXNGWTd+3RoZqRphnv+405BQFMlY2bmxBsI/hDQU1zJyJuG8Eoyf3tC1kzIqfKvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808283; c=relaxed/simple; bh=Kkjk2HQyXaBvr0FeLY8PHK1oOoMWNcJDWQq+WFZGpZA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qQZUQpW9QfXlZADRDB8Vmhdi6k4I1EK9XV8fv8ArEx8C6TdK7oLDdQOFquieNXrWTiwmtQ/uXxGQXOcBPADX61o+P3ZHabiJSSB1gjRVTklVnScoaRlm9GzM5E4qhHhPXvoO7fEX+xffmSYSv2EcEQoziE0gdxHQsEX4ayXijDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=LBjmBYOw; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="LBjmBYOw" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-b725ead5800so534783966b.1 for ; Mon, 15 Dec 2025 06:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808277; x=1766413077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7iqJF7orvlMqhIrghvfFQasl/uMqZ7gfWiSQOSJzmXI=; b=LBjmBYOw/a1epGCKyuNDnRTSqpAXSOdCu2WsyKxvKWCjjxDlfYSNvYCYC7BnJmOoMG LHw1tY5MqS11eoZD6IOIGMH5nMs7bdLI/nmAK3+pqzj3YFYNsPwL8qY9KnvzBWzbyBno DbxUfdxtr36sCNu8aheqQoyRuC1YTAv5JLZaxs19V2O6QMeD0i8Fxi+acdkjFkODE1CA x08I7v/U3afCPwGBLuQn3w6wTS6DzUp4AJhVXYR/YFlytKw+pqtG7L4p6T7UZHXHTUH6 CeCzAjNqn9lEjoRCq9mk9knpv8mA/k5KmyDUc8hVof2JC3O6o8o3O0cFxXPHw8mVSvFT Wt9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808277; x=1766413077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7iqJF7orvlMqhIrghvfFQasl/uMqZ7gfWiSQOSJzmXI=; b=cp7HC2UkKIUuBALIOXXofUp98TB5yAJX+Aeui2BKD2em4ZfT69usu33V15ui2B4n01 l3iZd3/OjvDW4X/aVLrkpB0Wy7F6w0Tgp9DhCr0Isuys1bhPj5ldQ7soST+ahd3NEKgU 6Pa1mDS/fTfwjv40RVk2kaa02kWFICsqMpirrikLQt+v1wLhTCuvMVOK4Tzj25Npqyi0 Gs5O+I6ZxM4RagqNi3N0fqYfgROwb6YpmqiEdrcG7sObXrrlVSWDgin0EBBiDNMK8yL/ u92TpSzLCoy4DHXymrWCgbgMkvPCTIbD2ldlMkjt1yxujlV+9h+44B2eq+lEsjEM3rkQ Czog== X-Forwarded-Encrypted: i=1; AJvYcCU5PYC1IMTZYxz9l2DmlEfBmnY2pRQ+NZcVa8Ke986I7tLvxuhgP6PKF3fr8psp4Sj6QHdyQca4s7d/f1c=@vger.kernel.org X-Gm-Message-State: AOJu0YwEFAf4DygtHBr/uBkiFEq1JL8E7pPrCFcKxAl4XLlVO//u0Mxc RvRdIZujWo4s1Dv54ggPLAmEQIMWpui300XcDWuJFt1vs3B/VaBLvQ0d2t2kXBs3jHg= X-Gm-Gg: AY/fxX6CcefQsbcMnoTdF7Vp9R6ExR4z9KE14UrpBjsmXpqb0TPvlNrH4SOlUznDsYQ jKKr8Kt1bk/WBBmfhzrAl8FO5C3NRYFvetUzcJW6rupK6ZGpvToeaO0qGhI0OvY+IqE1AOuoQWS IPkN9+OHm1YlbDb+Z9YBK9EcOoa/Y8kndVp4+hjSoAOrOVRD4nC+py6AvWAMGKBgQwVKEcsMD49 HEuoTrNs4hXQoHNUZKm8pXkK25UGV1za/XvLaTOe4XFzxY+AAYFxDwVvyTBtmus4psLkdUWbbpz pmIGcUXlZh3Zdu2Fwm+g+W6Pq0hXwOCIetUh5NGINcxnvsyYMH3kuIbkRQyoZQqb40P2qw/LXoT SGdEMxdwR0P5njxvMYcxV+REo/GtWx5Lq04g1cOEp3PkiEQdH8HwB3nWNSfhxNLSeIuLydnE+9l VSuXkyfLm3ods2MTVxVeAWzJxPvirbteKNcF3lcdojJ9c2Iwm8MaXV9a6bsA== X-Google-Smtp-Source: AGHT+IEPjHTBezRQ3PDr8F60Bso0OUB75ZXwyfvhYmt5eGS3puxlFDVYpAwYmpGEYvObi0dAnABghw== X-Received: by 2002:a17:907:6e90:b0:b73:78f3:15c1 with SMTP id a640c23a62f3a-b7d23b92012mr1014789266b.52.1765808276856; Mon, 15 Dec 2025 06:17:56 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b7cfa29eb48sm1444020266b.1.2025.12.15.06.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:56 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Michael Chan , Pavan Chebbi Cc: Sumit Garg , linux-mips@vger.kernel.org, netdev@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 13/17] firmware: tee_bnxt: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:43 +0100 Message-ID: <96f7df595a96f631b40c2c0a6fcf8bf7217d02f4.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2314; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=Kkjk2HQyXaBvr0FeLY8PHK1oOoMWNcJDWQq+WFZGpZA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpQBhsfHXkwvq5lo/liy5xLt/2zfSDHM/HASEZs rSXC1P7uA6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaUAYbAAKCRCPgPtYfRL+ TjIHCACKt2PBL1ggi18gXW89o2wjtHLVPQLHCVpHjtN5rjdFvrbEnb8GMhyPmXCkVmVoss7QFdW UbeQereVoPtirVXXeCZWy9g9T0WSKPbeURogL5yJ2CUFbRV2xnjlstiWQSVm8Kqzp+SWAZYvYR6 Jztwhm3a/vQfJOJNAs+QMLGr29GLfItZLW+6/mxmfWWm/PF5PYmA21k/UylJImDTGlrdDl7dqRS jWesv1pzELsMZ/EHQnDEoPByjLvWWtbbrLxTZeTrZ+rN3pJcjTYAsDtLb2/VHlwBg2B397iMbbw yyAwbQOxcIWjlvWNJA4Li96zLkxmhy9Rrt6Lw5ZiJ62bSLDC X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Reviewed-by: Sumit Garg Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/broadcom/tee_bnxt_fw.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/bro= adcom/tee_bnxt_fw.c index fbdf1aa97c82..a706c84eb2b6 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -181,9 +181,9 @@ static int optee_ctx_match(struct tee_ioctl_version_dat= a *ver, const void *data) return (ver->impl_id =3D=3D TEE_IMPL_ID_OPTEE); } =20 -static int tee_bnxt_fw_probe(struct device *dev) +static int tee_bnxt_fw_probe(struct tee_client_device *bnxt_device) { - struct tee_client_device *bnxt_device =3D to_tee_client_device(dev); + struct device *dev =3D &bnxt_device->dev; int ret, err =3D -ENODEV; struct tee_ioctl_open_session_arg sess_arg; struct tee_shm *fw_shm_pool; @@ -231,17 +231,15 @@ static int tee_bnxt_fw_probe(struct device *dev) return err; } =20 -static int tee_bnxt_fw_remove(struct device *dev) +static void tee_bnxt_fw_remove(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); tee_client_close_context(pvt_data.ctx); pvt_data.ctx =3D NULL; - - return 0; } =20 -static void tee_bnxt_fw_shutdown(struct device *dev) +static void tee_bnxt_fw_shutdown(struct tee_client_device *bnxt_device) { tee_shm_free(pvt_data.fw_shm_pool); tee_client_close_session(pvt_data.ctx, pvt_data.session_id); @@ -258,12 +256,12 @@ static const struct tee_client_device_id tee_bnxt_fw_= id_table[] =3D { MODULE_DEVICE_TABLE(tee, tee_bnxt_fw_id_table); =20 static struct tee_client_driver tee_bnxt_fw_driver =3D { + .probe =3D tee_bnxt_fw_probe, + .remove =3D tee_bnxt_fw_remove, + .shutdown =3D tee_bnxt_fw_shutdown, .id_table =3D tee_bnxt_fw_id_table, .driver =3D { .name =3D KBUILD_MODNAME, - .probe =3D tee_bnxt_fw_probe, - .remove =3D tee_bnxt_fw_remove, - .shutdown =3D tee_bnxt_fw_shutdown, }, }; =20 --=20 2.47.3