From nobody Fri Feb 13 14:12:02 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A7CCE7A88 for ; Sat, 23 Sep 2023 12:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231494AbjIWMRV (ORCPT ); Sat, 23 Sep 2023 08:17:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231405AbjIWMRT (ORCPT ); Sat, 23 Sep 2023 08:17:19 -0400 Received: from smtp.smtpout.orange.fr (smtp-24.smtpout.orange.fr [80.12.242.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C804199 for ; Sat, 23 Sep 2023 05:17:11 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id k1ZLq0FE4ttXNk1ZLq9cSW; Sat, 23 Sep 2023 14:17:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1695471430; bh=MZ+x3+dMxPzCGceJF8/93Shpse4vUvBYF6v0b3D2kfE=; h=From:To:Cc:Subject:Date; b=pWrkqoYWrs+z0eZtol7HHfGiyoEXhV/dOMobQxnDEhy6fd6vb/VVWl+xgiAj4FXnz 4PvjXGd+S2o3TMbt4Ut7bO62rSgDkrpmxKcfbTt9ZBgTg+WQ1X+cRAIwr8ZPvxx+TL unF0hAolnIG5mmLcu0WkE4eqgFOYmtiwp+867RTzbgveloEchATdFmfzfB359NaQHC y2nJVmMr/0cV50aDKXwfsgFzViVX8Rul99nI4gR5DjZMggg/qrfGY34L7oFPnBMrvX SvRULTOQBPjgKYToaahMrfT2APagS9YohRwfVWOAZ9IrPna8uYXnvjEX6NrQaznMMa +RLYynY5dib/w== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 23 Sep 2023 14:17:10 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: [PATCH net-next] iavf: Avoid a memory allocation in iavf_print_link_message() Date: Sat, 23 Sep 2023 14:17:05 +0200 Message-Id: <966968bda15a7128a381b589329184dfea3e0548.1695471387.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within iavf_print_link_message(). 'speed' is only used with some snprintf() and netdev_info() calls. So there is no real use to kzalloc()/free() it. Use the stack instead. This saves a memory allocation. Signed-off-by: Christophe JAILLET Reviewed-by: Przemek Kitszel --- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/= ethernet/intel/iavf/iavf_virtchnl.c index 8ce6389b5815..980dc69d7fbe 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -1389,18 +1389,14 @@ void iavf_disable_vlan_insertion_v2(struct iavf_ada= pter *adapter, u16 tpid) static void iavf_print_link_message(struct iavf_adapter *adapter) { struct net_device *netdev =3D adapter->netdev; + char speed[IAVF_MAX_SPEED_STRLEN]; int link_speed_mbps; - char *speed; =20 if (!adapter->link_up) { netdev_info(netdev, "NIC Link is Down\n"); return; } =20 - speed =3D kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL); - if (!speed) - return; - if (ADV_LINK_SUPPORT(adapter)) { link_speed_mbps =3D adapter->link_speed_mbps; goto print_link_msg; @@ -1452,7 +1448,6 @@ static void iavf_print_link_message(struct iavf_adapt= er *adapter) } =20 netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed); - kfree(speed); } =20 /** --=20 2.34.1