From nobody Mon Dec 1 23:04:10 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5C513016EC for ; Sun, 30 Nov 2025 23:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545746; cv=none; b=NUyUKYkQz9x/zOcWtmYIQjcl6MsVpvdUw5sOvnMTd8HJsQGkFMCkONHSCMYUmEtCQx7GCo48/Y1me/zB/8p9umO/F2oScUyuEEtLq/bt6k2CJaJUAHfK4ggLqOAX3Rnnu7mw65MOGEyf4F3iGw0lcen2YexmhMEZNpOQjXNYbVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545746; c=relaxed/simple; bh=yKCm3JWX46w3TSeS1HDjGDEN8Lb+RgGnnDzf1hIzpyg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OKz1yOB6SUIn/YXOf8VBulMZpqpdPxOdqMS1CzapQSQgb55h6P1okEJ5H0ON4UMhNat3Q27QmlG/wnPdn9XNJeT70Obfr5ebDUbdmUEioMKFhgGpIGNFNG7X52eZRYk8pFRfMLaqPDt9IHF6u6UETQKlhtPrX+iAYL2wAdJ9MZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N+0soFpq; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N+0soFpq" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-47755de027eso23248255e9.0 for ; Sun, 30 Nov 2025 15:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764545743; x=1765150543; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HX9L7y9TUVKUZMrEe/EUsMICdbihgCRR79vdhXFo/qA=; b=N+0soFpqHul603HIj5zHoSIfWc5W9GiN6vklkHMVCs+W4/neQtP3pzS0yfITiq28bG 1izqBmz0Vq+fFKQ90rZEKWfeAmlDKPBAVTfnKXldC1ZylLjyioNEh0rQ6vIW6bjHxWwb dXc16NPNkz+eQ3kl80Ti+ATMzdbzHq/OZvtcgJ0eCzm3zsHw6eedbvvEogje1iB8l+oI inpqFusTXLkC/LWcYbmtLwuFDBKMJ/1tXQRoaDHMXWgrEEoHrkJjEig8DI316DClAjP5 5iNp8pL5Ib8wkKyjZvbfl27mruFlb4/Lv1r3nw4lqegb/2efQpLsdF6pEzuG6v8b2Pwv 13Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764545743; x=1765150543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HX9L7y9TUVKUZMrEe/EUsMICdbihgCRR79vdhXFo/qA=; b=CASwKlTwJ7nff42bl9aslfpXtSyc5jU3OfmK2VTc+XObrNM+Q9vURLmPoEmpPB6M64 CwzhJiPC6P0UYbL226sxXf4G1Ly2DH/sybfLWun60uiqu52N3oXD/dVp0D/O0OIl1bbK euMpxYqL41gijOZOJ0WcMUrs2WLVDFBBmsAs4EnrpJJAFXyQvxrrkjZw3iSwTAzGPwI/ dz+71wJ0pvwPQQTYCPxTmuGAgl4eQPBDuU+r+DNVHbuv1d7cM4FvEFImFOfN6LOEiuiR LeatLAX670YtFNWY0LeNmFzjinCwcuQJnfKSnx/Xwexvgmq93pxWKABtK9QV1KPPH0dZ cF+w== X-Forwarded-Encrypted: i=1; AJvYcCUUFI/Th6MNPX4LBUZWtA+3T8e/jJOl6kRJq6smqiYqhJ6wgJvBXYsB0kz3yt5INyJEKaWyWx8erRtlMa8=@vger.kernel.org X-Gm-Message-State: AOJu0YxviNCrYGRltdRkMvdaezNFbvLiGMy19KyfOZfn9ti1s3kThtIB Ly93fZIcLP2sfnxNoORzf/WRTmgLIH9pUuds7DvBjQLT4cx96Fge4fzC X-Gm-Gg: ASbGncsFyLAq8FDrmTeNl4+3rYHS7L17aHr2/GJFi1BO8QP7HVIDBkQ01iyTiV715N6 bb//KjvHKxE9+u68tMyPsEkJZ9VSfqeLWsW8AcYhWoDpJg0nB2Kkblx7XVnoCezp2tnSHr1Ug2O VlEEspIs52bIGzdofUjoDP5UtQeVBWYaTfR2IX5RHBPc4oCXlQvooxw8ccl7HxRXfzNbfPe+FwP pbXmJxLHx3WxCHNeHvkVhHhXCmUKUz+I/juTMVl5nyQMxRp7FWe8OCu+JPve4N6HWgMjhb9r1io ehcZOHUc/h7nE9UClh592m1VbSaDvcws2Rw4MtvNgx5Vf35eIPg5kIKnawiWI0EyDyeLgnGqLZW +8t+QqcythOrY1asypSrdDe/Ls8r7Omr5aB/ilL6yZbpMnbQn1zMEjAvKOIjQV8i2QO2U6KuE05 l5Lf4K/6FoFyUDhXgpfEY2ozu0iXru2ukJ99IDlyzzk5MrP5nOldzUypDs9h9r/RtAH03tON0pb y3xbvU73VITPTW7 X-Google-Smtp-Source: AGHT+IEXud9v2I+TjLUDj/xk+alqLhuWUdH7fEpxpL99N2ZrU2hz5Df/0YCDMBC9pg3l3cG4o9WBpg== X-Received: by 2002:a05:600c:4e91:b0:477:7a95:b971 with SMTP id 5b1f17b1804b1-47904b2c3dfmr250016755e9.31.1764545742979; Sun, 30 Nov 2025 15:35:42 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479040b3092sm142722075e9.1.2025.11.30.15.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 15:35:42 -0800 (PST) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Ilias Apalodimas , Shuah Khan , Mina Almasry , Stanislav Fomichev , Pavel Begunkov , Yue Haibing , David Wei , Haiyue Wang , Jens Axboe , Joe Damato , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, io-uring@vger.kernel.org, dtatulea@nvidia.com Subject: [PATCH net-next v7 7/9] eth: bnxt: allow providers to set rx buf size Date: Sun, 30 Nov 2025 23:35:22 +0000 Message-ID: <95566e5d1b75abcaefe3dca9a52015c2b5f04933.1764542851.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Implement NDO_QUEUE_RX_BUF_SIZE and take the rx buf size from the memory providers. Signed-off-by: Pavel Begunkov --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 34 +++++++++++++++++++++++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 + 2 files changed, 35 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index e9840165c7d0..0eff527c267b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -15932,16 +15932,46 @@ static const struct netdev_stat_ops bnxt_stat_ops= =3D { .get_base_stats =3D bnxt_get_base_stats, }; =20 +static ssize_t bnxt_get_rx_buf_size(struct bnxt *bp, int rxq_idx) +{ + struct netdev_rx_queue *rxq =3D __netif_get_rx_queue(bp->dev, rxq_idx); + size_t rx_buf_size; + + rx_buf_size =3D rxq->mp_params.rx_buf_len; + if (!rx_buf_size) + return BNXT_RX_PAGE_SIZE; + + /* Older chips need MSS calc so rx_buf_len is not supported, + * but we don't set queue ops for them so we should never get here. + */ + if (!(bp->flags & BNXT_FLAG_CHIP_P5_PLUS)) + return -EINVAL; + + if (!is_power_of_2(rx_buf_size)) + return -ERANGE; + + if (rx_buf_size < BNXT_RX_PAGE_SIZE || + rx_buf_size > BNXT_MAX_RX_PAGE_SIZE) + return -ERANGE; + + return rx_buf_size; +} + static int bnxt_queue_mem_alloc(struct net_device *dev, void *qmem, int id= x) { struct bnxt_rx_ring_info *rxr, *clone; struct bnxt *bp =3D netdev_priv(dev); struct bnxt_ring_struct *ring; + ssize_t rx_buf_size; int rc; =20 if (!bp->rx_ring) return -ENETDOWN; =20 + rx_buf_size =3D bnxt_get_rx_buf_size(bp, idx); + if (rx_buf_size < 0) + return rx_buf_size; + rxr =3D &bp->rx_ring[idx]; clone =3D qmem; memcpy(clone, rxr, sizeof(*rxr)); @@ -15953,6 +15983,7 @@ static int bnxt_queue_mem_alloc(struct net_device *= dev, void *qmem, int idx) clone->rx_sw_agg_prod =3D 0; clone->rx_next_cons =3D 0; clone->need_head_pool =3D false; + clone->rx_page_size =3D rx_buf_size; =20 rc =3D bnxt_alloc_rx_page_pool(bp, clone, rxr->page_pool->p.nid); if (rc) @@ -16079,6 +16110,8 @@ static void bnxt_copy_rx_ring(struct bnxt *bp, src_ring =3D &src->rx_agg_ring_struct; src_rmem =3D &src_ring->ring_mem; =20 + dst->rx_page_size =3D src->rx_page_size; + WARN_ON(dst_rmem->nr_pages !=3D src_rmem->nr_pages); WARN_ON(dst_rmem->page_size !=3D src_rmem->page_size); WARN_ON(dst_rmem->flags !=3D src_rmem->flags); @@ -16231,6 +16264,7 @@ static const struct netdev_queue_mgmt_ops bnxt_queu= e_mgmt_ops =3D { .ndo_queue_mem_free =3D bnxt_queue_mem_free, .ndo_queue_start =3D bnxt_queue_start, .ndo_queue_stop =3D bnxt_queue_stop, + .supported_params =3D NDO_QUEUE_RX_BUF_SIZE, }; =20 static void bnxt_remove_one(struct pci_dev *pdev) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 4c880a9fba92..d245eefbbdda 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -760,6 +760,7 @@ struct nqe_cn { #endif =20 #define BNXT_RX_PAGE_SIZE (1 << BNXT_RX_PAGE_SHIFT) +#define BNXT_MAX_RX_PAGE_SIZE BIT(15) =20 #define BNXT_MAX_MTU 9500 =20 --=20 2.52.0