From nobody Sat Jun 13 03:33:03 2026 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013058.outbound.protection.outlook.com [40.107.201.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC3652BE05F for ; Mon, 11 May 2026 06:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778481037; cv=fail; b=WZQlsamdx6mhn/6I0b6aa+bxqrdsqB3IpYozSNpn3nQ9au5GXzWeXz8TNCDFrnoEe+jnq3zI2LC0+NeEC27WxXpcLDAjoqRAjcEMVCubmG3p6ssTrCBeCp8FR+Uq0QSM/aEGpFgHxlca7aTYqBcyqB5CY/OTvWU/4GDkF0dRN70= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778481037; c=relaxed/simple; bh=zQGy2NC7erKJ5r2UH8nB7PuG/z0afBeie+yZP5pVvSA=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=rJmFiecIQlxOFGC2LJ3JW7kUCGWMY8NjGeGMHf9+ePWbQGYjA6gMo+l2iTv0nKgGK7+4xnqnHYWIMIpOjhD39g5yTQYqk9nzkzwCJLVwZi9jukqtnXlNxEismGSkE+mya6yoGteQ4d7AC+eiCUzyQjZbXXxZNCwm226d1hUJO5Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com; spf=pass smtp.mailfrom=altera.com; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b=R9QU++ou; arc=fail smtp.client-ip=40.107.201.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=altera.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=altera.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=altera.com header.i=@altera.com header.b="R9QU++ou" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AqD8GTJgrhecVl1diik+IzEVjZfdkMrabt7au7jT3S8de8lKEJTmqkiqL/0E6YGZnvztoBS6xc2sc/EDZL2Wm4GdO6C8LLoePJV2LKmJohc/RWwoMxCV/GppYvIQYeXPFbLhuaegesHagA5LDgTOx8eNqmzfjgTvwifBXeSJM8QhrUzdHMTbK1Qcjtm6pXjJVME6q0w43oEsuQK2+Hofe/7hKCLb5htRsWg9kqIU768cl69qodA2WRxAD+Z2JFDdEbZJtEMjQIbvxh3XKCFHklzDBE+fMZlCDzSJrzzbZezWUDNvIUJhVhHN6R5g7BlRg3U5O2H3p6XHLLo+p0mxMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Niza00PouxTyarrH91Vza7HfhVV8XLkADNf1l+Dua6s=; b=FZPOe3ZMjUbnXPkR7E0Rs+J6eLEQOBFRZ7PlIrD3WyuYi4FJSHkeYreW1y2UHpVQSnkQGIGY6SMBOCshTA2GATgqRxvHV4i7osHAkUFyOdkJWtgFgR3Y1ns0r9ZH0GX6QlJ+ic0NSXI1Qqk74A/a1+Qy2RPc3JZCqPlal5S5u6fB1grJOMVIHvG5i3lrMHHrqqyNBpcnrBbLumSudk8b+xVpCSqrYHYN0bUmDfaq0dc/tJaiT1ObgFEjuTThK/JNihrXR7NJqoA3G5X8kgR5MoWvVhxqurhwI3dOMFKY5GjpGSmryNbrq0Bt72tAn3A20gIqVQuDISljmXH2AyVKJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=altera.com; dmarc=pass action=none header.from=altera.com; dkim=pass header.d=altera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=altera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Niza00PouxTyarrH91Vza7HfhVV8XLkADNf1l+Dua6s=; b=R9QU++ouJhMol8F8JAAz7FRj7D/nCLs4TUF5jSPFN9m0UYU3iaUfBv3rtHZ0tNY5a3wfUlaYsNB8aAEYJc3Or1xHivyAxywI7k+/YB4XERfrf6doMOn0CAc54US3a2JF+2IwKRmVVedGFcQJPg995H2GEM46d/mAarV3+vEQ9WDggri7Lnxy5qAuIcvoeokorZ/hzPX3opCBHrjHrXmZIvOIBPP+URgZhiMtGvjcs/Y8jp39FvDT/HGsAtZKbg5WVLYbdi3tudHrcxH/pBtPCuGTV5vPZuw2+A6ACQ9kronBSkQ0+vaU5P6x62IysQ6UoA+ew4yfxjmAuznShwQ/Zw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=altera.com; Received: from DM8PR03MB6230.namprd03.prod.outlook.com (2603:10b6:8:3c::13) by DS1PR03MB7822.namprd03.prod.outlook.com (2603:10b6:8:21e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.22; Mon, 11 May 2026 06:30:33 +0000 Received: from DM8PR03MB6230.namprd03.prod.outlook.com ([fe80::abad:9d80:7a13:9542]) by DM8PR03MB6230.namprd03.prod.outlook.com ([fe80::abad:9d80:7a13:9542%4]) with mapi id 15.20.9870.023; Mon, 11 May 2026 06:30:33 +0000 From: Adrian Ng Ho Yin To: Dinh Nguyen , linux-kernel@vger.kernel.org Cc: Adrian Ng Ho Yin Subject: [PATCH] firmware: stratix10-svc: remove RSU command exclusion from no-support callback Date: Mon, 11 May 2026 14:25:34 +0800 Message-ID: <94bea0ef315adab7a8f9f9a4514eb961a9ea7be7.1778480470.git.adrian.ho.yin.ng@altera.com> X-Mailer: git-send-email 2.49.GIT Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0078.namprd03.prod.outlook.com (2603:10b6:a03:331::23) To DM8PR03MB6230.namprd03.prod.outlook.com (2603:10b6:8:3c::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR03MB6230:EE_|DS1PR03MB7822:EE_ X-MS-Office365-Filtering-Correlation-Id: e57ead59-b164-4d5e-9f6e-08deaf26cdce X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024|18002099003|55112099003|56012099003|3023799003; X-Microsoft-Antispam-Message-Info: k0mwYuIN9ZJo5XIAeryDNKDcHT/YHobHTUUKHu7XHZkdPb3Nte6fLcR7CCni5IVWVUCoQPCagI3ipHkdorKzZ1bUpvIl4uelAfoxOHJU+4NOLWAoHD/IThVkYebCdXz4cz5mI9FfEvKXh0R1Vb5SSbxDMiwPDuz8dLmPaWqVCGTc4I9xHjpYtsZo3KcCv//SE0NsAAQsMW+Z/ZETRGH2IrjgTJeBCkipCdUf4Yd8lI1npvioN9nxg6T5QT4jOHXGwRmikmGUTJj+Zz4ujgioLypcFPmHl4gzAChvITimMvTphTLY+90IhANN7JpXh0FrcohnX+hHHRhCKyZJuh6V4VFxOPZ0pf/x0WTfhvmSKAGbbwvSZxKxixNt4kPjJpCr/KQXkyWQps+Tq4TReepkaT7kqK9dyDX7YV8JO7ySIuyj2NOATtNlT1EYjQ8k5eXIhgL9UBTpUt852H0jA/CPhyToiwGErZNhX+8EmIWiqTLf7yuIbKKiLIucLjcTR+7hJHgiJ5e1sEPrKtOMjqDlHeCc8uugM7jTOmO+Fdc8wP+OI0ZOeVt64FW9uggy4rlbEx8CWt6HoPjTC7ml4PJxQeQ+yBk7Tj/q3Q1YslPpu2wr2EwauXDBDrNNlM8qRjeifUA5DJigCFptduUsJwrmPTJt8Bi1+lb665k8gNxZ2Qx5wTlv+XanzuxiQA24J/Hn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM8PR03MB6230.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(18002099003)(55112099003)(56012099003)(3023799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Dj7PVd2isb8bBksL4w0GHCe3FuAKboq88d61KoYVGFre7MbLIll8zfpWVzG?= =?us-ascii?Q?AnMBQGyf4OOSlWegn7NMzltMUdYk/ABwPVFRKYgl96GnXORlCY+OrOV4sPur?= =?us-ascii?Q?5SbN8gdDDv71XwAy58yajAF5HD+S1Sn3M9KqXLF/1d1ELUnkDehhn7W4TvCi?= =?us-ascii?Q?Csl0CpDfgT6RSjK+m1mHcLk8+nmQhoTR0jOD8xH1umNk5A0xt4mw3G5KoBDU?= =?us-ascii?Q?qFg+y7rLyC4pcwZJr8+TWJ8pLlo0XaqILqB9JF6Tw4IOgIYTk/j7pCFObSA3?= =?us-ascii?Q?+p2chAxgAbDKkZSvqhkShLzNBpoSjyKHJApYiKwCmWkWGGeLz8ggHvkeyV0B?= =?us-ascii?Q?2p6mQMYXsoorIywMzDhHZi9EIo/zDElH/doC1met1Di7bonDSFAcQQarasdU?= =?us-ascii?Q?dkdUn5CityEM56KvdhlPL/lOySMB32SIgaYrmhYDa/jUI2QYbnE6b45bn8Hr?= =?us-ascii?Q?6JSpIvv6SzqsU30P4oNGh3seE6Et4dOde61aT+NRxKS73COh8F+XS3w8RTOc?= =?us-ascii?Q?gnbozxRxo2LGNtM8aQf/hl70OmQqnNc+mJvBdYH9vXYKlqFgGD2vncUUF8yZ?= =?us-ascii?Q?BRMOVi/+C/rgF8NhBuM6b/p6hUEGkbooVk/AsHwusWfjpHrPfPANytB9PHPx?= =?us-ascii?Q?P5hpYTbACW3xtDnW/fy2TRLQM9E2t2pUaOFpsl0MOxZRa2tqt1UExwBYz+6T?= =?us-ascii?Q?QoLrbGStFxDYJ3b1cm277qX1h5jttqrEuf9VCtmwkXEd0kztNKE92faQKGyN?= =?us-ascii?Q?3QbvAF1g6mHBr1WdrEpNOvs8RmMm9M6d3xjhxijROaBey0YU1wsOHZjVOo+/?= =?us-ascii?Q?Mafre5Q3DJ9DffOnTrVnnNYvFcoX+AErPMKWE5/HP0PzF9qrqTmLI7MxrHNr?= =?us-ascii?Q?W3yzuAr9T5HfucplrIKmRi6+uXF8Y9ZCzAj25A2K66fu6lvcf6e4bJrLitMr?= =?us-ascii?Q?ZYQ3iKtr/2zJ0HvBa2nO7kuYocgL4beex4aJCsBcxEmQULExKFUDund9np4R?= =?us-ascii?Q?pIcN2+7aSqRpedKz/1MRaWDSdKSAN/EfM35CdLwI+7+u5JX6A+fW6PthfIPc?= =?us-ascii?Q?A4t/xKPoUVU18TXNqtHxdowSKpsoXw2TZMl4i5JujiJnsgoM+Uw5X/+YZHlm?= =?us-ascii?Q?wb23GYnS4mRge+Esu6yAlvm/MT33/vznh6IHJbDKpQNslPPQOW8VXC6RU1D3?= =?us-ascii?Q?ZmC8lDuFkrju24/zW3hmwwnfWNh4ofme0r2grbZBHJBIV7C5yYgH2ypNvdif?= =?us-ascii?Q?ua8XojppOIwtsfkgl55YFLJd7XSkwPJYagXpAMx1NSMrbhfMmCfwZVqhYKTP?= =?us-ascii?Q?EUH+PgpcAdgXKnCaN6vFCWzKKQCv//jWNc1Diqq1qt+JOhqWFTgr8Q0KwNpS?= =?us-ascii?Q?rI2ljcCdvwvlFV4tsqIroP/7GTLvQpZTPjMC1JRjiRa5Td7kwVFOCntDHvwS?= =?us-ascii?Q?ktuyxhjNFSTg55tHhgZOuAQSmr6OkXhD1MbZz9qfFHO1qHxutTorkd0VFNub?= =?us-ascii?Q?Hw1VghlpCqAvhBZxIgtsVY1hZnxaPBVCCnyHjWbKHwHM9WFAb6t7b4CyK5vF?= =?us-ascii?Q?eDTrPpgEna2Cslq1b1mQGLRm1+j0p9Zam3a/HIbPy04+hXtkL8iKdThuPDcH?= =?us-ascii?Q?1bo3VNH9Ef/cPXzqcmOPCpizYBalo8MvW2XXqrAGZElPQ/5CSJNBjKC/aNpS?= =?us-ascii?Q?G+ih+wpbYuRMDWn8TEl17pn/OZwm6FF3x4iWjLe2pXlQI5/YwL4Zw6xy8Nj0?= =?us-ascii?Q?TniIqpX5N7mOWeNTctkZ3zNnMov6PTM=3D?= X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-Network-Message-Id: e57ead59-b164-4d5e-9f6e-08deaf26cdce X-MS-Exchange-CrossTenant-AuthSource: DM8PR03MB6230.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2026 06:30:33.2692 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1j4aHLid3/HJoOa6WspgQGS7ehqr/5UpZil9e2tCzhqgv6Ciw7dYOnWu7NaH5N8VEv26/lj8RLoXw0zVJJE+r0yk1r4EKSewv+ZWHwl64mI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR03MB7822 Content-Type: text/plain; charset="utf-8" Remove the compatibility workaround for older firmware that excluded COMMAND_RSU_UPDATE and COMMAND_RSU_STATUS from the no-support callback. This exclusion caused receive_cb to never be invoked for these commands when firmware returned an unsupported response, leaving callers waiting indefinitely. Always invoke receive_cb with SVC_STATUS_NO_SUPPORT when the secure firmware does not recognise a command, regardless of command type. Signed-off-by: Adrian Ng Ho Yin --- drivers/firmware/stratix10-svc.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-= svc.c index 39eb78f5905b..199e5673677f 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -803,20 +803,11 @@ static int svc_normal_to_secure_thread(void *data) default: pr_warn("Secure firmware doesn't support...\n"); =20 - /* - * be compatible with older version firmware which - * doesn't support newer RSU commands - */ - if ((pdata->command !=3D COMMAND_RSU_UPDATE) && - (pdata->command !=3D COMMAND_RSU_STATUS)) { - cbdata->status =3D - BIT(SVC_STATUS_NO_SUPPORT); - cbdata->kaddr1 =3D NULL; - cbdata->kaddr2 =3D NULL; - cbdata->kaddr3 =3D NULL; - pdata->chan->scl->receive_cb( - pdata->chan->scl, cbdata); - } + cbdata->status =3D BIT(SVC_STATUS_NO_SUPPORT); + cbdata->kaddr1 =3D NULL; + cbdata->kaddr2 =3D NULL; + cbdata->kaddr3 =3D NULL; + pdata->chan->scl->receive_cb(pdata->chan->scl, cbdata); break; =20 } --=20 2.49.GIT