From nobody Tue Apr 7 01:03:54 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F9D3E715F for ; Tue, 17 Mar 2026 14:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758433; cv=none; b=EhquIlfVpm+Oo2nfUo3aaDxGvmBZNG2ougZBoZOzpPmDtEr+GfL4BKGfP+XatBVzhOBCVlk71W+7upN0mIY7FsjdvZPZ69WCBNm3p8tr3QvMBnZDglSkHA9lW2XrWvVd8rzWLSJmXzjFEypWdaKoUoyqryB6bY9F/q/beC50rPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758433; c=relaxed/simple; bh=QSVp1mWaCYgYRgy5a5HQ19iOrMMTTGsbfTF8zOBjanE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WVakvgS8OKGYIPoG/9QVc3ApTHgV74Bdt3ravXpy7bF5I5PwZw1cf83jbHhOc4jkUBE1hnzU8SEqTv8kBc6k10WIOkle9JyBQbx0RdsaupwRwSQKglHDD2F0YcMQwoQGH7EHTsJdGxGhDHvIBcqKer1zGU+0rMPT7lBgJb+Jbd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KEDJcT3f; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KEDJcT3f" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b932fe2e1a7so708069166b.1 for ; Tue, 17 Mar 2026 07:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773758431; x=1774363231; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6oGuZGWOJwSB6f8V0h3mJxMfgC0ILfRIiCjXkY39JNU=; b=KEDJcT3fq1w4eEIZAy8v5a90pDKsYyhnD5XQ8jR+QDoOv7cu+HCOFff1kM0SrUXbtp E0gO8ymF7pEanG/H5WhUh5+lSXCa3SaGt8xOnAeptDYP3D3MymCL4aVCXPonbrFdhDO8 ayxSi1t6nIflBv49McyjjW4tDbJvZAGMD4hs/jZN7oE6QYC8DPgRdlo9DI/+p7pbzdQT uUd+GlExjI3OrNu8L0T+rhKHGAxpanXwdDr+vxVsSiw/7ZrfUZcFDJusRlnIgbdiy/cO 03XdQbyg+B9LQ6HrK3k8m9yXeZgSwM17DjSkmmxD//eT7VmwS8K5RRaSu0uaT3QC0LYB oKmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773758431; x=1774363231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6oGuZGWOJwSB6f8V0h3mJxMfgC0ILfRIiCjXkY39JNU=; b=pDd1OxG43L4TlrNeccQwgOT35i/0C6lEk60ghPLAO7sQXPCg5ErqAsAaxTOJPzsjdG F8TO/3GoT1a4cr0bw7Te2/H8401CXNOiCyxu8KxpxHnOEGq6CJblDyj2lGWZHGo8YMKc 0tnNHr7dhUmYv4DNQpwnSWyCpPOLKqGTAARZ1H31MGhqU0QRs1mCnjpnuGrnWMSrquPn o81r1aejOlPM93P7+b1zaa8h24E8A0plI2A06/VBM71OUeW52LmFhZSjw+TqDQkaQWJr 2i8YcrXuesfEtPrYVcK8DTECspTUS0FNH9N08hGmzNUU2F/JLXlO5ObngqObbf9q+3fR Z6AA== X-Forwarded-Encrypted: i=1; AJvYcCW7t3ld+fUNboJAlDBpqEjOeC2TfDxkcYe2kdrQ76kCsu2FAqHvNCcNmPA+C349XekWP9YuWf1k5ExiLxA=@vger.kernel.org X-Gm-Message-State: AOJu0YxHGaMDzTZh+8DHgaRTH/DvCaNPO+kg5UNaMbATswM0gqRiebZd 1ep+vBzPQibwLRqQ2JOJ+6wnpqIzEDRF+Vtq+rQqQYbUd3YGZekuowgLIQpVaZYG4FA= X-Gm-Gg: ATEYQzxyYe+KTEqikCb5ZCl3A17aX69iqr7/naBlVhptESXAz7faYOLDaFcBG9pwYwk GrK29kcGDyKXHOkg91WM6lrl//StTbKNBOUOybLwwdjCJPzSh50dBPdgPWZK+uFJiBDPYY7JpJ6 QtGzK/zqMJHCsckTqw0deSSC38KgqnuZQZyivJR8e2OoI+JjsHA6cf5+oqyKOycY7co0+p/rx5s 2kiBG2Q13J+hNjr/wOr2pjLuQ894jgnyIocMxF4naHw6CIJmcBnaX4RAyBJ2Y3SaJskWd3Kh1Ex +VJ4KmvDgbSGo92M+/5qGYteQ5kWqHQCYalzE9ZSGhWjYEKshMXJodzTK6lodCyi8yI20fupCTp 10xcIZtI2XIR8NnaIqZmQ29h84ovo5fgeID6lA5W9NuNw8uEPMJnlIdoQzzifApYwTmnYXmZCy1 nge6ajfjaOKYM58k/T4AkCog9P25xz X-Received: by 2002:a17:906:dc94:b0:b97:860c:de51 with SMTP id a640c23a62f3a-b97860ce73amr764078966b.43.1773758430465; Tue, 17 Mar 2026 07:40:30 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cf380f2sm755154766b.53.2026.03.17.07.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 07:40:30 -0700 (PDT) Date: Tue, 17 Mar 2026 17:40:27 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v4 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Message-ID: <940ff48bd53e35e19a4cda081170d9198c20675e.1773757772.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_LEVEL parameter represents the value of the pin, whether reading or writing to the pin. In SCMI, the parameter is represented by two different values SCMI_PIN_OUTPUT_VALUE for writing to a pin and SCMI_PIN_INPUT_VALUE for reading. The current code translates PIN_CONFIG_LEVEL as SCMI_PIN_OUTPUT_VALUE (writing). Add a function to translate it to either INPUT or OUTPUT depending on whether it is called from a _get or _set() operation. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Acked-by: Sudeep Holla --- drivers/pinctrl/pinctrl-scmi.c | 33 ++++++++++++++++++++++++++------- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index f4f296e07be5..5d347e6b2e4c 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -251,9 +251,6 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_confi= g_param param, case PIN_CONFIG_MODE_LOW_POWER: *type =3D SCMI_PIN_LOW_POWER_MODE; break; - case PIN_CONFIG_LEVEL: - *type =3D SCMI_PIN_OUTPUT_VALUE; - break; case PIN_CONFIG_OUTPUT_ENABLE: *type =3D SCMI_PIN_OUTPUT_MODE; break; @@ -276,6 +273,28 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_conf= ig_param param, return 0; } =20 +static int pinctrl_scmi_map_pinconf_type_get(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_INPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + +static int pinctrl_scmi_map_pinconf_type_set(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + if (param =3D=3D PIN_CONFIG_LEVEL) { + *type =3D SCMI_PIN_OUTPUT_VALUE; + return 0; + } + + return pinctrl_scmi_map_pinconf_type(param, type); +} + static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin, unsigned long *config) { @@ -290,7 +309,7 @@ static int pinctrl_scmi_pinconf_get(struct pinctrl_dev = *pctldev, =20 config_type =3D pinconf_to_config_param(*config); =20 - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) return ret; =20 @@ -363,7 +382,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -405,7 +424,7 @@ static int pinctrl_scmi_pinconf_group_set(struct pinctr= l_dev *pctldev, =20 for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; @@ -440,7 +459,7 @@ static int pinctrl_scmi_pinconf_group_get(struct pinctr= l_dev *pctldev, return -EINVAL; =20 config_type =3D pinconf_to_config_param(*config); - ret =3D pinctrl_scmi_map_pinconf_type(config_type, &type); + ret =3D pinctrl_scmi_map_pinconf_type_get(config_type, &type); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); return ret; --=20 2.51.0