From nobody Sat Feb 7 05:49:28 2026 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D7352D7D2E for ; Sat, 18 Oct 2025 13:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760792694; cv=none; b=geFUf2AVGtMNIcq5YUBFQ6uyC8tniyBECBW9YLb7P1OJ2HZZsxBRemcF6uGKiG2XeClUyxUFGDEWsq4JpLNLZSyYzy9O6cEMMHV1ZiDrdvb4uwry49h4grLxn30n0pGo1cj0bP2irLUBdhZ5ZTSU7tvPQ87sgRly9sEjGMnWufw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760792694; c=relaxed/simple; bh=/QKA0xRQrUJstKtOglqkTvta05yDY6MtV3GQJq3894Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UxlalK0KLRjun2kIstcjgc8L/jI2U9ztfjvovAutR1hlOuZLkdYxNQVEtZmXCTOUzxNDSsV9J+efOFTdMXNUL62kOlUJNe6BaoQVQyt+ddFSXeK/PqMJUewfl/4hDL3ss4UZ7/5FUOdLExlNLD1PGmMQk/iMTZxIFtDNoYoQj9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PKBe9OAt; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PKBe9OAt" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-87c1a760df5so55537996d6.1 for ; Sat, 18 Oct 2025 06:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760792691; x=1761397491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qWnt+sjZ8ZgsaI+sAzX/D1lkWlG+AQb06P47+lpZEQg=; b=PKBe9OAtNm2mYV7LBc/I1P+3WdYFxg32SnRmqXzmR0AC6IhklsxEs7827chNf1tcmu 7buyvT30Mb4C8cHXMTwRPT16ZhLUZNXwtZeABLYMWojXrECnFVtdLiP52bzk9a8s5RV4 Gxer1r4m/OGFS1yLYmoL2Tq6q9hP90PyMCweaJQXPSkFGqrxRexa/SPlv07IhaY9Ym1j u0ZHl73Jw5vJfsdwDmyycLtyN3Lhg8HQaecqgEokKffpWKdjgSAc8xh2mWyYp38hsnk7 QJlok8rWmf93BTqSlYQ0A6j7S7bl21MoWrWSkW5rOMQtRNHhGK08pRtA4A7qdiS+uiJj p+qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760792691; x=1761397491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qWnt+sjZ8ZgsaI+sAzX/D1lkWlG+AQb06P47+lpZEQg=; b=AQTC7tx2UBHZ/fAlnsEIjvTMu+TiJNx99oY4StnHUs1AZy6QUi79vW4JInmg78cUj5 +EGWJv40yIQc1d2IEdVwv8cq9dU9H5UKh8K1Ywhx3eEap4jJucobr2Rb35OfZkNlZssB JEDWkO+DJi9oUWLX/AGS3wUwfJHqo66watFpbmSR8IRuv0FoPfMAK9cNWza8UOrYWjif 5Px6mh1YCL+r4N9Odzuv3R/bLIiPFMoSRFvte7usQDLZR09vRWshHvJO+zh7NG2qKgE+ 3NJ49xOKn4d2OdCzgCd3Z6I3508zuRXz+Yabxeue91gvDhhheLEdrhufy+NdYF90PhjP PQYA== X-Forwarded-Encrypted: i=1; AJvYcCX9FnRgtsfR4H2T7+ey6sGfTKcQQ1d0tkF0g0Kfj7zZBX4PtEglHKVsXcnaQth6YRnjTnfNfy5E/QM7VDM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyun4SqF2m5DkX55LWDZ+JAAiWQridn/w0fINJ+e96ULFeO3os/ Q9VIr/tZ8pBj+VrPuEz+4qtuu86vO0i+h6vOzscKXhY1i97nSRXYyrjc X-Gm-Gg: ASbGncvJeF2lcFx2ziFVLyql23OPXHOErlKJrrdXb0ctDY+R0nZTsNs45pPEywSHuKj 5SoOWXBGxqO+T0Er1RiSMrkxerwUDXmebswx5VeR7wxYAmTDBha2KLmQ3N54qY8y2uk6PtQABgq bTXzgtWMBv2e1DydyVcV8s0qs88MlQyjGf1o38XTcTHzDmJs8csmlXwtByU2gKHMaLBREKLu8go gPCs0k51ZXc8igGHqHmKgy3SqMJ4Anty7zHCxk1c6z3L7KkkstIW+YshwJSrxoXfUO7VG5JiDga hy9IjnuRExRfLZcTttFv7B+UYLaonD2TL7O94V3BpkaGNqE8kipSv4Hw1wesTjImINc/0KQ3Xy8 lXe03DeWqDUs/LDXaoOJkb4oqHLDZmWrsb3P0E6pWP+oy4YgfCWdFGMYajQp4LkeLnUtcWDNfxu hoTlkPhTrqLvZUd0A6vDsdGthtJ1O8Pupd13tD X-Google-Smtp-Source: AGHT+IHmRouhpzmNuhXsb90wciLNRo+Xh2dXpLMyR7s2zHZrsvFLahcyOci9MsF3wzHDrdrwup9N5g== X-Received: by 2002:a05:6214:1948:b0:87c:dff0:7c0a with SMTP id 6a1803df08f44-87cdff07d94mr54571536d6.55.1760792691024; Sat, 18 Oct 2025 06:04:51 -0700 (PDT) Received: from ideapad.mynetworksettings.com ([2600:4040:5304:d300:275f:6229:da5:6a60]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-87d028966fasm15840596d6.33.2025.10.18.06.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 06:04:50 -0700 (PDT) From: Ivan Pravdin To: rostedt@goodmis.org, tglozar@redhat.com, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ivan Pravdin Subject: [PATCH v4 2/2] rtla: fix -a overriding -t argument Date: Sat, 18 Oct 2025 09:04:31 -0400 Message-ID: <93cf8411e8c23ebdcf2e168f0f7d3e8c9081900b.1760791697.git.ipravdin.official@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When running rtla as `rtla -t custom_file.txt -a 100` -a options override trace output filename specified by -t option. Running the command above will create _trace.txt file instead of custom_file.txt. Fix this by making sure that -a option does not override trace output filename even if it's passed after trace output filename is specified. Fixes: 173a3b014827 ("rtla/timerlat: Add the automatic trace option") Signed-off-by: Ivan Pravdin Reviewed-by: Tomas Glozar --- tools/tracing/rtla/src/osnoise_hist.c | 3 ++- tools/tracing/rtla/src/osnoise_top.c | 2 ++ tools/tracing/rtla/src/timerlat_hist.c | 3 ++- tools/tracing/rtla/src/timerlat_top.c | 3 ++- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/tools/tracing/rtla/src/osnoise_hist.c b/tools/tracing/rtla/src= /osnoise_hist.c index 8b12d8803998..ae8426f40f8f 100644 --- a/tools/tracing/rtla/src/osnoise_hist.c +++ b/tools/tracing/rtla/src/osnoise_hist.c @@ -557,7 +557,8 @@ static struct common_params params->threshold =3D 1; =20 /* set trace */ - trace_output =3D "osnoise_trace.txt"; + if (!trace_output) + trace_output =3D "osnoise_trace.txt"; =20 break; case 'b': diff --git a/tools/tracing/rtla/src/osnoise_top.c b/tools/tracing/rtla/src/= osnoise_top.c index 0be400666c05..9487c6a592c2 100644 --- a/tools/tracing/rtla/src/osnoise_top.c +++ b/tools/tracing/rtla/src/osnoise_top.c @@ -398,6 +398,8 @@ struct common_params *osnoise_top_parse_args(int argc, = char **argv) =20 /* set trace */ trace_output =3D "osnoise_trace.txt"; + if (!trace_output) + trace_output =3D "osnoise_trace.txt"; =20 break; case 'c': diff --git a/tools/tracing/rtla/src/timerlat_hist.c b/tools/tracing/rtla/sr= c/timerlat_hist.c index 16416192e432..311c4f18ce4c 100644 --- a/tools/tracing/rtla/src/timerlat_hist.c +++ b/tools/tracing/rtla/src/timerlat_hist.c @@ -878,7 +878,8 @@ static struct common_params params->print_stack =3D auto_thresh; =20 /* set trace */ - trace_output =3D "timerlat_trace.txt"; + if (!trace_output) + trace_output =3D "timerlat_trace.txt"; =20 break; case 'c': diff --git a/tools/tracing/rtla/src/timerlat_top.c b/tools/tracing/rtla/src= /timerlat_top.c index fe4f4e69e00f..3a3b11b5beaa 100644 --- a/tools/tracing/rtla/src/timerlat_top.c +++ b/tools/tracing/rtla/src/timerlat_top.c @@ -628,7 +628,8 @@ static struct common_params params->print_stack =3D auto_thresh; =20 /* set trace */ - trace_output =3D "timerlat_trace.txt"; + if (!trace_output) + trace_output =3D "timerlat_trace.txt"; =20 break; case '5': --=20 2.48.1