From nobody Sat Feb 7 20:57:58 2026 Received: from mx1.emlix.com (mx1.emlix.com [178.63.209.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2F721766A for ; Thu, 19 Dec 2024 10:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.63.209.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734603534; cv=none; b=G6DNRU1w1tRcmLjiDuHiDb6tOS4dSZ2Pl3p+1rTryLcq23seUUP/I0zSnPrkKlHDjpCH3/24RACB8UDi8KS/31IStNEy6a/+MEQvGe3lUotg3sCuQroVzP0yb+NPY2gP5r0miRmDSj+n3oZjHXB8KAmvl9C1Mo5T+8C2EVP7h+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734603534; c=relaxed/simple; bh=fs1o12AyalobbDvWNWIqM+r1tZBiE9KUDW9D7lGlW7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B91qvDw0jhSQK1X6WVn0nwvG42hbHIpPoFRV+xQvGLR1Hqcfe24yv0ETNQNZaR4QBd04WIjDymKMDX/wxN6gX9VAkfBI4Arhi/K6438n54soJhfYIb7S2X493Jh13xc2Lc00zx8Rmq75x6GYr9O63+gRccgo0Q9BcbTyZQWCoWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=emlix.com; spf=pass smtp.mailfrom=emlix.com; arc=none smtp.client-ip=178.63.209.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=emlix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=emlix.com Received: from mailer.emlix.com (p5098be52.dip0.t-ipconnect.de [80.152.190.82]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id B17CC5F8DD; Thu, 19 Dec 2024 11:18:36 +0100 (CET) From: Rolf Eike Beer To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/i915/selftests: check the return value of i915_gem_object_trylock() Date: Thu, 19 Dec 2024 11:16:51 +0100 Message-ID: <9379466.CDJkKcVGEf@devpool47.emlix.com> Organization: emlix GmbH In-Reply-To: <7746997.EvYhyI6sBW@devpool47.emlix.com> References: <7746997.EvYhyI6sBW@devpool47.emlix.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A trylock can fail, in which case operating on the object is unsafe and unconditionally unlocking is wrong. Signed-off-by: Rolf Eike Beer --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i= 915/gt/selftest_migrate.c index ca460cee4f8b..b2cb501febe8 100644 --- a/drivers/gpu/drm/i915/gt/selftest_migrate.c +++ b/drivers/gpu/drm/i915/gt/selftest_migrate.c @@ -822,7 +822,10 @@ create_init_lmem_internal(struct intel_gt *gt, size_t = sz, bool try_lmem) return obj; } =20 - i915_gem_object_trylock(obj, NULL); + if (!i915_gem_object_trylock(obj, NULL)) { + i915_gem_object_put(obj); + return ERR_PTR(-EBUSY); + } err =3D i915_gem_object_pin_pages(obj); if (err) { i915_gem_object_unlock(obj); --=20 2.47.1 --=20 Rolf Eike Beer emlix GmbH Headquarters: Berliner Str. 12, 37073 G=C3=B6ttingen, Germany Phone +49 (0)551 30664-0, e-mail info@emlix.com District Court of G=C3=B6ttingen, Registry Number HR B 3160 Managing Directors: Heike Jordan, Dr. Uwe Kracke VAT ID No. DE 205 198 055 Office Berlin: Panoramastr. 1, 10178 Berlin, Germany Office Bonn: Bachstr. 6, 53115 Bonn, Germany http://www.emlix.com emlix - your embedded Linux partner