From nobody Tue Jun 23 21:33:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC034C433F5 for ; Fri, 25 Feb 2022 13:15:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236407AbiBYNQ0 (ORCPT ); Fri, 25 Feb 2022 08:16:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231822AbiBYNQW (ORCPT ); Fri, 25 Feb 2022 08:16:22 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A30D181E57; Fri, 25 Feb 2022 05:15:50 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 890461F45EAA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645794948; bh=iANknHWAfv72XgX0hMtZ0uWhgfV7gO/pAWFzD/WhLYU=; h=From:To:Cc:Subject:Date:From; b=GsuTzxt3Rh3nRwaeDhRoTiUXBrE2X/C21+/Ig6m3l95ExxJ1r2LtLMaw+NBw/S0Vz qFcRQH9PtPo53Xi0OfZsJSlSLllgKpu1s4bMEK10MJr0NG/MFvp555CgFgdjyZZoXt djHBTh1aKRmco39uOL2eTOpY79T7X7x3S9qBw97rUuNnl4M33FzYJ1vZv1qvw8fNVw DbbjJVcH8iGjYn8QldDoATvRMdiiXxuzc2dm5sFW9nzU0qN3LMkEGie+xQAkslxhmK DCD/3GHdIhlwCNPPJbO88Q5FJWI4RvfTkVyMJvjDx3BBd54czneO147vWq4S5wbjUH GBuAUgqsR53OQ== From: Guillaume Tucker To: Shuah Khan , Andrew Morton Cc: Borislav Petkov , Dave Hansen , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests, x86: fix how check_cc.sh is being invoked Date: Fri, 25 Feb 2022 13:15:43 +0000 Message-Id: <9320d88a3a65350d9bfdc5e258742cd0b162f017.1645794882.git.guillaume.tucker@collabora.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add quotes around $(CC) when calling check_cc.sh from a Makefile to pass the value as a single argument to the script even if it has several words such as "ccache gcc". Conversely, remove quotes in check_cc.sh when calling $CC to make it a command with potentially several arguments again. Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detect= ion") Tested-by: "kernelci.org bot" Signed-off-by: Guillaume Tucker --- tools/testing/selftests/vm/Makefile | 6 +++--- tools/testing/selftests/x86/Makefile | 6 +++--- tools/testing/selftests/x86/check_cc.sh | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/= vm/Makefile index 1607322a112c..d934f026ebb5 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -49,9 +49,9 @@ TEST_GEN_FILES +=3D split_huge_page_test TEST_GEN_FILES +=3D ksm_tests =20 ifeq ($(MACHINE),x86_64) -CAN_BUILD_I386 :=3D $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bi= t_program.c -m32) -CAN_BUILD_X86_64 :=3D $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64= bit_program.c) -CAN_BUILD_WITH_NOPIE :=3D $(shell ./../x86/check_cc.sh $(CC) ../x86/trivia= l_program.c -no-pie) +CAN_BUILD_I386 :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_32= bit_program.c -m32) +CAN_BUILD_X86_64 :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_= 64bit_program.c) +CAN_BUILD_WITH_NOPIE :=3D $(shell ./../x86/check_cc.sh "$(CC)" ../x86/triv= ial_program.c -no-pie) =20 TARGETS :=3D protection_keys BINARIES_32 :=3D $(TARGETS:%=3D%_32) diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests= /x86/Makefile index 8a1f62ab3c8e..53df7d3893d3 100644 --- a/tools/testing/selftests/x86/Makefile +++ b/tools/testing/selftests/x86/Makefile @@ -6,9 +6,9 @@ include ../lib.mk .PHONY: all all_32 all_64 warn_32bit_failure clean =20 UNAME_M :=3D $(shell uname -m) -CAN_BUILD_I386 :=3D $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m= 32) -CAN_BUILD_X86_64 :=3D $(shell ./check_cc.sh $(CC) trivial_64bit_program.c) -CAN_BUILD_WITH_NOPIE :=3D $(shell ./check_cc.sh $(CC) trivial_program.c -n= o-pie) +CAN_BUILD_I386 :=3D $(shell ./check_cc.sh "$(CC)" trivial_32bit_program.c = -m32) +CAN_BUILD_X86_64 :=3D $(shell ./check_cc.sh "$(CC)" trivial_64bit_program.= c) +CAN_BUILD_WITH_NOPIE :=3D $(shell ./check_cc.sh "$(CC)" trivial_program.c = -no-pie) =20 TARGETS_C_BOTHBITS :=3D single_step_syscall sysret_ss_attrs syscall_nt tes= t_mremap_vdso \ check_initial_reg_state sigreturn iopl ioperm \ diff --git a/tools/testing/selftests/x86/check_cc.sh b/tools/testing/selfte= sts/x86/check_cc.sh index 3e2089c8cf54..aff2c15018b5 100755 --- a/tools/testing/selftests/x86/check_cc.sh +++ b/tools/testing/selftests/x86/check_cc.sh @@ -7,7 +7,7 @@ CC=3D"$1" TESTPROG=3D"$2" shift 2 =20 -if "$CC" -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then +if $CC -o /dev/null "$TESTPROG" -O0 "$@" 2>/dev/null; then echo 1 else echo 0 --=20 2.30.2