From nobody Sun Feb 8 10:04:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26033C001B0 for ; Sat, 8 Jul 2023 01:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232409AbjGHB4l (ORCPT ); Fri, 7 Jul 2023 21:56:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbjGHB4j (ORCPT ); Fri, 7 Jul 2023 21:56:39 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BDDCC3; Fri, 7 Jul 2023 18:56:37 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R791e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=ydzhang@linux.alibaba.com;NM=1;PH=DW;RN=7;SR=0;TI=W4_0.2.0_DEFAULT_210DF632_1688781163176_o7001c63l; Received: from WS-web (ydzhang@linux.alibaba.com[W4_0.2.0_DEFAULT_210DF632_1688781163176_o7001c63l]) at Sat, 08 Jul 2023 09:56:34 +0800 Date: Sat, 08 Jul 2023 09:56:34 +0800 From: "wardenjohn" To: "jpoimboe" Cc: "jikos" , "mbenes" , "pmladek" , "joe.lawrence" , "live-patching" , "linux-kernel" Reply-To: "wardenjohn" Message-ID: <931aaecf-66b1-469a-8bc3-7126871a8464.ydzhang@linux.alibaba.com> Subject: =?UTF-8?B?Rml4IE1BWF9TVEFDS19FTlRSSUVTIGZyb20gMTAwIHRvIDMy?= X-Mailer: [Alimail-Mailagent revision 85][W4_0.2.0][DEFAULT][Chrome] MIME-Version: 1.0 x-aliyun-mail-creator: W4_0.2.0_DEFAULT_QvNTW96aWxsYS81LjAgKE1hY2ludG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTVfNykgQXBwbGVXZWJLaXQvNTM3LjM2IChLSFRNTCwgbGlrZSBHZWNrbykgQ2hyb21lLzExNC4wLjAuMCBTYWZhcmkvNTM3LjM2La Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Thanks for reading my suggestion. I found that the array for task stack ent= ries when doing livepatch function check is too large which seems to be unnecessary. = Therefore, I suggest to fix the MAX_STACK_ENTRIES from 100 to 32. The patch is as follows: From ee27da5e64daced159257f54170a31141e943710 Mon Sep 17 00:00:00 2001 From: Yongde Zhang Date: Sat, 8 Jul 2023 09:40:50 +0800 Subject: [PATCH] Fix MAX_STACK_ENTRIES to 32 When checking the task stack, using an stack array of size 100=20 seems to be to large for a task stack. Therefore, I suggest to change the stack size from 100 to 32.=20 Signed-off-by: Yongde Zhang --- kernel/livepatch/transition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c index e54c3d60a904..8d61c62b0c27 100644 --- a/kernel/livepatch/transition.c +++ b/kernel/livepatch/transition.c @@ -14,7 +14,7 @@ #include "patch.h" #include "transition.h" =20 -#define MAX_STACK_ENTRIES 100 +#define MAX_STACK_ENTRIES 32 static DEFINE_PER_CPU(unsigned long[MAX_STACK_ENTRIES], klp_stack_entries); =20 #define STACK_ERR_BUF_SIZE 128=20 --=20 2.37.3