From nobody Thu Dec 18 13:14:10 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77594C3DA6F for ; Fri, 25 Aug 2023 12:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244667AbjHYMQu (ORCPT ); Fri, 25 Aug 2023 08:16:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244639AbjHYMQT (ORCPT ); Fri, 25 Aug 2023 08:16:19 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B94A1FFD; Fri, 25 Aug 2023 05:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692965777; x=1724501777; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Zvdo0UAMyTzOZTIXhzmYqd4wFSgsgnHe6k3UBUuh1d8=; b=bu1Pl3FsqQ3gqx1GiX27ckxW/+fvZayebxHuJr8ulCLRuRYN/Hg3Qry7 BYkXBnM9DKpZYl3xhdH/Cu3Z5Rgn/QZu97YpHOcg5RtX/tFTmegOu8Lgv HkR/ZERHzrkmIPolGJ2Z+64mFDG4ocVLGxAI+fRDcBMu9zZSJQVofBs3J 5JPvy6H7IldS/h0YR3ha/N2RyOdNeqQY8xLmhylgqKLAHE0BkxDCLjDl/ 1lAfzBfA7gpOql3gHR6YWfpDoZ0/ljFXA1dBu27Do5BBq1u+bu/9NkH7p Yz4O7RuccnJ8zmXpjEC2aKFupuKBPpRy5osZj6gGIsmfs7l8KFm7jUtWq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="438639387" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="438639387" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 05:16:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.01,202,1684825200"; d="scan'208";a="881158564" Received: from vnaikawa-mobl1.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.209.185.177]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 05:16:15 -0700 From: Kai Huang To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: x86@kernel.org, dave.hansen@intel.com, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, bp@alien8.de, mingo@redhat.com, hpa@zytor.com, seanjc@google.com, pbonzini@redhat.com, david@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ashok.raj@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, nik.borisov@suse.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com, kai.huang@intel.com Subject: [PATCH v13 14/22] x86/virt/tdx: Configure TDX module with the TDMRs and global KeyID Date: Sat, 26 Aug 2023 00:14:33 +1200 Message-ID: <92d85cd10e1c6c50dd62a130f03ed138094e9b14.1692962263.git.kai.huang@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The TDX module uses a private KeyID as the "global KeyID" for mapping things like the PAMT and other TDX metadata. This KeyID has already been reserved when detecting TDX during the kernel early boot. After the list of "TD Memory Regions" (TDMRs) has been constructed to cover all TDX-usable memory regions, the next step is to pass them to the TDX module together with the global KeyID. Signed-off-by: Kai Huang Reviewed-by: Isaku Yamahata Reviewed-by: Kirill A. Shutemov Reviewed-by: Yuan Yao --- v12 -> v13: - Added Yuan's tag. v11 -> v12: - Added Kirill's tag v10 -> v11: - No update v9 -> v10: - Code change due to change static 'tdx_tdmr_list' to local 'tdmr_list'. v8 -> v9: - Improved changlog to explain why initializing TDMRs can take long time (Dave). - Improved comments around 'next-to-initialize' address (Dave). v7 -> v8: (Dave) - Changelog: - explicitly call out this is the last step of TDX module initialization. - Trimed down changelog by removing SEAMCALL name and details. - Removed/trimmed down unnecessary comments. - Other changes due to 'struct tdmr_info_list'. v6 -> v7: - Removed need_resched() check. -- Andi. --- arch/x86/virt/vmx/tdx/tdx.c | 43 ++++++++++++++++++++++++++++++++++++- arch/x86/virt/vmx/tdx/tdx.h | 2 ++ 2 files changed, 44 insertions(+), 1 deletion(-) diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index 9173d9798231..d059226e8829 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -900,6 +901,41 @@ static int construct_tdmrs(struct list_head *tmb_list, return ret; } =20 +static int config_tdx_module(struct tdmr_info_list *tdmr_list, u64 global_= keyid) +{ + struct tdx_module_args args =3D {}; + u64 *tdmr_pa_array; + size_t array_sz; + int i, ret; + + /* + * TDMRs are passed to the TDX module via an array of physical + * addresses of each TDMR. The array itself also has certain + * alignment requirement. + */ + array_sz =3D tdmr_list->nr_consumed_tdmrs * sizeof(u64); + array_sz =3D roundup_pow_of_two(array_sz); + if (array_sz < TDMR_INFO_PA_ARRAY_ALIGNMENT) + array_sz =3D TDMR_INFO_PA_ARRAY_ALIGNMENT; + + tdmr_pa_array =3D kzalloc(array_sz, GFP_KERNEL); + if (!tdmr_pa_array) + return -ENOMEM; + + for (i =3D 0; i < tdmr_list->nr_consumed_tdmrs; i++) + tdmr_pa_array[i] =3D __pa(tdmr_entry(tdmr_list, i)); + + args.rcx =3D __pa(tdmr_pa_array); + args.rdx =3D tdmr_list->nr_consumed_tdmrs; + args.r8 =3D global_keyid; + ret =3D seamcall_prerr(TDH_SYS_CONFIG, &args); + + /* Free the array as it is not required anymore. */ + kfree(tdmr_pa_array); + + return ret; +} + static int init_tdx_module(void) { struct tdsysinfo_struct *tdsysinfo; @@ -955,16 +991,21 @@ static int init_tdx_module(void) if (ret) goto out_free_tdmrs; =20 + /* Pass the TDMRs and the global KeyID to the TDX module */ + ret =3D config_tdx_module(&tdmr_list, tdx_global_keyid); + if (ret) + goto out_free_pamts; + /* * TODO: * - * - Configure the TDMRs and the global KeyID to the TDX module. * - Configure the global KeyID on all packages. * - Initialize all TDMRs. * * Return error before all steps are done. */ ret =3D -EINVAL; +out_free_pamts: if (ret) tdmrs_free_pamt_all(&tdmr_list); else diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h index 6987af46d096..b8c9e3d016f9 100644 --- a/arch/x86/virt/vmx/tdx/tdx.h +++ b/arch/x86/virt/vmx/tdx/tdx.h @@ -19,6 +19,7 @@ #define TDH_SYS_INFO 32 #define TDH_SYS_INIT 33 #define TDH_SYS_LP_INIT 35 +#define TDH_SYS_CONFIG 45 =20 struct cmr_info { u64 base; @@ -85,6 +86,7 @@ struct tdmr_reserved_area { } __packed; =20 #define TDMR_INFO_ALIGNMENT 512 +#define TDMR_INFO_PA_ARRAY_ALIGNMENT 512 =20 struct tdmr_info { u64 base; --=20 2.41.0