From nobody Sun Feb 8 15:46:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20346C7EE23 for ; Thu, 1 Jun 2023 11:59:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233111AbjFAL7s (ORCPT ); Thu, 1 Jun 2023 07:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233068AbjFAL7q (ORCPT ); Thu, 1 Jun 2023 07:59:46 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9A1EB134 for ; Thu, 1 Jun 2023 04:59:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C42BA175D; Thu, 1 Jun 2023 05:00:28 -0700 (PDT) Received: from e121345-lin.cambridge.arm.com (e121345-lin.cambridge.arm.com [10.1.196.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 104833F7D8; Thu, 1 Jun 2023 04:59:41 -0700 (PDT) From: Robin Murphy To: will@kernel.org Cc: mark.rutland@arm.com, suzuki.poulose@arm.com, bwicaksono@nvidia.com, ilkka@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla Subject: [PATCH 2/4] ACPI/APMT: Don't register invalid resource Date: Thu, 1 Jun 2023 12:59:30 +0100 Message-Id: <91c8787f1e84d79e110a057615c838f6ac244669.1685619571.git.robin.murphy@arm.com> X-Mailer: git-send-email 2.39.2.101.g768bb238c484.dirty In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Don't register a resource for the second page unless the dual-page extension flag is actually present to say it's valid. CC: Lorenzo Pieralisi CC: Hanjun Guo CC: Sudeep Holla Signed-off-by: Robin Murphy Reviewed-by: Hanjun Guo Reviewed-by: Suzuki K Poulose --- Not a critical fix, since the driver currently works around this itself, but patch #4 would like to clean that up. drivers/acpi/arm64/apmt.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c index 8cab69fa5d59..aa7d5c3c0dd8 100644 --- a/drivers/acpi/arm64/apmt.c +++ b/drivers/acpi/arm64/apmt.c @@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *= res, =20 num_res++; =20 - res[num_res].start =3D node->base_address1; - res[num_res].end =3D node->base_address1 + SZ_4K - 1; - res[num_res].flags =3D IORESOURCE_MEM; + if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) { + res[num_res].start =3D node->base_address1; + res[num_res].end =3D node->base_address1 + SZ_4K - 1; + res[num_res].flags =3D IORESOURCE_MEM; =20 - num_res++; + num_res++; + } =20 if (node->ovflw_irq !=3D 0) { trigger =3D (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE); --=20 2.39.2.101.g768bb238c484.dirty