From nobody Wed Dec 17 02:56:53 2025 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DC9D15CD41 for ; Wed, 24 Jul 2024 16:09:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721837399; cv=none; b=QueSLOx8jW/ae1fHZ4UI7hERbr7U1d/WL45Z5KsA+no/Nw6sNDmMlxpW1JOotyIMMqI7axrkKR3hdd6SrCUrd1BJDz+B6XD2E65Ki5Uc80s+nf9usMf2lKH8kIEQOf6wXNhfyWehn8glfESPydTJEIF7m5bzarF0Tyo/scqqLIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721837399; c=relaxed/simple; bh=0Yb568f1XdkBjyBiCIrW28MFVKJ0UvlZ6ZIGIqUjI78=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=EkjYc+DW7SnT+OBtyidbX+4qfG9Da9JVahWZlvY0axPCTeQT754bvL9lqEzvjnHu4CUgR4xBUC6B4SMM8P/gE1F6CWgllZsGHDmTpvlT+TW0nu2fgsGQHBQD2lwq+yM2/vHOn0lxQGXY51fZIj7VNGi7CRNIBdab2iQx7fAn7I0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y8FFTEq6; arc=none smtp.client-ip=209.85.160.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y8FFTEq6" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-260e5b2dfb5so3936558fac.3 for ; Wed, 24 Jul 2024 09:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1721837397; x=1722442197; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=O2jZhMoing7DWC/lOhFYXVidQ2q+B0OoDl/QuVCkLmg=; b=y8FFTEq6afb+ua2bcsCFIJmN1KVKOWZAe6UQ/ZSR3ooWEnw2s1jtuZbe5Xg/ZlvI6c iGJEx/ZRZKIK5yVPYRBUm9k8T3JYggRNv1Q1lZHeauF6IJoY5fXiYjAyO76dVpD/Dz5u sxLcG6q3NoYlUm4vJoGvjYOcGnMak68t995K3jbSENjqxMWHGEUIk+oacnokFe3Eve/9 QG+B5tP/0dYIgxn/j+jYB+p16AOxwk1Hnmyzx553csvAOV22BXSBsBTxpIDtpWFCDcWR yR5+XrJ/QX7PMj+cXnB5Tfoe+nABlkmNSO8p30k/xMMQsenQDe5h8jN8CICendPcHjHP Nwxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721837397; x=1722442197; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O2jZhMoing7DWC/lOhFYXVidQ2q+B0OoDl/QuVCkLmg=; b=ZoFAtj5VObKdmkTkpoSFJvTPsnnK+kzLIBlrhcoE2GQTdiszFaUiVR+jW6oC6ww5Uo d9Iu/6NEf0jAR1bq50JZk+aFDH6SAhiWy9jG/eDYhGyl4EfexdLvDZcPDWQDcEaad0OH oC66289FS5acMmUCcIWESyRmMd69NWspkn7J+PF5/hBe5cKKiYNNRiXrKXCoJINoY2FD TlmOsomrQgD0c/W9TItGycQ/o9xUIOhmdRj52yCvSvBMhUNig3UYoNw+Hxfq5IwQfGLg K8yX1FkOma0zFwMtblZevxjf7N7GvGEVY6ndsvwBZWv5/akJ4AplkKvYszEXo2Lkrz4U ImkA== X-Forwarded-Encrypted: i=1; AJvYcCWjDd9WCuBUJscGKpQJmHaaJZeXvIG96rrANPuu6YaZOAn4O1EFBwOtO6yWRd+DaTiohHJCoGyynCRyfq9FDC5uD/IWyW+u0C3GDCh9 X-Gm-Message-State: AOJu0YzVI+zzFlAMPhVM21u0LWOP+Fzvcd0ZxhKS8KtcsqGmtS9So0Ev CMXXhJLmjMPA2V/Z9pru6NsOKJ0eH5qnJT9cM73uosWb99xXEYmj1mYlaCBbON8= X-Google-Smtp-Source: AGHT+IHCvg+D37qFDPSAV2DjfuTODsZ2i9ctUl1JsN9tBVVXcEXaPTGM2Fzh7+EL/qLQElF4DzvcQw== X-Received: by 2002:a05:6870:c190:b0:260:fdda:5068 with SMTP id 586e51a60fabf-2648ca35f3emr2882513fac.4.1721837397103; Wed, 24 Jul 2024 09:09:57 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:23ae:46cb:84b6:1002]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3db0331a01bsm637378b6e.55.2024.07.24.09.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 09:09:56 -0700 (PDT) Date: Wed, 24 Jul 2024 11:09:54 -0500 From: Dan Carpenter To: Thomas Zimmermann Cc: Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , Zack Rusin , Christian =?iso-8859-1?Q?K=F6nig?= , Dmitry Osipenko , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local() Message-ID: <89d13df3-747c-4c5d-b122-d081aef5110a@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This function accidentally returns zero/success on the failure path. It leads to locking issues and an uninitialized *map_copy in the caller. Fixes: b4b0193e83cb ("drm/fbdev-generic: Fix locking with drm_client_buffer= _vmap_local()") Signed-off-by: Dan Carpenter Reviewed-by: Dmitry Osipenko Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 2803ac111bbd..bfedcbf516db 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buff= er *buffer, =20 err_drm_gem_vmap_unlocked: drm_gem_unlock(gem); - return 0; + return ret; } EXPORT_SYMBOL(drm_client_buffer_vmap_local); =20 --=20 2.43.0