From nobody Tue Oct 7 19:53:38 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF0BC263F32 for ; Mon, 7 Jul 2025 18:51:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751914273; cv=none; b=WhDFr9RG9sm+YfHqzj+NVOtrb3v8GOftofg8FYya9BQ0bliDpVwCDkeiz3j4PC4XkTlv7WAgbDsPB9uIgIDB8XHoIOoZMnt5vRUTbT8ktbvR/jfrYleg/0KccRQKQMHmFHE+kBmlaCBi7ksX+a1KG2oaGsAPvlAZeRAFGFYdESM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751914273; c=relaxed/simple; bh=e7Ob1j5nNs4Mjt6CAllzqdsEtj1C5YLoOgEZzuKt9ic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oopCGGBC2tI6aiOSvw4US6XfdXjyVWwkTuvN/lXqVP2fLCk3jSWbtF2hfv/9pFaZBG3pDMo4t7Y0phWLCvwDznxw/QF+Ay7nbc0jEDQzG8J+X8guhmMgjYubpkc5sd4K8VEGyA/Jv6GxZGt9UIHoGpV9VTWJ7WC89Nbk5VRlqEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V9OzfS1L; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V9OzfS1L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751914270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VBV6EKgPVG18COxzAU7Q5x6IQNu6IJXp+IEOudQo7nI=; b=V9OzfS1LFDZzQAE2dpOFs0/PelsKpr1ajKdzA3uqJ/0Glc+AbtCctZiSm6gZtm/9RGEoSS qgpW9ttNQJTeXkCmYkcUxjIne/nBC2alb7//CzuBjBmQExbRI1h8kFZs/73pKFBhSy3x+N zsLP9hZ1x89ekVpp+pywb/3m6vDh2XQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-0Y-PJ3nsNjKuMpUol191nw-1; Mon, 07 Jul 2025 14:51:07 -0400 X-MC-Unique: 0Y-PJ3nsNjKuMpUol191nw-1 X-Mimecast-MFC-AGG-ID: 0Y-PJ3nsNjKuMpUol191nw_1751914266 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5D27419560AE; Mon, 7 Jul 2025 18:51:06 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.80.96]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E3B3219560B2; Mon, 7 Jul 2025 18:51:04 +0000 (UTC) From: Luiz Capitulino To: david@redhat.com, willy@infradead.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org Subject: [PATCH v2 2/4] mm/util: introduce snapshot_page() Date: Mon, 7 Jul 2025 14:50:44 -0400 Message-ID: <88d956248f7528b7998ef00ca8742061839d1036.1751914235.git.luizcap@redhat.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" This commit refactors __dump_page() into snapshot_page(). snapshot_page() tries to take a faithful snapshot of a page and its folio representation. The snapshot is returned in the struct page_snapshot parameter along with additional flags that are best retrieved at snapshot creation time to reduce race windows. This function is intended to be used by callers that need a stable representation of a struct page and struct folio so that pointers or page information doesn't change while working on a page. The idea and original implementation of snapshot_page() comes from Matthew Wilcox with suggestions for improvements from David Hildenbrand. All bugs and misconceptions are mine. Signed-off-by: Luiz Capitulino --- include/linux/mm.h | 19 ++++++++++++ mm/debug.c | 42 +++---------------------- mm/util.c | 77 ++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+), 38 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 0ef2ba0c667a..090968c6eebb 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -4184,4 +4184,23 @@ static inline bool page_pool_page_is_pp(struct page = *page) } #endif =20 +#define PAGE_SNAPSHOT_FAITHFUL (1 << 0) +#define PAGE_SNAPSHOT_PG_FREE (1 << 1) +#define PAGE_SNAPSHOT_PG_IDLE (1 << 2) + +struct page_snapshot { + struct folio folio_snapshot; + struct page page_snapshot; + unsigned long pfn; + unsigned long idx; + unsigned long flags; +}; + +static inline bool snapshot_page_is_faithful(const struct page_snapshot *p= s) +{ + return ps->flags & PAGE_SNAPSHOT_FAITHFUL; +} + +void snapshot_page(struct page_snapshot *ps, const struct page *page); + #endif /* _LINUX_MM_H */ diff --git a/mm/debug.c b/mm/debug.c index 907382257062..7349330ea506 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -129,47 +129,13 @@ static void __dump_folio(struct folio *folio, struct = page *page, =20 static void __dump_page(const struct page *page) { - struct folio *foliop, folio; - struct page precise; - unsigned long head; - unsigned long pfn =3D page_to_pfn(page); - unsigned long idx, nr_pages =3D 1; - int loops =3D 5; - -again: - memcpy(&precise, page, sizeof(*page)); - head =3D precise.compound_head; - if ((head & 1) =3D=3D 0) { - foliop =3D (struct folio *)&precise; - idx =3D 0; - if (!folio_test_large(foliop)) - goto dump; - foliop =3D (struct folio *)page; - } else { - foliop =3D (struct folio *)(head - 1); - idx =3D folio_page_idx(foliop, page); - } + struct page_snapshot ps; =20 - if (idx < MAX_FOLIO_NR_PAGES) { - memcpy(&folio, foliop, 2 * sizeof(struct page)); - nr_pages =3D folio_nr_pages(&folio); - if (nr_pages > 1) - memcpy(&folio.__page_2, &foliop->__page_2, - sizeof(struct page)); - foliop =3D &folio; - } - - if (idx > nr_pages) { - if (loops-- > 0) - goto again; + snapshot_page(&ps, page); + if (!snapshot_page_is_faithful(&ps)) pr_warn("page does not match folio\n"); - precise.compound_head &=3D ~1UL; - foliop =3D (struct folio *)&precise; - idx =3D 0; - } =20 -dump: - __dump_folio(foliop, &precise, pfn, idx); + __dump_folio(&ps.folio_snapshot, &ps.page_snapshot, ps.pfn, ps.idx); } =20 void dump_page(const struct page *page, const char *reason) diff --git a/mm/util.c b/mm/util.c index 0b270c43d7d1..c38d213be83f 100644 --- a/mm/util.c +++ b/mm/util.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 #include =20 @@ -1171,3 +1172,79 @@ int compat_vma_mmap_prepare(struct file *file, struc= t vm_area_struct *vma) return 0; } EXPORT_SYMBOL(compat_vma_mmap_prepare); + +static void set_flags(struct page_snapshot *ps, const struct folio *folio, + const struct page *page) +{ + /* + * Caveats on high order pages: PG_buddy and PG_slab will only be set + * on the head page. + */ + if (PageBuddy(page)) + ps->flags |=3D PAGE_SNAPSHOT_PG_FREE; + else if (page_count(page) =3D=3D 0 && is_free_buddy_page(page)) + ps->flags |=3D PAGE_SNAPSHOT_PG_FREE; + + if (folio_test_idle(folio)) + ps->flags |=3D PAGE_SNAPSHOT_PG_IDLE; +} + +/* + * Create a snapshot of a page and store its struct page and struct folio + * representations in a struct page_snapshot. + * + * @ps: struct page_snapshot to store the page snapshot + * @page: the page we want to snapshot + * + * Note that creating a faithful snapshot of a page may fail if the page + * compound keeps changing (eg. due to folio split). In this case we set + * ps->faithful to false and the snapshot will assume that @page refers + * to a single page. + */ +void snapshot_page(struct page_snapshot *ps, const struct page *page) +{ + unsigned long head, nr_pages =3D 1; + struct folio *foliop, folio; + int loops =3D 5; + + ps->pfn =3D page_to_pfn(page); + ps->flags =3D PAGE_SNAPSHOT_FAITHFUL; + +again: + memcpy(&ps->page_snapshot, page, sizeof(*page)); + head =3D ps->page_snapshot.compound_head; + if ((head & 1) =3D=3D 0) { + foliop =3D (struct folio *)&ps->page_snapshot; + ps->idx =3D 0; + if (!folio_test_large(foliop)) { + set_flags(ps, page_folio(page), page); + goto out; + } + foliop =3D (struct folio *)page; + } else { + foliop =3D (struct folio *)(page->compound_head - 1); + ps->idx =3D folio_page_idx(foliop, page); + } + + if (ps->idx < MAX_FOLIO_NR_PAGES) { + memcpy(&folio, foliop, 2 * sizeof(struct page)); + nr_pages =3D folio_nr_pages(&folio); + if (nr_pages > 1) + memcpy(&folio.__page_2, &foliop->__page_2, + sizeof(struct page)); + set_flags(ps, foliop, page); + foliop =3D &folio; + } + + if (ps->idx > nr_pages) { + if (loops-- > 0) + goto again; + ps->page_snapshot.compound_head &=3D ~1UL; + foliop =3D (struct folio *)&ps->page_snapshot; + ps->flags =3D 0; + ps->idx =3D 0; + } + +out: + memcpy(&ps->folio_snapshot, foliop, sizeof(struct folio)); +} --=20 2.50.0