From nobody Sun Feb 8 05:34:55 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC39314B82 for ; Mon, 5 Jan 2026 08:23:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601419; cv=none; b=to3jS0OVoE3PfdjPwTIpj5wBxxZy7eXxOBYKloBM1H4bdPb9WPSQ+Tum4Hi3AOwMTrf59PaghFrHd/aDUyCZfu58rQwyUAP1AMQo1mVFTE3++NDBITE3ZAc5IntOFw923TTBKUAP3QoaQdR2QMLarA/qKXaNpMiQcQw0pNlcTpI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601419; c=relaxed/simple; bh=S9cU9rMSKLAHqC3C9VUi030/VnGNztyhDP4UPj+0Vaw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wn6qvEzz+1TokJ2qqAX0a/aLxzaYwS84+/aSlVD4Zh14fEtmrh26XnhHlk/mxUnQDAHSYavkw6RMQ/4TQOau9rmZ3Aunc+BKt5H0VRfHOlE4u/t2IXniBBibKhlFlN/QaudTNQfCQ7K2bRUrgZEkM4av1zSytp/N+/y9a7IK6/g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=fail smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DObQ1Wju; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nkGj46o3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DObQ1Wju"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nkGj46o3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767601416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TvLvTQPEJKAtkqGovGo2GHeF0+EOLKvEuwFpv+PiquM=; b=DObQ1WjuRpWScNuAi70c6Z3ZI7/IJ6pT2ZpVxF3/1L61WkR06wT1jZm/Gqxd7H+oKYbLNX OA65CF2Vm33IyQKdUPGB7kbjn3c7f3yB7w4gU1Y0PGrJxnL72+8bMin9bLRtuiGjYPf09j SQP1SEuKoIw7EFLI1a/9i3QfoFU5eKA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-kecV3dHjN6acZljo_2geTw-1; Mon, 05 Jan 2026 03:23:35 -0500 X-MC-Unique: kecV3dHjN6acZljo_2geTw-1 X-Mimecast-MFC-AGG-ID: kecV3dHjN6acZljo_2geTw_1767601414 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-431026b6252so12388483f8f.1 for ; Mon, 05 Jan 2026 00:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767601414; x=1768206214; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TvLvTQPEJKAtkqGovGo2GHeF0+EOLKvEuwFpv+PiquM=; b=nkGj46o3hq4C07bUT18o22UMSLLMiYkVF7R1oYX4y5U0eeN/5Vgd6QhNTISSSZxe+v P9WcXaPJZrw82sUU/TfbnyAdg4tQVaX+M2bDcMath0txP7gVBjTWQtSrfrIP/JTm68iY UIcl7EWPk0EpWnmRTubIpsDFCl1CwcI/PS1DifZz7NHho2GyviuSIzD39neA+q5SqSN5 puGBuASeW0KLGqLZLbJEe4RauywB9z9a7FdyiCWUuNpqvW6+Ih/J7J0m2Y/gpNsLs5ao 5aLWPmbxNDCqVXWndT4Tfi2zCqT7I/9b6kcBfbzM989YqFe2R/Ec0PgXJwm3xvzC/xZ7 CD8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767601414; x=1768206214; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TvLvTQPEJKAtkqGovGo2GHeF0+EOLKvEuwFpv+PiquM=; b=kuhwUtkDVx3XhWHblr33EeXU6FqYgmeMQcFXrDF9dIC3bGkjdgBquRbg+vb7pwkhQt Z8SGCDeLe8AVM/7hI8jRZB6niYHt4GyhYzoKUzeY8y7l1npKXRONCgoMNKWFi4aC/qSp qffVaB2VdrDQCfqZf6vWefZKJbu9LVtrEhZ/HwbyI/ykDlH7F0C5ugLbJau/BmM+yekC BgB7xh8VfoQVv++3ty3HJ3Q32D8D9ljvoBOm8/T57M3TcNM5pXM2Zkx5oSshhM/x/ZBp KJOQOzd7d7weXUE7zjtyGt1X9RSxLP5mKkWOJy4SWasi1/63liXyI42Gio9UgYLizgLU zYVg== X-Gm-Message-State: AOJu0Yx3ussnluKFvaAWD64733+1psiBzUSE4MWUYJvHP9fhh4d6U1qS x2exTJAlYHmjGY+sKh6PjaY/Opg11hxqMQYQraUMYS6mVsdsdJnA5cMki1zWX4QJzeF5tnJG5WD MD4Hup8dgsDrZflvxtXg/8UL3ah3/StH5BkwBYTScdFAptJ+vNB5/aPPDNkte71Z3OVBd24nChb gZ6PKQu8LPpXP4PUfoMO73DOdvnRYteZjsNhju+jpLAl8= X-Gm-Gg: AY/fxX5tAm7iBzyAmvX8dtswOzzHaAzFK+sfIvz2N82DkrXKqAzv6PsUSmvkJmmkc+a J7/k7hnVsAKAoXi7K18jYnTqOPSR4BO7KAbbrUk6P+gw7GukUo5272mRA5zZQhc+qmPjPxxc/id NbRA/DBx8/B+d4wvhO4pURqcaPKJVT/MDwdootJQvOG8zibf7Ij42A0ElhrIZBSztQ+23tBUQXd I/x6qWKRNcm0l09MPn6T0WCJs4M+1VkiEsU/0sK1IoNBBQjfKXdmhC4XXC3mNgtsYzAWKbOXXlg jpdelw8c7d7Fq3BwofBTXOoaLyCEbQ6NGEN9SUFmXwHgFQu8YmpOMB1ykWVHlDjUnIqve70rxFD V/dbwHHNC5GHx4BrVEJLJkqiz3VHinbwDWg== X-Received: by 2002:adf:eb04:0:b0:432:84ef:841f with SMTP id ffacd0b85a97d-43284ef8d0cmr31362913f8f.38.1767601413570; Mon, 05 Jan 2026 00:23:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx7eWbROO38mdjmsXsZ8eTRhzoo1KnfbPFeP9XiXzVU5+PKMGQRYrz1a7izR0YG2kvu7gW1Q== X-Received: by 2002:adf:eb04:0:b0:432:84ef:841f with SMTP id ffacd0b85a97d-43284ef8d0cmr31362856f8f.38.1767601412963; Mon, 05 Jan 2026 00:23:32 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa2beasm98160481f8f.33.2026.01.05.00.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 00:23:32 -0800 (PST) Date: Mon, 5 Jan 2026 03:23:29 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 10/15] virtio_scsi: fix DMA cacheline issues for events Message-ID: <8801aeef7576a155299f19b6887682dd3a272aba.1767601130.git.mst@redhat.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Current struct virtio_scsi_event_node layout has two problems: The event (DMA_FROM_DEVICE) and work (CPU-written via INIT_WORK/queue_work) fields share a cacheline. On non-cache-coherent platforms, CPU writes to work can corrupt device-written event data. If ARCH_DMA_MINALIGN is large enough, the 8 events in event_list share cachelines, triggering CONFIG_DMA_API_DEBUG warnings. Fix the corruption by moving event buffers to a separate array and aligning using __dma_from_device_group_begin()/end(). Suppress the (now spurious) DMA debug warnings using virtqueue_add_inbuf_cache_clean(). Signed-off-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi --- drivers/scsi/virtio_scsi.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 96a69edddbe5..6ff53fc8adb0 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -29,6 +29,7 @@ #include #include #include +#include =20 #include "sd.h" =20 @@ -61,7 +62,7 @@ struct virtio_scsi_cmd { =20 struct virtio_scsi_event_node { struct virtio_scsi *vscsi; - struct virtio_scsi_event event; + struct virtio_scsi_event *event; struct work_struct work; }; =20 @@ -89,6 +90,11 @@ struct virtio_scsi { =20 struct virtio_scsi_vq ctrl_vq; struct virtio_scsi_vq event_vq; + + __dma_from_device_group_begin(); + struct virtio_scsi_event events[VIRTIO_SCSI_EVENT_LEN]; + __dma_from_device_group_end(); + struct virtio_scsi_vq req_vqs[]; }; =20 @@ -237,12 +243,12 @@ static int virtscsi_kick_event(struct virtio_scsi *vs= csi, unsigned long flags; =20 INIT_WORK(&event_node->work, virtscsi_handle_event); - sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event)); + sg_init_one(&sg, event_node->event, sizeof(struct virtio_scsi_event)); =20 spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags); =20 - err =3D virtqueue_add_inbuf(vscsi->event_vq.vq, &sg, 1, event_node, - GFP_ATOMIC); + err =3D virtqueue_add_inbuf_cache_clean(vscsi->event_vq.vq, &sg, 1, event= _node, + GFP_ATOMIC); if (!err) virtqueue_kick(vscsi->event_vq.vq); =20 @@ -257,6 +263,7 @@ static int virtscsi_kick_event_all(struct virtio_scsi *= vscsi) =20 for (i =3D 0; i < VIRTIO_SCSI_EVENT_LEN; i++) { vscsi->event_list[i].vscsi =3D vscsi; + vscsi->event_list[i].event =3D &vscsi->events[i]; virtscsi_kick_event(vscsi, &vscsi->event_list[i]); } =20 @@ -380,7 +387,7 @@ static void virtscsi_handle_event(struct work_struct *w= ork) struct virtio_scsi_event_node *event_node =3D container_of(work, struct virtio_scsi_event_node, work); struct virtio_scsi *vscsi =3D event_node->vscsi; - struct virtio_scsi_event *event =3D &event_node->event; + struct virtio_scsi_event *event =3D event_node->event; =20 if (event->event & cpu_to_virtio32(vscsi->vdev, VIRTIO_SCSI_T_EVENTS_MISSED)) { --=20 MST