From nobody Mon Apr 29 03:44:41 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFE2C433FE for ; Fri, 30 Sep 2022 17:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbiI3RuI (ORCPT ); Fri, 30 Sep 2022 13:50:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbiI3RuF (ORCPT ); Fri, 30 Sep 2022 13:50:05 -0400 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F47C6414 for ; Fri, 30 Sep 2022 10:49:52 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:51946) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oeK8z-009VFZ-OC; Fri, 30 Sep 2022 11:49:49 -0600 Received: from ip68-110-29-46.om.om.cox.net ([68.110.29.46]:52818 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oeK8y-00F3KT-Rt; Fri, 30 Sep 2022 11:49:49 -0600 From: "Eric W. Biederman" To: Alexey Gladkov Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, kernel test robot References: <202209301555.UK7B8MPo-lkp@intel.com> Date: Fri, 30 Sep 2022 12:49:42 -0500 In-Reply-To: <202209301555.UK7B8MPo-lkp@intel.com> (kernel test robot's message of "Fri, 30 Sep 2022 15:49:21 +0800") Message-ID: <87mtagzr9l.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-XM-SPF: eid=1oeK8y-00F3KT-Rt;;;mid=<87mtagzr9l.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.110.29.46;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX18zA4WaFTNapOMCqPJzxuVXsv+qeL58GQY= X-SA-Exim-Connect-IP: 68.110.29.46 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: [PATCH] ipc/ipc_sysctl: Add missing include of linux/cred.h X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel test robot recently reported[1][2] that in configurations without CONFIG_COMPAT set the recent changes to ipc_permissions would result in code that would not compile, as definitions present in linux/cred.h were missing. Include linux/cred.h explicitly in ipc/ipc_sysctl.c so that it builds in all kernel configurations. [1] https://lkml.kernel.org/r/202209301555.UK7B8MPo-lkp@intel.com [2] https://lkml.kernel.org/r/202209301537.wYdDBROB-lkp@intel.com Reported-by: kernel test robot Fixes: 54e1011bd95a ("sysctl: Allow change system v ipc sysctls inside ipc = namespace") Signed-off-by: "Eric W. Biederman" --- I have corrected the build error by adding the following patch to the topic branch. ipc/ipc_sysctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c index 31282e0a630d..29c1d3ae2a5c 100644 --- a/ipc/ipc_sysctl.c +++ b/ipc/ipc_sysctl.c @@ -14,6 +14,7 @@ #include #include #include +#include #include "util.h" =20 static int proc_ipc_dointvec_minmax_orphans(struct ctl_table *table, int w= rite, --=20 2.35.3 Eric