From nobody Mon Sep 28 07:19:49 2026 Received: from bg5.exmail.qq.com (bg5.exmail.qq.com [43.155.80.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B196C2F7F1C for ; Tue, 25 Aug 2026 02:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=43.155.80.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787623736; cv=none; b=nrt+s3Ri1OWAxW7v2XQL75MiVZHZ23N7Y75LLzcCg/CRngAAEjAljprsWBl9/or6+gh1B39HpWFCFtqn4aU3M0BuziJ588IzHM0OC3sf4jV8wi/NHqEmbvEWmOGhuafAeGTwLyw7uwxCGXfrXP55l5oGFQDdvTyZcmSlTlQf+Sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787623736; c=relaxed/simple; bh=3XeC+/g/W5Nn7f54Lhf33rJoAZbRp+1EOgQwUp41Kgk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PGsdetcmRcsJJdWbMhEkKYNop9/XsG9d1/UbVpoSdLBjB5D0kucJU+v4t8bYgjSUuO8jI2VQvarzHcePMPxpj+BEssqsgo9wYsu4j3O0X60BRrVbxVhZ28qGaeXT493lPaSpUxYQ1LtQJrMgouApO9c3gjAw7j9p4hyAGYfyNRE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinsec.com.cn; spf=pass smtp.mailfrom=kylinsec.com.cn; arc=none smtp.client-ip=43.155.80.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinsec.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinsec.com.cn X-QQ-mid: zesmtpgz5t1787623702t11b32f7d X-QQ-Originating-IP: hByehVH7Y9tb/2JJEYRlenUTW8LI6rPRypywYXGuH90= Received: from localhost.localdomain ( [175.0.204.93]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 25 Aug 2026 10:08:18 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 14127132030379676705 EX-QQ-RecipientCnt: 13 From: yingchao To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , Leo Yan , Mao Jinlong , Tao Zhang , jinlong.mao@oss.qualcomm.com, qinyungao@kylinsec.com.cn, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yingchao Deng Subject: [PATCH] coresight: tpdm: initialize spinlock before exposing sysfs Date: Tue, 25 Aug 2026 10:06:47 +0800 Message-ID: <8693039B65AA093F+20260825020647.2469-1-dengyingchao@kylinsec.com.cn> X-Mailer: git-send-email 2.45.2.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:kylinsec.com.cn:qybglogicsvrgz:qybglogicsvrgz5b-1 X-QQ-XMAILINFO: OUxXyyAH19+LP+Nkgx8v0df2FTQjliabkni9OhpnSVIykTD8UY0gVaTi ox2AP9VIYYqUIUO1517GOMX7mnf2T7YmRiqMSt4eiQztc8dTil5Mc+6JLrY154mMzk81nqq xFLHyI94qTfP/xioiFjxJny6FnC5evoi7ff1judBU9MAowwU7uFQVwsgWCoz6kTWYLf4WZT d1HAH96fMgfs3waDKkbH4B2GYZzy5of4XxaO0pNkrhlXyxT96zwQ2EfQ1iw7dKEFVyrzDCx vNmdE+lqpLq8Cbph2rbMFIGWDCKoIDUuKFlWi3DozrLS1hgySRqd0D3HOOfSr7lar9fGmBj aS9qXR4a6Y5AKNN0GmvnhWtDuqm01YcvbrYkY62qiDSQPuLJuBVAdijYaO3F03ca85QLCh6 L7LJqSZj38zCUtG5ySfFAtSDWP/TEoy+PtrtqOWKPx/czbGQSRSNnuHO9+rPhDpMejLXL6d io2Qbv0a4ebM+s4xFwrBpuGR3zhLsBzzR0uwQsbUkT4dnx1aqHbHg223xDyoGyDW3sbscpA knpWZuUu87vmz9Zojym7zo0i80rkqwSM0oOYe4v1wINUZRfvpMWDsjUGQjHhidkuCwqLb9C lsOhkpFRx5k0/RChX5/3mmfNJ4VdvwfL6lSpDRhNmLE7sIASAJq5vakgWl/F/x9Foc4gqI+ Yw7KSJ6jTal1ac4/d/Qkdmy7JOXBVQ5QDEyF6twghbG4OAq49O4GvaKCwsLyU3Q6B4EWPsy RM3POiV0TFlXXQQSy28lRHDkhCTPKrMQXEW3dLg91p0V3mE9UVeLU/Grg5Xso/U3Vo8Gf/y 1bPB9BIxtoJJeQyL0wD+gYqdbQ+yMOFhN/ozKtLlxn7RXZ5pH6B8QtTM9nJ+jVbArkew6mp psxrqOe92LwxoA38t3Y7yM4S32cR3ETG2g/SbgBHeKVlL+1Vw07yUgH2/rmN0sgH1gTF5s9 lHAA+4ubVRUpsJr4kXFUlvxfxAW8ZczeNJqgaT4Ak6som18Bnsr3keDVSYM7NrKKY2XhxsD tjq3WHUOSvVekcUnZqSrHe/yv/wDI1lDvVY/Ne1uyuovkYtHRhQ8ZumCFW1j68m1mjhdyzf X76j0yotX9r/MG571gMOdajbGj6cnY20V8FQ0zKZH7wLqg/t21cDi2YeNSqvZuJw4itPjRq dh3b X-QQ-XMRINFO: MPJ6Tf5t3I/ylTmHUqvI8+Wpn+Gzalws3A== X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" From: Yingchao Deng tpdm_probe() initializes drvdata->spinlock after coresight_register(), but the sysfs attributes registered by coresight_register() use the spinlock. This exposes a window where a concurrent sysfs write can lock an uninitialized spinlock. Initialize the spinlock before coresight_register(). Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver") Signed-off-by: Yingchao Deng Reviewed-by: Jie Gan Reviewed-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtraci= ng/coresight/coresight-tpdm.c index 8464edbba2d4..50d1351772b9 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -1457,12 +1457,12 @@ static int tpdm_probe(struct device *dev, struct re= source *res) desc.groups =3D tpdm_attr_grps; else desc.groups =3D static_tpdm_attr_grps; + spin_lock_init(&drvdata->spinlock); + drvdata->csdev =3D coresight_register(&desc); if (IS_ERR(drvdata->csdev)) return PTR_ERR(drvdata->csdev); =20 - spin_lock_init(&drvdata->spinlock); - return 0; } =20 --=20 2.33.0