From nobody Fri Sep 20 08:36:29 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CD246437 for ; Wed, 27 Dec 2023 16:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059m-UU; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjw-001tZK-Lv; Wed, 27 Dec 2023 17:26:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjx-001Wmg-2E; Wed, 27 Dec 2023 17:26:41 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: kernel@pengutronix.de, Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] firmware: arm_scmi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:25 +0100 Message-ID: <86165c8ccd0bb47000a29e711102795b36c8df41.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1796; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JK/CSDYjlDzz8/Ko2zYkIZLw829LGnskJHP4zrb3nSc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFAzHGKIj+U2X2/VquNqcN62INqnmVrFKeBUV waVRlMvMSiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQMwAKCRCPgPtYfRL+ To+6CACSdd6ebXHEHuZH278GDpN/34UYlQyumgf05hEYLn7eStz0mwZTNZNBViswZLobbkbPjvj TUoGFM03/AvIKHgJVHzZmivM8csSsF18pCdURQ/26QNnv4XEItA9q6KOOGze54yeGKt4ir7mRwo H1syPHLrzQLDrf00QPIvhRj3sJoRF6FHV8HfYI7nGpnextDyr6+zTkcfxOC1vUvY+TIUXgHMk3A J41YL+ZRdcpMZEH7qFNq9icFrtCTVzqpNTLBT7x0xMmtWYCvS6o5xqwpQLeDOadis6WNhBrmRIR jH3lsv1OVKlzE+oq89AayWxMuMsgh1FqBuumXnYiubyQyRqf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/arm_scmi/driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi= /driver.c index a9f70e6e58ac..3ea64b22cf0d 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2834,7 +2834,7 @@ static int scmi_probe(struct platform_device *pdev) return ret; } =20 -static int scmi_remove(struct platform_device *pdev) +static void scmi_remove(struct platform_device *pdev) { int id; struct scmi_info *info =3D platform_get_drvdata(pdev); @@ -2868,8 +2868,6 @@ static int scmi_remove(struct platform_device *pdev) scmi_cleanup_txrx_channels(info); =20 ida_free(&scmi_id, info->id); - - return 0; } =20 static ssize_t protocol_version_show(struct device *dev, @@ -2947,7 +2945,7 @@ static struct platform_driver scmi_driver =3D { .dev_groups =3D versions_groups, }, .probe =3D scmi_probe, - .remove =3D scmi_remove, + .remove_new =3D scmi_remove, }; =20 /** --=20 2.43.0