From nobody Wed Dec 17 06:13:36 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8A5A33DEF1 for ; Mon, 15 Dec 2025 14:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; cv=none; b=qdo5EaFm7gkuRk83ZMYPWsR/bmtg68lTxeXikjgE2vjQjJGH27/O3mBkQ14fC4ZaYxxyD8TgOHf9o4Bh+kKR5YZk9v8+foxslWrKx+TrNjo0TnRS+XEe+E9Xjey5FApy6hUSop7fl5wYRBMIf8IFKqfX91lPThhRmBtWigjPfbM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808280; c=relaxed/simple; bh=4A/9VAHmTaZWnv8JgiT7H1qCJuRsg+ML7SSaVfNtUv0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WXzz6egS/n9i7+NLUD1k/hDbEdglHjGj1cu7LzV55xI4RRZvD94cD39JVf+mb4GtG8QjaCn8Z0qM//JdtxaY6HGdg5tcS7r4IEiQzZ/ttHUFGQlw0oc9wYmQMYX8z4eCyiD3GF5e4w3OalBQlsK05nye5elZT9EKpxmoQBTsW5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=mm+vn8Iz; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="mm+vn8Iz" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6492e25cd7eso1240523a12.0 for ; Mon, 15 Dec 2025 06:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1765808272; x=1766413072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sfzDwdLQJZM+QWaZp429a9MEMQ68gzEG7kbM26+AAC8=; b=mm+vn8IzC5KfpdLYgEU6KpMr4FaNGnqtVc7NfPa8oDlyyfkwbZ9JBhQfzxIwYVfNQH +lFEAH78R3djpoYCQSSLSGyXJB0wOUbAr96TlcOEkS3ElR5ifMSJFOlyk+aN97eeE7aX 0C4PWbDAwVcuBJnFe/2y5f1pmBvlbfk/odUsRxG/JNltcpVNddNU57A+TQeBGzQxrysh zn7+UhKFbO9d5CDa/dJq9uufSkJTsQQXucOaD7cejll4aL65oI9E+e5OjAg3xCsLMTq7 M/bTVqCQsJEuWeN+KwvWv37TSd+3uslxq8I+0qggaQTZtp912S1GPFE8mum0bXXFVXQI hDEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765808272; x=1766413072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sfzDwdLQJZM+QWaZp429a9MEMQ68gzEG7kbM26+AAC8=; b=XJQTTq/yG978eiyBI9AW+3VgQ0d67Ghsx3Ae0zdxZNwbOq+qwb0EC7M0jxTLHBiFxK syZmaD5kEYDZJHz9llQAnnWey/U/2JQqDdmK+CMzae8DjOgs/sCcvHipQpyvG4N+gcQp yquyw+r5FzaucVk952FlLAHA572bwQddNvbOECKNtS1JMhfVnNjyJ78wMOy9POfMXWCB y83WgWXso+GznwlDh4KlXa8/byfxt18gftIOrdv+aUJQouQ9JgDBrijNOV9M8squI2aa PTI+D6z8jfipCKt3nrRFnlPGKS+/EAXYio1GAOsK7he/s4EHLa1/0e/v0/xiJCQ+DUxT auUg== X-Forwarded-Encrypted: i=1; AJvYcCVxe9bVFS+K0GDssiHRrxuablE1XdhSAyIIRpZVKUvswI35nWWvjo4cfgTIsciEAisE0iFO4rAMLG0r+YE=@vger.kernel.org X-Gm-Message-State: AOJu0YxnGzFimai1C9r00Z/mQRgWW/wUaZHLVj5jUBeVdRa7wjf7VSo/ H3Kuq24zuRVUAqrk6M9nR6np4BlQngcc/sZChK2jA2iznK2sN2oy7eAC0d3uy4/9Wrw= X-Gm-Gg: AY/fxX53Qt/AXFknLBsy2hN88gBdgUgczYhj+AqoPsyGQM6wphYC9kRClfPFLspJjG1 NmZ40c7HyLya+44oezk2uZ9LgvPAW4kSU6p3UOH5PJTqO7UUuTcY5wVT5KctCBm1wR3123UFld2 gapduHnwzXXoUORcT7AoKX6pKLW/K9CdU3TUusBrp+qXWsf1IKW/cl2LcDLRd2Nk8g9RuaKxutN jXMVqvzw/4f4FalwGCy/4I5LEf6gNDm598cnYr+5M24vvU2sNzBnpwMUSrmnG+9UH55h0sy7bm+ NCsWbryhTncvQKsQbVKvIoJREydv5OVS+1/ymV+tnOOCOHW7VcGqP3TGB6/URnJ61yNuTllzusy 7Vc84PlCV4236/bZ+jxYyD0cJoUwYZTEQBtuBGvxUnEgAKEfZSV1vX4QktE+llCN/7ZNVGOlIIh 2mPuIVhOJkZX7I/qyaY9BHGuWmG8gTKQ8mtznaJOFJ/NSltRdque1R5IxKYZbvho0aRCaq X-Google-Smtp-Source: AGHT+IFOJgC5Ya2iL64i8Tv4dTF8QQYDLC4+J0wActxyot5OM2vMJCd/KcUe/O38HWI5lnvavkRPtA== X-Received: by 2002:a05:6402:345b:b0:640:abb1:5eff with SMTP id 4fb4d7f45d1cf-6498745b430mr10332378a12.8.1765808272372; Mon, 15 Dec 2025 06:17:52 -0800 (PST) Received: from localhost (ip-046-005-122-062.um12.pools.vodafone-ip.de. [46.5.122.62]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-64981fa5514sm13619843a12.0.2025.12.15.06.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 06:17:52 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jens Wiklander , Sudeep Holla , Sumit Garg , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Christophe JAILLET Cc: Cristian Marussi , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/17] firmware: arm_scmi: Make use of tee bus methods Date: Mon, 15 Dec 2025 15:16:41 +0100 Message-ID: <859339714ce238c34fdc4832fa23d6d6abec6ba1.1765791463.git.u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2594; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=4A/9VAHmTaZWnv8JgiT7H1qCJuRsg+ML7SSaVfNtUv0=; b=owGbwMvMwMXY3/A7olbonx/jabUkhkwHiXSzA2c6kuc0awa3zu+SCZ668nFKvHWuQ19u+6RrV +fOP2TSyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBELnWw/7OWWaMvsKvlGqeJ z1e9vfb6bD16p1Yo+j3aH1+h4WE+cR+rYGip+ZscsVOCdsvEzzEe/2OuPX1C0dzONVfenBSXdO6 e1BtrkaJnFXTX9qFbVku81gGHfJl9i7dtXOw37fxuLncN9+t2MjZ9TFN03JkW/zSd8+Hcdrf3Yu pCDWLba9+rzpdm/bDznlWxX63nqrDMdlVjC6bdwWea7PgbbQsaD3usDXjRmnko2+n6OT7dn1PuK vutPc98QFulL1RplW5+csjilybqX3IPKcRm3Xw5LW/Jft5d9ns+zE+5xtCrPjX07ZFLfxQsBcSi Jt3TWi4c4RbgyGilb3ldI3iztf2EVXo9Fy6eZON4E9APAA== X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The tee bus got dedicated callbacks for probe and remove. Make use of these. This fixes a runtime warning about the driver needing to be converted to the bus methods. Note that the return value of .remove() was already ignored before, so there is no problem introduced by dropping the error returns. Reviewed-by: Sumit Garg Reviewed-by: Sudeep Holla Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/firmware/arm_scmi/transports/optee.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/firmware/arm_scmi/transports/optee.c b/drivers/firmwar= e/arm_scmi/transports/optee.c index 8fdb80d3fabd..07ae18d5279d 100644 --- a/drivers/firmware/arm_scmi/transports/optee.c +++ b/drivers/firmware/arm_scmi/transports/optee.c @@ -529,8 +529,9 @@ static const struct of_device_id scmi_of_match[] =3D { DEFINE_SCMI_TRANSPORT_DRIVER(scmi_optee, scmi_optee_driver, scmi_optee_des= c, scmi_of_match, core); =20 -static int scmi_optee_service_probe(struct device *dev) +static int scmi_optee_service_probe(struct tee_client_device *scmi_pta) { + struct device *dev =3D &scmi_pta->dev; struct scmi_optee_agent *agent; struct tee_context *tee_ctx; int ret; @@ -578,24 +579,22 @@ static int scmi_optee_service_probe(struct device *de= v) return ret; } =20 -static int scmi_optee_service_remove(struct device *dev) +static void scmi_optee_service_remove(struct tee_client_device *scmi_pta) { struct scmi_optee_agent *agent =3D scmi_optee_private; =20 if (!scmi_optee_private) - return -EINVAL; + return; =20 platform_driver_unregister(&scmi_optee_driver); =20 if (!list_empty(&scmi_optee_private->channel_list)) - return -EBUSY; + return; =20 /* Ensure cleared reference is visible before resources are released */ smp_store_mb(scmi_optee_private, NULL); =20 tee_client_close_context(agent->tee_ctx); - - return 0; } =20 static const struct tee_client_device_id scmi_optee_service_id[] =3D { @@ -609,11 +608,11 @@ static const struct tee_client_device_id scmi_optee_s= ervice_id[] =3D { MODULE_DEVICE_TABLE(tee, scmi_optee_service_id); =20 static struct tee_client_driver scmi_optee_service_driver =3D { - .id_table =3D scmi_optee_service_id, - .driver =3D { + .probe =3D scmi_optee_service_probe, + .remove =3D scmi_optee_service_remove, + .id_table =3D scmi_optee_service_id, + .driver =3D { .name =3D "scmi-optee", - .probe =3D scmi_optee_service_probe, - .remove =3D scmi_optee_service_remove, }, }; =20 --=20 2.47.3