From nobody Sun Feb 8 19:03:50 2026 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2F336AFB for ; Mon, 8 Apr 2024 08:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712563827; cv=none; b=spyX0F9n73YgeejUpZLOiKL7KfRV4P65f3/2TLFakmg0CJC1bG9lx8+54weQGMwbtY4w6ine0bushskXfBNxenRy8MyaOTkAoG1uOsYsW61u7sZqCwxeQFgz4kHMXXmhKOg2i8lz8MtxDpXEYiMh9fgH5KCSc1/NvjRoNxY4ifs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712563827; c=relaxed/simple; bh=GHDQU9zd2nMXU7UlrQa3DtToNffnBvQ5Ugz2l1CzFYM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=rN3LJtVJ2v/kGLINElf6/lp+Su33Jhw6EVxfpFhUNSsUL5DyCX1gVwEazeVBXBwsHxjRpJXcokJeR6i1Ti1uGvM8d+06Sb0xfiHbKB3efaMSfrGYqqNobbZom2geghj2jo6Nq3zcFSQJRgSy1+PDNm+J05R4280x5A1PKovkGbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lA1jsfpf; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lA1jsfpf" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-56e1baf0380so4540988a12.3 for ; Mon, 08 Apr 2024 01:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712563823; x=1713168623; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=LOr2piSF59rBtL6qQkJRVxuVH7En2uLFiUAi/dy63d4=; b=lA1jsfpfNIMPKQ3qH+2mopqRLcf3heuEPPpprN54142bgZ57ukTuIitDmKQGYUDwgK u1eA82n6FfDFzT62zXPg4fKPfOCf7SPlmyfb7gjv1OefhVEEJi2RFqszkC8WJii2oOj3 I2tMjb2BrccF8OoctXyZPxXO8FDw6JE9r60nHUFr1KytJzzV3JrwjN4pgiXiI6oAsssr Xj/oTcfPfSQdWGlUj5BE51PDpV5pj0MpVysmIv4fvWdKB1RiLK6zGRDaIa46/imDiieS 44ZpCA7fL+Lai6VmPe+/zw4n/muLAxkW7rrKA80hVt8GO5bLq662vsqVBaVSpc1U61HY jjSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712563823; x=1713168623; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LOr2piSF59rBtL6qQkJRVxuVH7En2uLFiUAi/dy63d4=; b=w8W2EOB8f+TsHxhGywb1+UhgQ6bgHrjt5Vpqtv2Ev3WnTBJntdXV9UIgDKptghuDbU RG5j51fNl4lhnqEHdeTPp5zAM2PsS1ZtekCRF1JUGy/+OFy+10/LAA+uK6EltaggXKOS ySq7+yiqZmH5BeNcCFDa+CLe9tcwmfXY/F02DoZbFZL8nskLGV2KwCE068Om9aNVJpKi HcEg0tcMUnS35fS8ZBGviuxbyvivgX9kiKsIkgmc71+GbcyZJgXMwS69EBiL49iUgJu6 bLPDt2oyQyzyRmM9K4fr3gNSiYCJpc0MGI3Y/vH3yncBFsCRYh+5S80map0Tn4i3l/Zp fC/g== X-Forwarded-Encrypted: i=1; AJvYcCV3oIU1uykKARVqLs1yQGBZufKX+Z/vqcQ+JZCqcWwVAQPuEy4IgLrPe+PKiKmpW6v5jqNy51xgQKIaGN4+Mm2KsQK5ougyxanfk6XP X-Gm-Message-State: AOJu0YxHKPH140KYOrb1gXL/WQqm3WAwsbaCtQqR7320k3WZPJe4rrPX rto4E8MU6J+fL57iWM7qy8J4vHJuyecnWDmZmmvGZgRQheVaCwOwuGeHvuwoj5U= X-Google-Smtp-Source: AGHT+IHSMNUBKuLQipt6eiK/GpbVAIRoVBfOGY9eusOY9M1lS39qRZiKY7EBBCgcSpTRamQWTGpjPQ== X-Received: by 2002:a50:d6d2:0:b0:56e:2bf4:fe0a with SMTP id l18-20020a50d6d2000000b0056e2bf4fe0amr6239511edj.35.1712563823192; Mon, 08 Apr 2024 01:10:23 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id b14-20020aa7c90e000000b0056e46beba6dsm2416447edt.16.2024.04.08.01.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 01:10:23 -0700 (PDT) Date: Mon, 8 Apr 2024 10:36:35 +0300 From: Dan Carpenter To: Boris Brezillon Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] drm/panthor: clean up some types in panthor_sched_suspend() Message-ID: <85356b15-4840-4e64-8c75-922cdd6a5fef@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These variables should be u32 instead of u64 because they're only storing u32 values. Also static checkers complain when we do: suspended_slots &=3D ~upd_ctx.timedout_mask; In this code "suspended_slots" is a u64 and "upd_ctx.timedout_mask". The mask clears out the top 32 bits which would likely be a bug if anything were stored there. Signed-off-by: Dan Carpenter Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index d4bc652b34d5..b3a51a6de523 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -2546,7 +2546,7 @@ void panthor_sched_suspend(struct panthor_device *ptd= ev) { struct panthor_scheduler *sched =3D ptdev->scheduler; struct panthor_csg_slots_upd_ctx upd_ctx; - u64 suspended_slots, faulty_slots; + u32 suspended_slots, faulty_slots; struct panthor_group *group; u32 i; =20 --=20 2.43.0