From nobody Mon Feb 9 08:27:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E766C4332F for ; Thu, 20 Oct 2022 14:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbiJTO0b (ORCPT ); Thu, 20 Oct 2022 10:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbiJTO02 (ORCPT ); Thu, 20 Oct 2022 10:26:28 -0400 Received: from vps-vb.mhejs.net (vps-vb.mhejs.net [37.28.154.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 549A31AFA8A for ; Thu, 20 Oct 2022 07:26:25 -0700 (PDT) Received: from MUA by vps-vb.mhejs.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olWUx-000601-0e; Thu, 20 Oct 2022 16:26:15 +0200 From: "Maciej S. Szmigiero" To: John Stultz , Thomas Gleixner , Stephen Boyd Cc: linux-kernel@vger.kernel.org Subject: [PATCH][RESEND] clocksource: downgrade messages about skipping watchdog check under load Date: Thu, 20 Oct 2022 16:26:09 +0200 Message-Id: <841757364754f8d0a8834982ca16da10a6a44d72.1666275945.git.maciej.szmigiero@oracle.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: "Maciej S. Szmigiero" Since commit c86ff8c55b8a ("clocksource: Avoid accidental unstable marking = of clocksources") the watchdog check is skipped if two consecutive watchdog reads are too far apart. This might happen, for example, when the system is under heavy load, so it isn't a totally unexpected condition. Since some systems are prone to producing significant number of these messages when the system is constantly under heavy load downgrade their log level to "debug" to avoid filling the kernel log in such case. These messages can then still be enabled via dyndbg mechanism in case someone really needs to see them. Signed-off-by: Maciej S. Szmigiero --- kernel/time/clocksource.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index cee5da1e54c41..ff99b25bc1aec 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -236,8 +236,8 @@ static enum wd_read_status cs_watchdog_read(struct cloc= ksource *cs, u64 *csnow, watchdog->shift); if (wd_delay <=3D WATCHDOG_MAX_SKEW) { if (nretries > 1 || nretries >=3D max_cswd_read_retries) { - pr_warn("timekeeping watchdog on CPU%d: %s retried %d times before suc= cess\n", - smp_processor_id(), watchdog->name, nretries); + pr_debug("timekeeping watchdog on CPU%d: %s retried %d times before su= ccess\n", + smp_processor_id(), watchdog->name, nretries); } return WD_READ_SUCCESS; } @@ -262,10 +262,10 @@ static enum wd_read_status cs_watchdog_read(struct cl= ocksource *cs, u64 *csnow, return WD_READ_UNSTABLE; =20 skip_test: - pr_info("timekeeping watchdog on CPU%d: %s wd-wd read-back delay of %lldn= s\n", - smp_processor_id(), watchdog->name, wd_seq_delay); - pr_info("wd-%s-wd read-back delay of %lldns, clock-skew test skipped!\n", - cs->name, wd_delay); + pr_debug("timekeeping watchdog on CPU%d: %s wd-wd read-back delay of %lld= ns\n", + smp_processor_id(), watchdog->name, wd_seq_delay); + pr_debug("wd-%s-wd read-back delay of %lldns, clock-skew test skipped!\n", + cs->name, wd_delay); return WD_READ_SKIP; }