From nobody Sun Feb 8 19:56:53 2026 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 612062123DB for ; Tue, 12 Nov 2024 10:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731406991; cv=none; b=iVfcNbaF+Tab1Mwb0eFEXBMAFVFj//dG2qYMVHkbLsQJNSk+w+i0WHJgLQA7XztvQEX/s2bkGXVUMxZYA7zhybmkZHNe3BUNd2nGh2bugPcfJlp74j0oG5OHA+tcNeZJYjo0pWwabyXrl/tZ2WffP81+vqO6MOx4wHRRRYE0Au0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731406991; c=relaxed/simple; bh=e/QqDzlVLbsFjZCG9tc6aZaGsN5YICbP0g+qKrCy2XM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bJhjduzEyFh+PnrVaqq3jWd5zyXr8IX6Kr2elJRq8lt0dE2FnY1G1Lzi7AOoQuJ+TbpEqLvZrVuu+fcE+XY3f4oABEOMqg+Q388poEOpkwM3jmE0lK4crnkBd6TEEMVrLsOGzmkD1XZmPqTMH4mcrpRZbgAK2Trbz60Xe2Guylw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qjUh3xZj; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qjUh3xZj" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a9ec86a67feso946317666b.1 for ; Tue, 12 Nov 2024 02:23:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731406988; x=1732011788; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Ezd42G+JwcNpijWol87RV7vPAsy6HdlYEXoioaZ3yUM=; b=qjUh3xZjuf2V4Kddsrd7fwDSoiID/KN/poQOgn6lFjGqf4cDP60PVTGIp5iIspKcsa FFtdv/GuG9/g6uff3JulmtVQoZsUwwVelUPid7NrEWHF7ty9W2R7RfZ70gp466kIk76h DbhTaN2id+s+R1c/qSyXIXdyP4B70zFL1Sq3fvjowOvu4pKb76+Md0FCJ1dacCCg5AS3 OdedmMS/fwSLeNObBWelp8GbdqzofpMInQueJ29DsmQgj8ef38Sbfd4rmqdDnvEFr1BC y9G11KNFoADEQ4x26C+WAfVr6A9V+KhYXTkKKfHaqePkMXTzjRwxPd/hkjoo1xGIf/E5 vf7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731406988; x=1732011788; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ezd42G+JwcNpijWol87RV7vPAsy6HdlYEXoioaZ3yUM=; b=bheHqeRV/8HLaHYIKOwjMAAChOwRK7HhWZdvL0XZSpVPujwv3nAW0QGoIZSPibFtwj DyZ47TwzmlnMxkmsmykrEFNOWHJU1V7eBQTzlF97ZxkPq1hCo64vtb5w/RWUMmbHzFLB DtOiTBv13KEnVEN9vPFxvrdxaIELd+jc1M/gYnRgJovzz4lm7J5sLG9pHqOTFcyGsG8w 4spd5Ip0q6DXIlDwVUkib0UsDOvCyQLV3EGSdVFRzLe70hIsIl1MqWnSA4dRmY4/SBht /GSfVZvNHc03/fbliooQSM9CAmPe+wsMsp1zhhN1gbtq+CAZ8I/jVDUgt2zKiAO/366o 1kpg== X-Forwarded-Encrypted: i=1; AJvYcCXKUL3e6XZjpBosb3vzaaPXKS09hPBwJhBLoPFqaWUu024xDHDyiAVAdxw8jn2snwZuIgN8QGVBgjYTBSo=@vger.kernel.org X-Gm-Message-State: AOJu0YzOWpZ8X1O1mrDS/cyJmNIUjb/5QLnM1N65N0He94HjaIvBF6JV i3NHNdC7Ci6+grD10qj9Yhq8T3FOX+4jduX8ABXK6z8/VESGWEZF4Wk5ISufBqiun0O/n3vej0X f X-Google-Smtp-Source: AGHT+IGt4j9ZZSe9rgo5rLVKL7Sw0JNMnKYRedUbOwvl2VfIbz2NdhXaY+7ntI9ZFHojloYTONpjJw== X-Received: by 2002:a17:907:7d8e:b0:a9a:14fc:44a2 with SMTP id a640c23a62f3a-a9eeff44f6emr1650475766b.30.1731406987590; Tue, 12 Nov 2024 02:23:07 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9f08c9ae30sm394026966b.55.2024.11.12.02.23.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 02:23:07 -0800 (PST) Date: Tue, 12 Nov 2024 13:23:03 +0300 From: Dan Carpenter To: Liu Ying Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Biju Das , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] drm/bridge: ite-it6263: Prevent error pointer dereference in probe() Message-ID: <804a758b-f2e7-4116-b72d-29bc8905beed@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If devm_i2c_new_dummy_device() fails then we were supposed to return an error code, but instead the function continues and will crash on the next line. Add the missing return statement. Fixes: 049723628716 ("drm/bridge: Add ITE IT6263 LVDS to HDMI converter") Signed-off-by: Dan Carpenter Reviewed-by: Liu Ying --- drivers/gpu/drm/bridge/ite-it6263.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/i= te-it6263.c index cbabd4e20d3e..5f138a5692c7 100644 --- a/drivers/gpu/drm/bridge/ite-it6263.c +++ b/drivers/gpu/drm/bridge/ite-it6263.c @@ -845,8 +845,8 @@ static int it6263_probe(struct i2c_client *client) it->lvds_i2c =3D devm_i2c_new_dummy_device(dev, client->adapter, LVDS_INPUT_CTRL_I2C_ADDR); if (IS_ERR(it->lvds_i2c)) - dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c), - "failed to allocate I2C device for LVDS\n"); + return dev_err_probe(it->dev, PTR_ERR(it->lvds_i2c), + "failed to allocate I2C device for LVDS\n"); =20 it->lvds_regmap =3D devm_regmap_init_i2c(it->lvds_i2c, &it6263_lvds_regmap_config); --=20 2.45.2