From nobody Sun Sep 7 12:22:23 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2798CDB465 for ; Mon, 16 Oct 2023 16:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233930AbjJPQRC (ORCPT ); Mon, 16 Oct 2023 12:17:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233759AbjJPQQt (ORCPT ); Mon, 16 Oct 2023 12:16:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99CB483; Mon, 16 Oct 2023 09:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697473007; x=1729009007; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Vcfo3VrFSXo0AcnEcqaWcF2T8gFYUDjrWL/o/03UKpc=; b=kGzw+m7ePZGqrf75dXakfwnaj5l0/7bFMRdVaPR4HtCDAPEzfW45jWO+ AXXZeg8dTNAC6rKCwIhwa4MqoOyuSRJ4sNVXEoM00AaitV4YarxOAevwy W0ehO1XChhRhwemL25hLz+YkmDoX7zkKO3IGeC1Hi9MuASMI/mxC+CFR4 j9KFgwEMvTEW8FvGfQessmYBv2wRut0LYVutVNjrpI2uHosL8qigJ4M3h D3Sc6E/rNiWfyxjM223Qq2eESfVMPiqmKFNkocUmHp/OjQcbLxEMTYQgp KxtX6wxBgJxOmuP4KGM5RD9vPC0jwFpBpvW1cDJ7LkvQo5FQODj5svIj4 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="364921753" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="364921753" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:15:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="846448110" X-IronPort-AV: E=Sophos;i="6.03,229,1694761200"; d="scan'208";a="846448110" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Oct 2023 09:15:42 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com Subject: [PATCH v16 045/116] KVM: x86/tdp_mmu: Sprinkle __must_check Date: Mon, 16 Oct 2023 09:13:57 -0700 Message-Id: <8018ce789f7bc0147af1f43804edbc945cebd5b9.1697471314.git.isaku.yamahata@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Isaku Yamahata TDP MMU allows tdp_mmu_set_spte_atomic() and tdp_mmu_zap_spte_atomic() to return -EBUSY or -EAGAIN error. The caller must check the return value and retry. Sprinkle __must_check to guarantee it. Signed-off-by: Isaku Yamahata --- arch/x86/kvm/mmu/tdp_mmu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index d76c1ad44638..882848b24941 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -567,9 +567,9 @@ static void handle_changed_spte(struct kvm *kvm, int as= _id, gfn_t gfn, * no side-effects other than setting iter->old_spte to the last * known value of the spte. */ -static inline int tdp_mmu_set_spte_atomic(struct kvm *kvm, - struct tdp_iter *iter, - u64 new_spte) +static inline int __must_check tdp_mmu_set_spte_atomic(struct kvm *kvm, + struct tdp_iter *iter, + u64 new_spte) { u64 *sptep =3D rcu_dereference(iter->sptep); =20 @@ -599,8 +599,8 @@ static inline int tdp_mmu_set_spte_atomic(struct kvm *k= vm, return 0; } =20 -static inline int tdp_mmu_zap_spte_atomic(struct kvm *kvm, - struct tdp_iter *iter) +static inline int __must_check tdp_mmu_zap_spte_atomic(struct kvm *kvm, + struct tdp_iter *iter) { int ret; =20 --=20 2.25.1