From nobody Sat Feb 7 18:21:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC4AEB64DA for ; Mon, 10 Jul 2023 10:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjGJKF3 (ORCPT ); Mon, 10 Jul 2023 06:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232762AbjGJKEw (ORCPT ); Mon, 10 Jul 2023 06:04:52 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E0D18C for ; Mon, 10 Jul 2023 03:01:30 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4Qzzzp2ZF4zBHXhD for ; Mon, 10 Jul 2023 18:01:26 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1688983286; x=1691575287; bh=PyOOJASrvDlFlpTMrbZnhxWUxwu x8onceApx5EockGo=; b=erAgk2mFDIezBF+ARrjyQVU3ouCxKIfFIiChEU88QYf Kvx5taEKHPBLhYHe4bF6RfGlzavTrMiXHRV2RiBE67e1gRxTBu2YWS3Umwj5A6+0 3JrTxDbF4rBwkZNeQA3cCGMFozfjG1X3i+Hdo46+1mkxF9ZiQsKvDh5L5T+JZPFy BX++ULdYv3YGFzrcG5YnCDX+dFQbX/+uf1DajfYYtCgydwjhCvbAB5ivAjzNgzVa 3b3FfMFenBuEAaBc3b1Gj+tAyjWpVGmR0HxchPFcw7jjQarHYEnysqHmBXKJmywC EoNGK27XH3MRddWec17UCYlf5G8cKXRKIGqIsvbpEKQ== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rtmEQlkZnvAS for ; Mon, 10 Jul 2023 18:01:26 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4Qzzzp0lMvzBHXhC; Mon, 10 Jul 2023 18:01:26 +0800 (CST) MIME-Version: 1.0 Date: Mon, 10 Jul 2023 18:01:26 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/iccsense: do not use assignment in if condition In-Reply-To: <20230710095957.77430-1-xujianghui@cdjrlc.com> References: <20230710095957.77430-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: <7e2e8f69f6faf6a7bb8ecb65c8933f22@208suo.com> X-Sender: sunran001@208suo.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8"; format="flowed" checkpatch.pl does not like assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c=20 b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c index 8f0ccd3664eb..2428f3d6e477 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c @@ -322,7 +322,8 @@ int nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type=20 type, int inst, struct nvkm_iccsense **iccsense) { - if (!(*iccsense =3D kzalloc(sizeof(**iccsense), GFP_KERNEL))) + *iccsense =3D kzalloc(sizeof(**iccsense), GFP_KERNEL); + if (!*iccsense) return -ENOMEM; INIT_LIST_HEAD(&(*iccsense)->sensors); INIT_LIST_HEAD(&(*iccsense)->rails);