From nobody Thu Dec 18 03:58:44 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F2B122F823 for ; Wed, 15 Jan 2025 06:53:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736924003; cv=none; b=eGYKnLsfOHvezbNzOgvAYozDYrHBOIizxnumEyHnKpkNSDq0p4bN/c+iuduq3oYmNR4huzUfYja9PmnvvcBuoiShwI2597TLaCr6YaEo/8SjUXD7/aG1Er6YA+VPff63nXsDOf9AoulDucu7H5y4QNHzUpeol7XAayhbpFOCxFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736924003; c=relaxed/simple; bh=lZtdYvwm0/D+wrEsjVubJTTYAK+wxUZeR9nJ3jVsGl8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Wlpj2IAwLgSknP+/Yn20FLyHBlNrG9GCy9SCEiFwqN5BUZKVpmIyvnbVkNfIHpXeqYi9AMELiR18I7kSDqBNtyCOJ/7uwflcS3gyo3rRFZAewT855etjLq7mOSGVTPbqCvS2caRxR1SYJ+1E0ELeSRoGuW2zj+6CuaSdjKcjbps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XLOf31fG; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XLOf31fG" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5d0ac27b412so8528256a12.1 for ; Tue, 14 Jan 2025 22:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736924000; x=1737528800; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=1jHKviSWbOJnThNL+BRNc29xaYnK5sB8qfkKjQ020pY=; b=XLOf31fGgX/FS5ncmoLi84Csb4BAl3+99Eu2RWNBz/HZZKXx7tFbk4vkvP6gQ+a6uU HGBEdEVqUzh1dIFzfAD6rppY6Ot2wIM/jZM55GbVqVJWPwu08/qXZhxgF5eLnzCZfVpN 6VLp9XayHP5ZTaqV+04cguwo8YbI7qYbWkJU6J0hO5AguzDoIe4mDg4IXVdTnuB7Zuhp AyaX7oky33O/E1S2RyPEQCdVUlm7tvLSnNRioamXBUJ/QaIY5o3x5QQZTzI9ofNMBAde C9pGUyv3vePMsQDXb1cEBSzke43LeUpAOldPAURV1DDe2hi0JAPWgxKMhy+5cGgdC7Ot uAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736924000; x=1737528800; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1jHKviSWbOJnThNL+BRNc29xaYnK5sB8qfkKjQ020pY=; b=wQVMrWq1l7oLUQlKbrVXWs8l0i4tahgASjiAAXsfgZseecO5C2voyeZK6KxwbMj0x0 1cYJBrT4sldxEhXLUQir+615ZBY8W+YsrxjiD/jb/8ZiBH3R5WSoOQcvoFLnJgsYUrLy NfBMzgwz5Uidqc0Pgunr4/964oKr8R6Hp8bNCTweo8f9FPaswf65Ha5tuVQcIQXUnpYV Swsn1q3GwmJIDZAkYJSSEBucggo70tvmq2h3102SsJz5npDbUZPQyGjaABr3MD051nXX ZDW5DS9pj6Oq+PEkBsS0uHFWFcVI58ql/h4aoBkrWwRBLDp8EbaOIAeg3qHdcVuZoJiL ia6w== X-Forwarded-Encrypted: i=1; AJvYcCWN1t2itROqPS5t3awHNBvezqgYgwZFEGCQmxR4ZUL1IuFK5f+fFUGGTa5fvB9AJtQ3I4JsEpa6CLXKPqc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/UX0P8Knb9fimJi+i6n6xVVQk8Ce/1fD8mgYN3h672O79a9xM qU9DwQXt54+4O2dZOIhLKXeg3LOcPFH95M66MkTbdt1ZzaQamINCZ5Uce6oDJGE= X-Gm-Gg: ASbGncvHE+VhoB8/u0Axz0MPxUzQHhsyUZ9sAmHGOTjqoE1YW/oQCpYWnooNFtU71jR 1u+yj0GygnEWHhTasZUO+oh7UwtHlKNR2vGxvuNyBhjZBXpAIcH26WVYnW83JLi6oCXpHMpWvl/ TnAAlrxGk5tT5Tkv87ZihqdNkHn2Dq7+saI3G7Xp5DLey6h61FVe1fx/n/ivdvks+qNNfj2PKUD jRNVRJ4gXK9D1eTigATTWgdgqAAEvm+DMZqM7PuOh82pQcplLJJMYlHbBGdpw== X-Google-Smtp-Source: AGHT+IE9P5PDtBvyWPxhRNEsLiyx/nfhdVfXbwMkWhpN/F7zwvZlvMv1+220NOQBetuNrhffj43vww== X-Received: by 2002:a05:6402:518b:b0:5d3:baa3:29f with SMTP id 4fb4d7f45d1cf-5d972e06740mr26199332a12.9.1736924000495; Tue, 14 Jan 2025 22:53:20 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d99008c371sm7145838a12.11.2025.01.14.22.53.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 22:53:20 -0800 (PST) Date: Wed, 15 Jan 2025 09:53:16 +0300 From: Dan Carpenter To: Anand Moon Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] PCI: rockchip: Clean up on error in rockchip_pcie_init_port() Message-ID: <7da6ac56-af55-4436-9597-6af24df8122c@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Call phy_exit() before returning on this error path. Fixes: 853c711e2caf ("PCI: rockchip: Simplify reset control handling by usi= ng reset_control_bulk*() function") Signed-off-by: Dan Carpenter --- drivers/pci/controller/pcie-rockchip.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip.c b/drivers/pci/controlle= r/pcie-rockchip.c index fea867c24f75..35bfdf3e17a3 100644 --- a/drivers/pci/controller/pcie-rockchip.c +++ b/drivers/pci/controller/pcie-rockchip.c @@ -132,8 +132,10 @@ int rockchip_pcie_init_port(struct rockchip_pcie *rock= chip) =20 err =3D reset_control_bulk_assert(ROCKCHIP_NUM_CORE_RSTS, rockchip->core_rsts); - if (err) - return dev_err_probe(dev, err, "Couldn't assert Core resets\n"); + if (err) { + dev_err_probe(dev, err, "Couldn't assert Core resets\n"); + goto err_exit_phy; + } =20 udelay(10); =20 --=20 2.45.2