From nobody Thu Dec 18 15:27:24 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 736F3230BE6 for ; Wed, 14 May 2025 23:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747266192; cv=none; b=f8nGfcisrWPNkT+mlIPE0CPb7f6lIlJrgc/iLxGn+mQTcLl/6ibR/uMR+Ufl8ZaarR/HClZHzK9Lg8V+3qciBUOqEPqV4CUEe+Yu2yQi0lJhQy/XtWGUTALeCaBt6GFJv4972+TnmLsvRHButx/4D+lkErBs1wTxw8LZQsCplQU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747266192; c=relaxed/simple; bh=TuCNdCmxfK0dmEiyt2S0QuAAbIE9Srge8FQVDB0ZAyI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ccyce9jDXC1tbgzuamiJYG0+VY5Oq7wefsfLgoD2fNytXxCIOIJY9GFSGwClZFsmTQ25bHi1fEvrYg2tbAPBuq6spdxeyo9Y8sko0bQl1kQFNBcaeDvw120v9xsvTI6PQpF1L2NKfYRA0PZksZMUeRRBz/n5KXXyVIQv8wMOf4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Qc3Hqwi+; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ackerleytng.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qc3Hqwi+" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30abb33d1d2so654391a91.0 for ; Wed, 14 May 2025 16:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747266190; x=1747870990; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=O4oPfv2n35WjJH2QrKz/exL9QiCodfRoanXJUAdhzSo=; b=Qc3Hqwi+RdTmMP8o5BfDPMMa0DOonJYElm5vx1OVGSiD0ekNGhc3zHt6RUP0rwO7YZ sbAP5XcYCaGXja8PEpnMX5tfHesNGtkjDulRN7IY0G3fDVLunr9H+lr4tRcZlzZzue4n rp4LbHMXGo4a/cFOdt8oAkcqeSydhYPpSs61QFedt0kni1QOJzVWOBbiAF5fFiX43AsK BSxr+cIP8bcCVp6sgNSEQV2ySZsb55oP9nRef2B58fQB20ba7NR4VkKnlM8+2BV8Dbi1 OKWTfliDvdSMQhoHfr4oNlET/TMTQSXEuFVYo8HFVFJ6wFCp4CR5FRSzibVkHBZWwUSb lV5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747266190; x=1747870990; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O4oPfv2n35WjJH2QrKz/exL9QiCodfRoanXJUAdhzSo=; b=mh/d1oMaLL9La6LZDjMtZ/nKOCQ4n/ca+HuKuBena6fYhu/Dq84jvA5J4ChwT671Cb o/67WZGZFWmyLRCAHfj798MGHajdNLTl/JKPb5qN76Y+5X0R6oZ++HhKHro14QEJ7PHC 99pf6sZu5m1rvwOml1b0jFJDOmX6fDrOwBBv+A02rIiJGUkA3/xQTwb6Qw3oh6dLX7in mgJVDxx7y5It4fX8rEowR/UHphlkRDvYgANIE+T+IhWzJQ0UTqwZLSqIERpESnRyc+Ta 9DMpaR/dEvsafYdF7sZwUTeRIpOZUP4q7ROzPpGJAK7BOpvOiIHLSa3TExNg8K15iOoW akug== X-Forwarded-Encrypted: i=1; AJvYcCWfvdkTIjiBHD4YDzadQLUE7TJQo8tPvlEGq+ggUOEOOIpC2ieyuVgfrgt+enYxYq3UFadqE1gl/K5I5x0=@vger.kernel.org X-Gm-Message-State: AOJu0YwxcJ81GnSHJNjPTSyAASb+xeOgVttwSsJj1pWANRWzac5oRrTu HIP10pT+7au/rhbxB3/BpbdEdi95p6ODrrC1KDdL8/NrIkvO8T8y2QFoCTk75H56iakl1tRFOb8 EudwOYwBZ2OUuC2k++5a6dA== X-Google-Smtp-Source: AGHT+IEA8LrfLfFI8PpcjddLO/wbh1V8oxL5OnFdRpSUscIRk8byP+XixVrSrRP2XLlfKkrpW4t+rWo0H2IMHIeXcA== X-Received: from pjbqx15.prod.google.com ([2002:a17:90b:3e4f:b0:308:64ce:7274]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2dc2:b0:2ee:f687:6acb with SMTP id 98e67ed59e1d1-30e5158e007mr667015a91.13.1747266189745; Wed, 14 May 2025 16:43:09 -0700 (PDT) Date: Wed, 14 May 2025 16:41:47 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Message-ID: <7ae972e602f94cef707ccb19b139638f4266d361.1747264138.git.ackerleytng@google.com> Subject: [RFC PATCH v2 08/51] KVM: selftests: Test flag validity after guest_memfd supports conversions From: Ackerley Tng To: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: ackerleytng@google.com, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Before guest_memfd supports conversions, Coco VMs must not allow GUEST_MEMFD_FLAG_SUPPORT_SHARED. Because this is a platform stability requirement for hosts supporting Coco VMs, this is an important test to retain. Change-Id: I7a42a7d22e96adf17db3dcaedac6b175a36a0eab Signed-off-by: Ackerley Tng --- .../testing/selftests/kvm/guest_memfd_test.c | 26 ++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing= /selftests/kvm/guest_memfd_test.c index bf2876cbd711..51d88acdf072 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -435,7 +435,8 @@ static void test_vm_type_gmem_flag_validity(unsigned lo= ng vm_type, for (flag =3D BIT(0); flag; flag <<=3D 1) { test_vm_with_gmem_flag(vm, flag, flag & expected_valid_flags); =20 - if (flag =3D=3D GUEST_MEMFD_FLAG_SUPPORT_SHARED) { + if (flag =3D=3D GUEST_MEMFD_FLAG_SUPPORT_SHARED && + kvm_has_cap(KVM_CAP_GMEM_CONVERSION)) { test_vm_with_gmem_flag( vm, flag | GUEST_MEMFD_FLAG_INIT_PRIVATE, true); } @@ -444,7 +445,7 @@ static void test_vm_type_gmem_flag_validity(unsigned lo= ng vm_type, kvm_vm_release(vm); } =20 -static void test_gmem_flag_validity(void) +static void test_gmem_flag_validity_without_conversion_cap(void) { uint64_t non_coco_vm_valid_flags =3D 0; =20 @@ -462,11 +463,30 @@ static void test_gmem_flag_validity(void) #endif } =20 +static void test_gmem_flag_validity(void) +{ + /* After conversions are supported, all VM types support shared mem. */ + uint64_t valid_flags =3D GUEST_MEMFD_FLAG_SUPPORT_SHARED; + + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, valid_flags); + +#ifdef __x86_64__ + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, valid_flags); +#endif +} + int main(int argc, char *argv[]) { TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); =20 - test_gmem_flag_validity(); + if (kvm_has_cap(KVM_CAP_GMEM_CONVERSION)) + test_gmem_flag_validity(); + else + test_gmem_flag_validity_without_conversion_cap(); =20 test_with_type(VM_TYPE_DEFAULT, 0, false); if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { --=20 2.49.0.1045.g170613ef41-goog