From nobody Sun Feb 8 00:12:09 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1FDC001B0 for ; Tue, 11 Jul 2023 03:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbjGKDjM (ORCPT ); Mon, 10 Jul 2023 23:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjGKDjI (ORCPT ); Mon, 10 Jul 2023 23:39:08 -0400 Received: from mail.208.org (unknown [183.242.55.162]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230A8137 for ; Mon, 10 Jul 2023 20:39:07 -0700 (PDT) Received: from mail.208.org (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTP id 4R0RS759sdzBJFS0 for ; Tue, 11 Jul 2023 11:39:03 +0800 (CST) Authentication-Results: mail.208.org (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=208.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=208.org; h= content-transfer-encoding:content-type:message-id:user-agent :references:in-reply-to:subject:to:from:date:mime-version; s= dkim; t=1689046743; x=1691638744; bh=yZynzVUlk5mpXs9aHjvK7lG63wT C8Y75Je7Bu13k+DQ=; b=qBHnLJwW4VAlI7YyZq6Nr7+t6mUAn+OEotJDeMTpbLe gTtOGOlY/iG/2e0mVY3BMr5MTCuYqcya7b3VwEqnbwrlXHW8a9MpNRjS79XhJ56K GkyGe7NOxlcKcHbxh7VDQw9L9EcidqssvQ0PHgmcr35bEg9MMNjc/DXe4k/ovZ+b n1A2lZ8Yc1kfbdMfub1iN0AaaFVPdNNMN1PD6TxJCJJP+67q4FGa23890t+68kji BJEQE5TX52yzDV5rrsw0LXsBdEtlHvy3HPXcoXtxivQVZbkJ5Kj2Dz93kTrJHAEK VNM6kEQDr2Xyera+RseCEVC4DYoP2eIsctt1U0CK5tA== X-Virus-Scanned: amavisd-new at mail.208.org Received: from mail.208.org ([127.0.0.1]) by mail.208.org (mail.208.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5vEp06B-5k0o for ; Tue, 11 Jul 2023 11:39:03 +0800 (CST) Received: from localhost (email.208.org [127.0.0.1]) by mail.208.org (Postfix) with ESMTPSA id 4R0RS72jLFzBJ8kq; Tue, 11 Jul 2023 11:39:03 +0800 (CST) MIME-Version: 1.0 Date: Tue, 11 Jul 2023 11:39:03 +0800 From: sunran001@208suo.com To: airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition In-Reply-To: <20230711033745.79190-1-xujianghui@cdjrlc.com> References: <20230711033745.79190-1-xujianghui@cdjrlc.com> User-Agent: Roundcube Webmail Message-ID: <7ad788a6cf70f338a32690953531b439@208suo.com> X-Sender: sunran001@208suo.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8"; format="flowed" Fixes the following checkpatch errors: ERROR: do not use assignment in if condition Signed-off-by: Ran Sun --- drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c=20 b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c index 16b246fda666..52af200b45bc 100644 --- a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c +++ b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c @@ -203,7 +203,8 @@ nvkm_falcon_msgq_new(struct nvkm_falcon_qmgr *qmgr,=20 const char *name, { struct nvkm_falcon_msgq *msgq =3D *pmsgq; - if (!(msgq =3D *pmsgq =3D kzalloc(sizeof(*msgq), GFP_KERNEL))) + msgq =3D *pmsgq =3D kzalloc(sizeof(*msgq), GFP_KERNEL); + if (!msgq) return -ENOMEM; msgq->qmgr =3D qmgr;