From nobody Mon Feb 9 10:27:34 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C52235BF0 for ; Thu, 24 Apr 2025 10:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745491031; cv=none; b=oixg/yeFEWHYp4Onfo9BlnGnf47FimOSRHDzQoZ3h+nD/xRiTeqZx/y6lWl/FpKj+dqcAkUwvOOsr0RoxYxKPRm3qeFq8hClZBi4bhCgcTatrTZyZ5xBD+HqTQA2zpyFSNYwpGirpA8R77LBjwliZ3/jdxnQfj6Ex04O9HhLjZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745491031; c=relaxed/simple; bh=XV8ObqiVVogtjO5N873sKSFmTsTaRcd1IBSPiFBNL38=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VqAj4VkhV715DkDCD/upTiQyoOw6EUGDJx721h9JkmJl8BR4kV3vWJfaRWr5QIWJ+ZoTUbdvep4N+Xu2fNnUa2ArNjLnPuKMqnG0Q9el1mpvXtpIjmmoQTh5KNCQq/F+6yLnA+Qzi7roc6uJIpKVtpyGTPCrlBm1dYD98GXIIfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AiOEEFyg; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AiOEEFyg" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-22409077c06so12562695ad.1 for ; Thu, 24 Apr 2025 03:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1745491029; x=1746095829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XiIG8WEszkc/dlu2pYPwLwPCyzJuamBVIXLOR35LVRk=; b=AiOEEFygzlPo0eLE6UUqd/uIuZaUZxcwFIR8mf/BpHB/flO+IF3k66YIuhIeABrUEq vgk4gd5/62JzimuXwtL0sMXNE6ZVxvuMcclxdq/1kWcLqkfv5IgcuNc0ajnzro5344Em tPvt6ZJmOFP+ynyEMmh9XjdQtNQYMc72RVUA1+aKYLeaimpE7X3+guyArJ6/3i/uQuD0 H7EzrhbyMOxL8XkiesLsRTtwX3lbMzG7vGSCxAikYDeGCO/R8XK3VlnHkXdUYCFBjmZf s2lbU0zfqrUGETZpRmwXkn3OMvAi/zPFSeBkJFkQ69toXFL461VCTzqM7C1m4yKB9ikn Ctdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745491029; x=1746095829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XiIG8WEszkc/dlu2pYPwLwPCyzJuamBVIXLOR35LVRk=; b=qSafDb9vzm4Ig15W4/JxEWTR9y1Wr8ZBsWNRXxu65QfcSwlS7s12HxYxT1BAfYGiQX 76oTANXWCpxZEvv4qZZTYBjZQhU51R7GYO49EJy+04jjm5kJwV4rV3kDksInttQRWAst QTCMjvd+Z4tAXsV1aO8wT31JquRnyQnPMDcGn38XQtI9dYzoOmV0HrIcWrqqVW6WxFD+ bBA5HHytbCmCGnoVR/CVgBJ81y/aLYbZBGt3I1AOLikypiKIYHvjAeAqxFhrOIkwrMD/ e4K1ldk2J4Kjm9K7YLo2M5M9M04e5yJwvcLR9DlvCDQkOD6/h9Au6LaiP17sWcaU85QS /uKg== X-Forwarded-Encrypted: i=1; AJvYcCXQDN1+G3NxP0cLS+7a3KW7vmoHdFHOcb5AeLNKAInUpVacaFqmcu6BHLbTkBCKz//BuzldfsOX+w7rDLk=@vger.kernel.org X-Gm-Message-State: AOJu0YxlW4teiw5QG8SF2V7jaoiE0h6Qad9tbmf4NUzz1AouV+oiH/Lz 1XiNW4Ig2iaQuPXs4gsEPkuekAj/2o/WiF31FTBXn2gCtxuiVgzTipv1TdlC5a8= X-Gm-Gg: ASbGncuGzma/O1o2s/nI+jd8Tp1zFt1dNcIFDWttlSwsr8N3pZcSNaJobAlot5zPQr5 kaMSmvvj7kls6hcD5OCVeO8HAuvzi/Ks3X1PxxdN9i49yNLDIUobwcDi4GN72Fjxitym2Zmy3Kr A5iJAi9WBKFwE04WfmcagUUru4cldEDbPRwQLKNP60ieqA7Hargg0OLJokop0eVyJ/QpL7uZ4Hj CKWlDyA1AuXP+vi12+O0SfWHkD4RjUhSugC/oOzjv3ki+z2usl6IAoHldSrDTeVYBWd6039BkT6 BhB37q0O3nlqdil1ELZmiF2g1p+dzJMR5nVifNCNeA== X-Google-Smtp-Source: AGHT+IEg3HiY1hRFa0sd4VmP7cYuftC34v8NrLnxhQq8aERPS7VCcuo9i6ofali9iKtAnB6B35F9CQ== X-Received: by 2002:a17:902:e5c6:b0:224:1219:934b with SMTP id d9443c01a7336-22db3de966dmr28392755ad.50.1745491028769; Thu, 24 Apr 2025 03:37:08 -0700 (PDT) Received: from localhost ([122.172.83.32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22db4d77ee3sm9945165ad.2.2025.04.24.03.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Apr 2025 03:37:08 -0700 (PDT) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: [PATCH 2/6] OPP: Return opp from dev_pm_opp_get() Date: Thu, 24 Apr 2025 16:06:45 +0530 Message-Id: <7a3be00771aa9786c7bb4cdb0ee36fee45f67d69.1745490980.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For convenience of users, return back the pointer to the opp from dev_pm_opp_get(), so they can do: opp =3D dev_pm_opp_get(tmp_opp); No intentional functional impact. Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 13 ++++++------- include/linux/pm_opp.h | 7 +++++-- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index e63a9b009df1..150439a18b87 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -1188,8 +1188,8 @@ static void _find_current_opp(struct device *dev, str= uct opp_table *opp_table) */ if (IS_ERR(opp)) { mutex_lock(&opp_table->lock); - opp =3D list_first_entry(&opp_table->opp_list, struct dev_pm_opp, node); - dev_pm_opp_get(opp); + opp =3D dev_pm_opp_get(list_first_entry(&opp_table->opp_list, + struct dev_pm_opp, node)); mutex_unlock(&opp_table->lock); } =20 @@ -1329,8 +1329,7 @@ static int _set_opp(struct device *dev, struct opp_ta= ble *opp_table, dev_pm_opp_put(old_opp); =20 /* Make sure current_opp doesn't get freed */ - dev_pm_opp_get(opp); - opp_table->current_opp =3D opp; + opp_table->current_opp =3D dev_pm_opp_get(opp); =20 return ret; } @@ -1724,9 +1723,10 @@ static void _opp_kref_release(struct kref *kref) kfree(opp); } =20 -void dev_pm_opp_get(struct dev_pm_opp *opp) +struct dev_pm_opp *dev_pm_opp_get(struct dev_pm_opp *opp) { kref_get(&opp->kref); + return opp; } EXPORT_SYMBOL_GPL(dev_pm_opp_get); =20 @@ -2706,8 +2706,7 @@ struct dev_pm_opp *dev_pm_opp_xlate_required_opp(stru= ct opp_table *src_table, =20 list_for_each_entry(opp, &src_table->opp_list, node) { if (opp =3D=3D src_opp) { - dest_opp =3D opp->required_opps[i]; - dev_pm_opp_get(dest_opp); + dest_opp =3D dev_pm_opp_get(opp->required_opps[i]); break; } } diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h index c247317aae38..5e4c3428b139 100644 --- a/include/linux/pm_opp.h +++ b/include/linux/pm_opp.h @@ -161,7 +161,7 @@ struct dev_pm_opp *dev_pm_opp_find_bw_ceil(struct devic= e *dev, struct dev_pm_opp *dev_pm_opp_find_bw_floor(struct device *dev, unsigned int *bw, int index); =20 -void dev_pm_opp_get(struct dev_pm_opp *opp); +struct dev_pm_opp *dev_pm_opp_get(struct dev_pm_opp *opp); void dev_pm_opp_put(struct dev_pm_opp *opp); =20 int dev_pm_opp_add_dynamic(struct device *dev, struct dev_pm_opp_data *opp= ); @@ -345,7 +345,10 @@ static inline struct dev_pm_opp *dev_pm_opp_find_bw_fl= oor(struct device *dev, return ERR_PTR(-EOPNOTSUPP); } =20 -static inline void dev_pm_opp_get(struct dev_pm_opp *opp) {} +static inline struct dev_pm_opp *dev_pm_opp_get(struct dev_pm_opp *opp) +{ + return opp; +} =20 static inline void dev_pm_opp_put(struct dev_pm_opp *opp) {} =20 --=20 2.31.1.272.g89b43f80a514