From nobody Mon Dec 1 22:34:53 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DDFA2FF160 for ; Sun, 30 Nov 2025 23:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545738; cv=none; b=ej22C1FMT3F2wtO8dTA1y2UQ3dT+ELtatZuym25mJzPZKJiYh41/XGli+kKhA7lDpxUbBmyc+1Vsfcnp508zN2aVgejC4rntuWHvgZZJwQaa0VfI877WNQvUPzjhMuCIxJvecL68Hfxn+vDLZ7wq3Boy3fd3mCNrbqZbZVelqrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764545738; c=relaxed/simple; bh=G7RQvwuA5HOESStkbO7E13FYoPystOeEJRkdlljNekE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i4qhOY2akYtZTUYRIGZjv67spyZV1nYc5NDo2erpZOVB+ep+UM8Vwz+KztJB3I9vyskr2TAv70Yq7nLKINe7GFwuxdd8zBw5K6ubu01ZdBt372LEPgkxlJKAi4PH35LpscgwuGEWZt6J6cuAFcb4PjIdkg1PW3b1lVdWbB0vapE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PWPJXlyG; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PWPJXlyG" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so31106875e9.1 for ; Sun, 30 Nov 2025 15:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764545735; x=1765150535; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sqQYwi6yKkW0pXFhK5Fhz7jwEEb4HUCqJfGCd/MpDPo=; b=PWPJXlyGt4wao7lV6oiZY0rxvEb8bgtplIE237q+H4mxDYxj3xg0vcLxj7XidXCpmU Lvi5QQfarmRv5UKCd7OviYxXSpVaYeXR6/4cBy1r+sYwURl6ydLsuBa3tNEqcwhranPO CbmBRJvmSsdsP52OcGlwC/xVB49PUQ+zUJoEDBLpDMVtS0ih6tlBIlk0zNNlxJDV9ioL P94dYAmPleF6O0lQM5syKuOR+kfsjbjiAx58dzpTzKKxRgW8pM5mLBQ+eRO8ofsFA0L8 UsL1T7fG9mJOsg/TwyUEdclaUtmt2tTbsPzNawTJPjJCvHgxbx/ZHi2JaRiCMG9PWtBF 5Mfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764545735; x=1765150535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sqQYwi6yKkW0pXFhK5Fhz7jwEEb4HUCqJfGCd/MpDPo=; b=fwmYOoWj81WIwQhWcWMZoxR8l+EVEcAIcggkW34nhigEYhAVj+Vo3+hXmPDHGj2odP zezoBL1Tyn0typpqFK6aPBWa+PL9zefxveoJEUochb5+II4uBHYDjvrW0l6M2i+UXRB8 HQcm8CcqU7iSr1NjZjKoiy9EzjIwh5vYi6p5pbxsvzKm4LOOjf5zTcIqbBP32Ee1M4tG HRNGVplMKIyDjWwm8O4XhKeKHb5pNmmPxoAboT0WSwwAWXnpTmzKGdxgNaEYMFRC3TUA aCaBwauZzO8vrkOUbcHhbqiaeTTzRaS4uVyqoUnra8WL5RKO2GCa/4BpNAbMBmq4iPT3 WyVg== X-Forwarded-Encrypted: i=1; AJvYcCWg8y1YH6ShCO7x7kKwrNH9sSycYNbQu4zEQtLuLusVilkzYf1qUyMyctEXv2QT65EeJ4qtxlxtM02GdtU=@vger.kernel.org X-Gm-Message-State: AOJu0YzfLlfcBddVxZsOL//XvedwuvU+/ti8iEv7h84vqJJRk8nYrBRh X+rAQvzzZeyEGSOkLAU/Lj7VtPr4q0MxvqelnPv96+P1TnYkURz2jUET X-Gm-Gg: ASbGncvzcSEHP5DH2+bsVcU6jxFOf9Duo4Dmb7ooGTU0aQ9PwAMbeaMxWVuJPBmll4x VxynMWRyrM9LT8VoZOHiwNQ1ynnimjHGRdsKBsVuz4gekab0S4rWkdlx+zCahPO6SVoCEOS3/18 3b2VWs1yi4L/K3CUc+a3UyaNwHjsQDG5Vg56dLcowQlfQhe1XX9wvVYv6EmgNqytFP2R5Xc6y3T iSpd7v6AHs35IJ8fcTrLTFmDoMtphc8K/x3Tux5PhTjnL6JFkjE1XmMesx1gdPsSil3fqiEtVds c3qalVcBhEqUzgxfcp1my6wBPVZ/dH+HbgIlER1nTi1v3c+Ms6GiuRLPzckGsnUOiG44vC9g/fH 22074bOVl4RQDx9uKnOqNySb5rOcbTt9sSpyu35UlGuw6OE4UgTGQfU5tWrlwXKqvpRNhXmeN8X LTZd/DoiJRWeiqXnVZ5XHL5XorvlIqUkTJQqfb92XEO0/ufjDdb2j6MoJUKkAat/f10vCd0dBkK 2Uf90IWNYhfZFY5BLij40DiNSc= X-Google-Smtp-Source: AGHT+IHgav/tPp3nDxDwQbNFJXjlN5z5JlpJjaWPnlbmKTfJs2yUPwa5uXWlHjxmsi5Gji90OcciDA== X-Received: by 2002:a05:600c:1c1b:b0:471:14b1:da13 with SMTP id 5b1f17b1804b1-47904aebebdmr257224195e9.14.1764545734689; Sun, 30 Nov 2025 15:35:34 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479040b3092sm142722075e9.1.2025.11.30.15.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 15:35:33 -0800 (PST) From: Pavel Begunkov To: netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Ilias Apalodimas , Shuah Khan , Mina Almasry , Stanislav Fomichev , Pavel Begunkov , Yue Haibing , David Wei , Haiyue Wang , Jens Axboe , Joe Damato , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, io-uring@vger.kernel.org, dtatulea@nvidia.com, Stanislav Fomichev Subject: [PATCH net-next v7 2/9] net: page_pool: sanitise allocation order Date: Sun, 30 Nov 2025 23:35:17 +0000 Message-ID: <77ad83c1aec66cbd00e7b3952f74bc3b7a988150.1764542851.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We're going to give more control over rx buffer sizes to user space, and since we can't always rely on driver validation, let's sanitise it in page_pool_init() as well. Note that we only need to reject over MAX_PAGE_ORDER allocations for normal page pools, as current memory providers don't need to use the buddy allocator and must check the order on init.i Suggested-by: Stanislav Fomichev Reviewed-by: Mina Almasry Signed-off-by: Pavel Begunkov --- net/core/page_pool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/core/page_pool.c b/net/core/page_pool.c index a085fd199ff0..265a729431bb 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -301,6 +301,9 @@ static int page_pool_init(struct page_pool *pool, } =20 static_branch_inc(&page_pool_mem_providers); + } else if (pool->p.order > MAX_PAGE_ORDER) { + err =3D -EINVAL; + goto free_ptr_ring; } =20 return 0; --=20 2.52.0