From nobody Thu Oct 2 00:50:48 2025 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B5EE30CDA6; Wed, 24 Sep 2025 15:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.17.235.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758727237; cv=none; b=Uddlmylhj0cJIkHWBvBKjm4wFHl9H5VxOeqrMjj1j6Imyhgjh4QOkliDj5D6wxS4dRKEEyme5yxH5dfug2nCw/IOAWTZ25uFzcbTlDMOa9ghN328DtDUn5b3QGkAId3xWP2bEg4AJnAK5rw7ihCOpM1F6NW8fRdyAmhX5byi5RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758727237; c=relaxed/simple; bh=NUgMFd1DP4iApIqk7SLIwHxdIBK3tE7nt9mFkQcSPH8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YE8WglqfqjyldUfd9+65UfvY1yOS14tH5n5Y9JpVIP8XqB5P36pvoUszaVp3L/XldtVe2rbKOcMlPfK1MTkwbJro2c3N2o9BAHm+UyWpzGfjAJQve+0Vjvj+9nLkF7X6hu13cr2V0JrlFq96cmU7rWD6gC+USwkvVLT8DW9BV1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu; spf=pass smtp.mailfrom=csgroup.eu; arc=none smtp.client-ip=93.17.235.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=csgroup.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=csgroup.eu Received: from localhost (mailhub4.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4cX0Z81XR9z9sVT; Wed, 24 Sep 2025 17:07:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7JBvIGokpC-x; Wed, 24 Sep 2025 17:07:12 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4cX0Z80gXXz9sVR; Wed, 24 Sep 2025 17:07:12 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 05FB98B768; Wed, 24 Sep 2025 17:07:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id EeCTNJu2vLct; Wed, 24 Sep 2025 17:07:11 +0200 (CEST) Received: from PO20335.idsi0.si.c-s.fr (unknown [192.168.235.99]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B2BF38B763; Wed, 24 Sep 2025 17:07:10 +0200 (CEST) From: Christophe Leroy To: Herve Codina , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Christophe Leroy , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3] net: wan: framer: Add version sysfs attribute for the Lantiq PEF2256 framer Date: Wed, 24 Sep 2025 17:06:47 +0200 Message-ID: <77a27941d6924b1009df0162ed9f0fa07ed6e431.1758726302.git.christophe.leroy@csgroup.eu> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1758726407; l=3835; i=christophe.leroy@csgroup.eu; s=20211009; h=from:subject:message-id; bh=NUgMFd1DP4iApIqk7SLIwHxdIBK3tE7nt9mFkQcSPH8=; b=w2Ex0uy0q9ZKCt7WkNFVTS7mpr1zxnBazlqSSHvD8KPCMlDk4Jkifqjn/R+uhGXp0s2AR9gEG ZiNdUB3EIQ0BCHEchCO7TeGUgJUg8EkPDlUkcTQ0bC+r4VTK2VWpdHC X-Developer-Key: i=christophe.leroy@csgroup.eu; a=ed25519; pk=HIzTzUj91asvincQGOFx6+ZF5AoUuP9GdOtQChs7Mm0= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Lantiq PEF2256 framer has some little differences in behaviour depending on its version. Add a sysfs attribute to allow user applications to know the version. Signed-off-by: Christophe Leroy Acked-by: Herve Codina --- v3: - Added documentation Documentation/ABI/testing/sysfs-driver-framer-pef2256 v2: https://lore.kernel.org/all/2e01f4ed00d0c1475863ffa30bdc2503f330b688.17= 58089951.git.christophe.leroy@csgroup.eu - Split version_show() prototype to 80 chars - Make DEVICE_ATTR_RO(version) static v1: https://lore.kernel.org/all/f9aaa89946f1417dc0a5e852702410453e816dbc.17= 57754689.git.christophe.leroy@csgroup.eu/ --- .../ABI/testing/sysfs-driver-framer-pef2256 | 8 +++++++ drivers/net/wan/framer/pef2256/pef2256.c | 24 +++++++++++++++---- 2 files changed, 27 insertions(+), 5 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-driver-framer-pef2256 diff --git a/Documentation/ABI/testing/sysfs-driver-framer-pef2256 b/Docume= ntation/ABI/testing/sysfs-driver-framer-pef2256 new file mode 100644 index 000000000000..ead1ae84ef2a --- /dev/null +++ b/Documentation/ABI/testing/sysfs-driver-framer-pef2256 @@ -0,0 +1,8 @@ +What: /sys/bus/platform/devices/xxx/version +Date: Sep 2025 +Contact: netdev@vger.kernel.org +Description: Reports the version of the PEF2256 framer + + Access: Read + + Valid values: Represented as string diff --git a/drivers/net/wan/framer/pef2256/pef2256.c b/drivers/net/wan/fra= mer/pef2256/pef2256.c index 1e4c8e85d598..a2166b424428 100644 --- a/drivers/net/wan/framer/pef2256/pef2256.c +++ b/drivers/net/wan/framer/pef2256/pef2256.c @@ -37,6 +37,7 @@ struct pef2256 { struct device *dev; struct regmap *regmap; enum pef2256_version version; + const char *version_txt; struct clk *mclk; struct clk *sclkr; struct clk *sclkx; @@ -114,6 +115,16 @@ enum pef2256_version pef2256_get_version(struct pef225= 6 *pef2256) } EXPORT_SYMBOL_GPL(pef2256_get_version); =20 +static ssize_t version_show(struct device *dev, struct device_attribute *a= ttr, + char *buf) +{ + struct pef2256 *pef2256 =3D dev_get_drvdata(dev); + + return sysfs_emit(buf, "%s\n", pef2256->version_txt); +} + +static DEVICE_ATTR_RO(version); + enum pef2256_gcm_config_item { PEF2256_GCM_CONFIG_1544000 =3D 0, PEF2256_GCM_CONFIG_2048000, @@ -697,7 +708,6 @@ static int pef2256_probe(struct platform_device *pdev) unsigned long sclkr_rate, sclkx_rate; struct framer_provider *framer_provider; struct pef2256 *pef2256; - const char *version_txt; void __iomem *iomem; int ret; int irq; @@ -763,18 +773,18 @@ static int pef2256_probe(struct platform_device *pdev) pef2256->version =3D pef2256_get_version(pef2256); switch (pef2256->version) { case PEF2256_VERSION_1_2: - version_txt =3D "1.2"; + pef2256->version_txt =3D "1.2"; break; case PEF2256_VERSION_2_1: - version_txt =3D "2.1"; + pef2256->version_txt =3D "2.1"; break; case PEF2256_VERSION_2_2: - version_txt =3D "2.2"; + pef2256->version_txt =3D "2.2"; break; default: return -ENODEV; } - dev_info(pef2256->dev, "Version %s detected\n", version_txt); + dev_info(pef2256->dev, "Version %s detected\n", pef2256->version_txt); =20 ret =3D pef2556_of_parse(pef2256, np); if (ret) @@ -835,6 +845,8 @@ static int pef2256_probe(struct platform_device *pdev) return ret; } =20 + device_create_file(pef2256->dev, &dev_attr_version); + return 0; } =20 @@ -849,6 +861,8 @@ static void pef2256_remove(struct platform_device *pdev) pef2256_write8(pef2256, PEF2256_IMR3, 0xff); pef2256_write8(pef2256, PEF2256_IMR4, 0xff); pef2256_write8(pef2256, PEF2256_IMR5, 0xff); + + device_remove_file(pef2256->dev, &dev_attr_version); } =20 static const struct of_device_id pef2256_id_table[] =3D { --=20 2.49.0