From nobody Fri Apr 3 19:09:35 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE9943148D9 for ; Mon, 23 Mar 2026 19:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292489; cv=none; b=vAHlVOhKPDUZulu063fMjgAgaw8YTLOGqA41BDlsmdj4QJ4aOXaU3FtdF3M0lCOQ691sIYfH25YuzunTKDo3B+ywLyWyLSs875Cj+SkUTxVtYfPuymBlk1QyHGieeHatKFSyOKSoYRGZypPYCT2cpnsV3ZKU+r4fHx0m6oYLEik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774292489; c=relaxed/simple; bh=kIkQ3M6MU6ffdc+UMu8eQEns2WLf8THRIkoxJZ1wwWc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rqhyoyvSD+rnccQVlNogEPqkJPTWi9ark6H7c+Wvv1b4dkdvA+Bha2LW1dXz1SDfpcHed1fdmR56QYGzlJYNgTzLnNKjcoXlyPV0A91ukcRE4wSLTISqUdfWSqWp8ihnZ8DWswDgFzX5acknfIzm9ruqe0Tg4gXoWk3Nn7YTLbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RdWDjuPG; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RdWDjuPG" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-43b3f91a7abso342310f8f.1 for ; Mon, 23 Mar 2026 12:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774292486; x=1774897286; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MHuRsDVkQUUGFXQRrZ4RkpmncGpGmYSyMNCrKIAVWFs=; b=RdWDjuPGYWu7xTAdZ0Di3v8bO9qpTJkejEU/ttzbhIxCjB5Bg9jmBZ0Y9UO6kAn5M8 fzsApKjiehVe8UceOL/7jvfECqlG9NajTDd+vE7NlOysqbIRsUb6NPP6dGDWuZPjdYI0 9Iz+nXnrv5BfRnqVzBZEvfmUKkrL3B7NntXegxeSnowYrqqagEHIi0ipJPCnrWDDYa3w c2f6g467G5BOy7P1TDb+t7TS6ZH5o/6CLPDr7CD+nzB2b6HofYnPkNTgQZe3bYErKLc3 0tGfGrPFpAotvJ24x+jJULrqJJqSfJz5cgqn58RK3+um1jwrMqJHR4GLhQ/PJfjD5txg JlDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774292486; x=1774897286; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MHuRsDVkQUUGFXQRrZ4RkpmncGpGmYSyMNCrKIAVWFs=; b=cTzyFkZPM5c2AO8q3Q5dEBCv4PgaksCZQvN9nf/dd/W+UNcbBk1ned58KFV0vs4mzW zIAQSc2CHQDfTNTE91AyFYT8KYYItumBMZ9TiNBWzit5Daj8uyGtWfmt/MGoj4Pdp+GF itBYqGKHYJvtGg8lpQA9REp1L4I03sGZA7A+YoGbB5dkXrAbqkql14EW5C1yRxSAENyT RbynLA315ZmbPYSbO7cHcWUObSh320SWY/KyMad4tVKWLEF/n+VDIJjEjxrbF9taj/A6 8aFeejKj40Aeqw/eouZKd1IaHtIQFReb6Jr94eE/etkRRb3IZxxiJVOpErF85GUKR6yf pB4Q== X-Forwarded-Encrypted: i=1; AJvYcCVTyUQlGf7Ewf3DzlksoLWSwTBV02o9qNXRg8EAeGDXIVDEybD0h2OhhI1Q/fu0dMk0lDQI7zWp+Pd1Epo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy45J3x8C7K3dV41sIUsp4SPgXZMe6FrlGdYimAnT5J/DFRxj1I 1SIyexxvBYy+Nmnsi163gpIJXd4BgGGUaX05F8xiL8W2LS9qtoeVzgsPeWQCRv/Y/cQ= X-Gm-Gg: ATEYQzyCDGsqm39h+fUd7nVlM4ZJgH4Lxj57ksWY5w+7+lHCMlM9MZw6IbQaClW4CEs w1EDJWsmPZ4LzGGDMgG8ncZRqOljxQuGWyVCY3QZGL0tppLpW0jQDK63KLv5c95JfL+dqxodCI7 7DpsEDgcatUPrt19Qw/qdCwyvauzQ5+iKHGPwHXvwzLK3AlRAJ3DgHR1mXL+2+NahVhkMsGCHVP RBoV278guxf21Ts1II17IfBspnSnpraBuzl48KjHrTro/ltq+Byok+AaKfQyrsx9oj+42jsC5QI WgqVvigWrfmLGXCdpFIdu3ub22EwBf0BhCPlsBIP8CT6k5ht9X1rlyW0ZySW6l2zBJKL5AjM6Mm Ly7TbS3J7wmbHEXbkjcPua/pg7jzHluvSpzEWBlXck9ydrzPEEME5kQpzLZhMlNnRmf/x40K+js 94L95uEdv9a1hinFIXBBkgPlkJ02T4 X-Received: by 2002:a05:600c:5248:b0:485:3a27:a961 with SMTP id 5b1f17b1804b1-486feb5d845mr199608445e9.0.1774292486005; Mon, 23 Mar 2026 12:01:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64714decsm28604894f8f.31.2026.03.23.12.01.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 12:01:25 -0700 (PDT) Date: Mon, 23 Mar 2026 22:01:22 +0300 From: Dan Carpenter To: Sudeep Holla , AKASHI Takahiro Cc: Cristian Marussi , Linus Walleij , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Bartosz Golaszewski , Vincent Guittot , Khaled Ali Ahmed , Michal Simek Subject: [PATCH v6 4/7] pinctrl: scmi: ignore PIN_CONFIG_PERSIST_STATE Message-ID: <77357ddd5c96622e4be77c0b209206d5a59c9b05.1774283146.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The PIN_CONFIG_PERSIST_STATE setting ensures that the pin state persists across a sleep or controller reset. The SCMI spec does not have an equivalent command to this so just ignore it. Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij --- v5: fix subsystem prefix v4: Add r-b tags v3: No change drivers/pinctrl/pinctrl-scmi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c index de8c113bc61d..f22be6b7b82a 100644 --- a/drivers/pinctrl/pinctrl-scmi.c +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -361,7 +361,7 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_dev = *pctldev, unsigned long *configs, unsigned int num_configs) { - int i, ret; + int i, cnt, ret; struct scmi_pinctrl *pmx =3D pinctrl_dev_get_drvdata(pctldev); enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; u32 config_value[SCMI_NUM_CONFIGS]; @@ -377,17 +377,21 @@ static int pinctrl_scmi_pinconf_set(struct pinctrl_de= v *pctldev, if (ret) return ret; =20 + cnt =3D 0; for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); - ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[i]); + if (param =3D=3D PIN_CONFIG_PERSIST_STATE) + continue; + ret =3D pinctrl_scmi_map_pinconf_type_set(param, &p_config_type[cnt]); if (ret) { dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); goto free_config; } - p_config_value[i] =3D pinconf_to_config_argument(configs[i]); + p_config_value[cnt] =3D pinconf_to_config_argument(configs[i]); + cnt++; } =20 - ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + ret =3D pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, cnt, p_config_type, p_config_value); if (ret) dev_err(pmx->dev, "Error parsing config %d\n", ret); --=20 2.53.0