From nobody Sat Feb 7 13:05:35 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50354466B46; Tue, 20 Jan 2026 19:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937726; cv=none; b=FpFKNxYyPRFu4iTShv6i+nTSU5vXNCxR+g/eN7zYMjfSr1UobkV5s6TuCHlsd+vZ5KhG4bvYCCQV0OOJ1CC+5rFiTJFvGeeNNwuf7vMSHkiACHTNpHYySShx982CApMN7h8/WDCLCf5Ym+NBO+q2GsAH+44rHNwlGy2h2J25q7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768937726; c=relaxed/simple; bh=/A4LHTEaDLHlh1euWJRWHRa4K1G1d6F3Yldk56r6Vwo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CLbyIRzbwYyN6M0PVW5sr0qzOSP+aLDiwiSTKnANadLll9iDCz85goxvmtM23t2RTIQpS8zDH0251w+8gXcfrwUrfcZ0Bb8d9ayuKwVRLn3fABSWFndjsWiiK1gzEojT/2VwfhbQiJbsQQzHa54cV8Ayejn0L9bz1fweZ5GpJa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=HEkB8hj9; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="HEkB8hj9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1768937718; bh=/A4LHTEaDLHlh1euWJRWHRa4K1G1d6F3Yldk56r6Vwo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HEkB8hj9p8LUeEVWO84jAA1w6imq8/lvcrblLSPIsSdVFuaWpCQFeyddLMEHKlbHd egJd9Dj+j0cp3z6GZ5iTIo2xsxPkXvsbNtrrTr4VxtSDty3h+qxFllrmSYUXemBKRH SdM1+l/XaBTa0a/6JWOcSuTmrsHDbFJBpogFOLbNw0DHNntMl/BKh325pTHNQqE0CT J7VIGf1cE80Xck61pu20DlmoemnH7EvVMGDpV0s2gGAka8NRnBApD8E4I6oKW82YjE DNHOFWvze6eVrxkEFl3jHua9Y4e8PTuh1cgMRaOEC7S/wYFJOg85CsZ1CG5NH9R4/1 Wcog+W21XTcMg== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id DAA5817E0FDB; Tue, 20 Jan 2026 20:35:17 +0100 (CET) Message-ID: <7722373a-b491-4aaa-9527-a8f091cf22fe@collabora.com> Date: Tue, 20 Jan 2026 20:35:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: fixup! media: synopsys: add driver for the designware mipi csi-2 receiver To: Chaoyi Chen , Kever Yang , Frank Li , Mehdi Djait , Bryan O'Donoghue , Laurent Pinchart , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Sebastian Reichel , Nicolas Dufresne , Collabora Kernel Team , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20251114-rockchip-mipi-receiver-v8-0-bd1cf5cb9588@collabora.com> <20251114-rockchip-mipi-receiver-v8-2-bd1cf5cb9588@collabora.com> Content-Language: en-US From: Michael Riesch In-Reply-To: <20251114-rockchip-mipi-receiver-v8-2-bd1cf5cb9588@collabora.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make smatch happy by adding braces around the initialization in switch cases. Signed-off-by: Michael Riesch --- @Sakari could you try the following patch? I think this should solve the issues with smatch/sparse you mentioned off-list. drivers/media/platform/synopsys/dw-mipi-csi2rx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c index 29119a1a8d38..dc82223e312a 100644 --- a/drivers/media/platform/synopsys/dw-mipi-csi2rx.c +++ b/drivers/media/platform/synopsys/dw-mipi-csi2rx.c @@ -236,7 +236,7 @@ static int dw_mipi_csi2rx_start(struct dw_mipi_csi2rx_device *csi2) return link_freq; switch (csi2->bus_type) { - case V4L2_MBUS_CSI2_DPHY: + case V4L2_MBUS_CSI2_DPHY: { struct phy_configure_opts_mipi_dphy *cfg =3D &opts.mipi_dph= y; ret =3D phy_mipi_dphy_get_default_config_for_hsclk(link_freq * 2, @@ -254,7 +254,7 @@ static int dw_mipi_csi2rx_start(struct dw_mipi_csi2rx_device *csi2) control |=3D SW_CPHY_EN(0); break; - + } case V4L2_MBUS_CSI2_CPHY: /* TODO: implement CPHY configuration */ return -EOPNOTSUPP; @@ -293,7 +293,7 @@ dw_mipi_csi2rx_enum_mbus_code(struct v4l2_subdev *sd, struct dw_mipi_csi2rx_device *csi2 =3D to_csi2(sd); switch (code->pad) { - case DW_MIPI_CSI2RX_PAD_SRC: + case DW_MIPI_CSI2RX_PAD_SRC: { const struct v4l2_mbus_framefmt *sink_fmt; if (code->index) @@ -304,6 +304,7 @@ dw_mipi_csi2rx_enum_mbus_code(struct v4l2_subdev *sd, code->code =3D sink_fmt->code; return 0; + } case DW_MIPI_CSI2RX_PAD_SINK: if (code->index > csi2->formats_num) return -EINVAL; --=20 2.39.5