From nobody Fri Dec 19 11:15:58 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E07E073465 for ; Mon, 18 Dec 2023 21:05:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFKnr-0002lQ-0x; Mon, 18 Dec 2023 22:05:31 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFKnq-00GmX0-KU; Mon, 18 Dec 2023 22:05:30 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rFKnq-005Y6F-BZ; Mon, 18 Dec 2023 22:05:30 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Sudip Mukherjee Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] parport: amiga: Convert to platform remove callback returning void Date: Mon, 18 Dec 2023 22:05:18 +0100 Message-ID: <75b3b8f498d6079c974bd47c763c589b9d2c00f6.1702933181.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1802; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Gq/nWyE6d9ZldFyO+uVIZpTO25j9ER5SvPErnqrRnYI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlgLQN+lLmr5Slm5czjFdtTKrQMInsOAKAzUXc+ vZvRZZc6cqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYC0DQAKCRCPgPtYfRL+ TuCwB/0fpNXLrtKUtEaW1otT3V+Fw0O22vWNi78kkuucllgj9JCtEFoNNl0jPQVsFus3LUnHQrF W9NhbqdSjHBgDfJnWSun4ygXr1g4vvLhn+cwKqKRrHEP3wHlogtrM5+smoI5E/KFHVs10U3oXf7 6vB0EZXYq4wGw5I7Idnj21lJLmhuXECiFOut8HzPc3FZgB8BZJuHWAtVdZb/54r1JLQTZuE7xTA FSL9Nyo13sZA/yVq9rNqyiFCstdAQEOfOwTjwlZ2ZuJcfNApARu2f7h6tWsrROkUoqmHTz7gYI3 wvUneS4QrGph7Ovz9vYMIwJreM0sslARcVznLoO+E8NEk3AD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/parport/parport_amiga.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/parport/parport_amiga.c b/drivers/parport/parport_amig= a.c index 84d5701d606c..e6dc857aac3f 100644 --- a/drivers/parport/parport_amiga.c +++ b/drivers/parport/parport_amiga.c @@ -219,7 +219,7 @@ static int __init amiga_parallel_probe(struct platform_= device *pdev) return err; } =20 -static int __exit amiga_parallel_remove(struct platform_device *pdev) +static void __exit amiga_parallel_remove(struct platform_device *pdev) { struct parport *port =3D platform_get_drvdata(pdev); =20 @@ -227,11 +227,10 @@ static int __exit amiga_parallel_remove(struct platfo= rm_device *pdev) if (port->irq !=3D PARPORT_IRQ_NONE) free_irq(IRQ_AMIGA_CIAA_FLG, port); parport_put_port(port); - return 0; } =20 static struct platform_driver amiga_parallel_driver =3D { - .remove =3D __exit_p(amiga_parallel_remove), + .remove_new =3D __exit_p(amiga_parallel_remove), .driver =3D { .name =3D "amiga-parallel", }, --=20 2.42.0