From nobody Fri Dec 19 19:09:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7920E8FDD1 for ; Wed, 4 Oct 2023 07:29:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241521AbjJDH3j convert rfc822-to-8bit (ORCPT ); Wed, 4 Oct 2023 03:29:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241513AbjJDH3i (ORCPT ); Wed, 4 Oct 2023 03:29:38 -0400 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E3C98; Wed, 4 Oct 2023 00:29:30 -0700 (PDT) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3947SmKhA3077984, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.92/5.92) with ESMTPS id 3947SmKhA3077984 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Oct 2023 15:28:48 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Wed, 4 Oct 2023 15:28:47 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 4 Oct 2023 15:28:45 +0800 Received: from RTEXMBS03.realtek.com.tw ([fe80::5510:ad08:5390:1ed3]) by RTEXMBS03.realtek.com.tw ([fe80::5510:ad08:5390:1ed3%2]) with mapi id 15.01.2375.007; Wed, 4 Oct 2023 15:28:45 +0800 From: Max Chou To: "Kirill A. Shutemov" CC: Bagas Sanjaya , Hilda Wu , "alex_lu@realsil.com.cn" , Luiz Augusto von Dentz , Marcel Holtmann , "Johan Hedberg" , Juerg Haefliger , Linux Bluetooth , Thorsten Leemhuis , Linux Regressions , Linux Kernel Mailing List Subject: RE: Regression: devcoredump patch broke Realtek usb bluetooth adapter Thread-Topic: Regression: devcoredump patch broke Realtek usb bluetooth adapter Thread-Index: AQHZ9iZZqIk9cnxrEkOIPrwHFnXgfLA4N/0AgAA1ZDCAABycgIAAkrXQgAAclfA= Date: Wed, 4 Oct 2023 07:28:45 +0000 Message-ID: <7507ad6c8a964b179bf2b3318104a124@realtek.com> References: <20231003182038.k57nirtt4sonvt7c@box.shutemov.name> <20231004044947.vgegwvxxindkjo7g@box.shutemov.name> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.132.197] x-kse-serverinfo: RTEXMBS05.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Hi! Kirill, I guess the root cause is as below. =3D=3D=3D static int btrtl_register_devcoredump_support(struct hci_dev *hdev) { int err; err =3D hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NUL= L); return err; } =3D=3D=3D If CONFIG_DEV_COREDUMP is not enabled, it would return -EOPNOTSUPP for hci_= devcd_register(). Unfortunately, btrtl_register_devcoredump_support() will return it.=20 Finally, -EOPNOSTUPP will be returned for btrtl_setup_realtek(). Could you have the following workaround for the root cause checked? Please share dmesg as well. Thanks, =3D=3D=3D --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -967,8 +967,9 @@ static int btrtl_register_devcoredump_support(struct hc= i_dev *hdev) int err; err =3D hci_devcd_register(hdev, btrtl_coredump, btrtl_dmp_hdr, NUL= L); + rtl_dev_info(hdev, "%s(): err =3D %d", __func__, err); - return err; + return 0; } void btrtl_set_driver_name(struct hci_dev *hdev, const char *driver_name) =3D=3D=3D BRs, Max > -----Original Message----- > From: Max Chou > Sent: Wednesday, October 4, 2023 1:45 PM > To: 'Kirill A. Shutemov' > Cc: Bagas Sanjaya ; Hilda Wu > ; alex_lu@realsil.com.cn; Luiz Augusto von Dentz > ; Marcel Holtmann ; > Johan Hedberg ; Juerg Haefliger > ; Linux Bluetooth > ; Thorsten Leemhuis ; > Linux Regressions ; Linux Kernel Mailing List > > Subject: RE: Regression: devcoredump patch broke Realtek usb bluetooth > adapter >=20 > Hi! Kirill, > As your mentions, there's not obvious wrong from the dmesg. > Could you capture btmon log with raw data? (btmon -w xxx.log) In addition= al, > did you build the last version of bluetooth-next? > By my understanding, you can just duplicate the issue by the commit > "044014ce85a1 Bluetooth: btrtl: Add Realtek devcoredump support"? > Unfortunately, I can not duplicate this issue sofar. >=20 >=20 > BRs, > Max >=20 >=20 > > -----Original Message----- > > From: Kirill A. Shutemov > > Sent: Wednesday, October 4, 2023 12:50 PM > > To: Max Chou > > Cc: Bagas Sanjaya ; Hilda Wu > > ; alex_lu@realsil.com.cn; Luiz Augusto von Dentz > > ; Marcel Holtmann ; > > Johan Hedberg ; Juerg Haefliger > > ; Linux Bluetooth > > ; Thorsten Leemhuis > > ; Linux Regressions > > ; Linux Kernel Mailing List > > > > Subject: Re: Regression: devcoredump patch broke Realtek usb bluetooth > > adapter > > > > > > External mail. > > > > > > > > On Wed, Oct 04, 2023 at 03:07:24AM +0000, Max Chou wrote: > > > Hi! Kirill, > > > I based on Kernel v6.5.5 and updated drivers/bluetooth to the last > > > version of > > bluetooth-next tree for a test with RTL8761BUV. > > > The dmesg log and "hciconfig -a" are correct. > > > Could you share the dmesg for your failure case? > > > > > > [56133.563293] usb 3-1: new full-speed USB device number 28 using > > > xhci_hcd [56133.712559] usb 3-1: New USB device found, > > > idVendor=3D0bda, idProduct=3D8771, bcdDevice=3D 2.00 [56133.712577] u= sb > > > 3-1: New USB device > > > strings: Mfr=3D1, Product=3D2, SerialNumber=3D3 [56133.712582] usb 3-= 1: > > > Product: Bluetooth Radio [56133.712585] usb 3-1: Manufacturer: > > > Realtek [56133.712588] usb 3-1: SerialNumber: 00E04C239987 > > > [56133.737812] > > > usbcore: registered new interface driver btusb [56133.742126] > > > Bluetooth: hci0: RTL: examining hci_ver=3D0a hci_rev=3D000b lmp_ver= =3D0a > > > lmp_subver=3D8761 [56133.743115] Bluetooth: hci0: RTL: rom_version > > > status=3D0 version=3D1 [56133.743124] Bluetooth: hci0: RTL: loading > > > rtl_bt/rtl8761bu_fw.bin [56133.743754] Bluetooth: hci0: RTL: loading > > > rtl_bt/rtl8761bu_config.bin [56133.743829] Bluetooth: hci0: RTL: > > > cfg_sz 6, total sz 30210 [56133.913311] Bluetooth: hci0: RTL: fw > > > version 0xdfc6d922 [56133.980299] Bluetooth: MGMT ver 1.22 > > > > > > hci0: Type: Primary Bus: USB > > > BD Address: 98:A2:35:85:56:F1 ACL MTU: 1021:6 SCO MTU: > > 255:12 > > > UP RUNNING > > > RX bytes:1670 acl:0 sco:0 events:184 errors:0 > > > TX bytes:33917 acl:0 sco:0 commands:184 errors:0 > > > Features: 0xff 0xff 0xff 0xfe 0xdb 0xfd 0x7b 0x87 > > > Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3 > > > Link policy: RSWITCH HOLD SNIFF PARK > > > Link mode: PERIPHERAL ACCEPT > > > Name: 'max-ThinkPad-X230' > > > Class: 0x6c010c > > > Service Classes: Rendering, Capturing, Audio, Telephony > > > Device Class: Computer, Laptop > > > HCI Version: 5.1 (0xa) Revision: 0xdfc6 > > > LMP Version: 5.1 (0xa) Subversion: 0xd922 > > > Manufacturer: Realtek Semiconductor Corporation (93) > > > > I don't see anything obviously wrong in dmesg. Attached hciconfig and > > dmesg for both functional and broken cases. > > > > -- > > Kiryl Shutsemau / Kirill A. Shutemov