From nobody Sun Feb 8 23:31:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECE6C83F2D for ; Sun, 3 Sep 2023 12:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237162AbjICMl5 (ORCPT ); Sun, 3 Sep 2023 08:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbjICMl4 (ORCPT ); Sun, 3 Sep 2023 08:41:56 -0400 Received: from smtp.smtpout.orange.fr (smtp-17.smtpout.orange.fr [80.12.242.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D93B123 for ; Sun, 3 Sep 2023 05:41:52 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id cmQEqRX1vhaW6cmQEq3SIb; Sun, 03 Sep 2023 14:41:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1693744910; bh=PHniSO2zYUYgC/x8zH3jPDQE+1EC8XtwBC0f5Q2U7xI=; h=From:To:Cc:Subject:Date; b=p3cOoNSTCEea5D5oUBy6qdvbEiqZFrWMjMElRRmZoMrmpAH4hBl2M8hACnmdhqJ1i EyCgf1nubhvpvq8HCStgz6nhrJ46QIxGmTJEQmbJfozESIV2/yenVMQxiPmpqLnRpj PlxRM3AyqRlwAJyihfsYOvfZsbjQhcWuE7fs3KqTRvGjKFNEJz2VMwNqCbt28PZspL As87C0CVcy08dt5rfQ77esx7au0YZbXMUtAmJW7NaeuKfc7f/wIP5CEu6bBn+YXVZM CGxdk1/HBxGPwRSVWbIMvxjpTyvFGS+kv6fnQqZQ7lWsBhs4wA6qCVnG1LMEmwVwDw OSJT2CuRgTevg== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 03 Sep 2023 14:41:50 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: "Geoffrey D. Bennett" , Jaroslav Kysela , Takashi Iwai Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Takashi Iwai , alsa-devel@alsa-project.org Subject: [PATCH] ALSA: scarlett2: Fix a potential memory leak in scarlett2_init_notify() Date: Sun, 3 Sep 2023 14:41:45 +0200 Message-Id: <73aab53d53df156a5df2bc61314ff26448526749.1693744859.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If kmalloc() fails, we should release 'mixer->urb'. Fixes: 9e4d5c1be21f ("ALSA: usb-audio: Scarlett Gen 2 mixer interface") Signed-off-by: Christophe JAILLET --- sound/usb/mixer_scarlett_gen2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen= 2.c index 9d11bb08667e..a439c7f64b2e 100644 --- a/sound/usb/mixer_scarlett_gen2.c +++ b/sound/usb/mixer_scarlett_gen2.c @@ -4060,8 +4060,10 @@ static int scarlett2_init_notify(struct usb_mixer_in= terface *mixer) return -ENOMEM; =20 transfer_buffer =3D kmalloc(private->wMaxPacketSize, GFP_KERNEL); - if (!transfer_buffer) + if (!transfer_buffer) { + usb_free_urb(mixer->urb); return -ENOMEM; + } =20 usb_fill_int_urb(mixer->urb, dev, pipe, transfer_buffer, private->wMaxPacketSize, --=20 2.34.1