From nobody Sat Feb 7 19:41:10 2026 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A516A223323 for ; Sun, 18 Jan 2026 16:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768754463; cv=none; b=fx7XDock4AUbi89I0p6gaZ49zJG1kEJ5P+WLpZrAhgcb9nAOAs/+OYznup6Pf0j8SklKfGv/2vRP15VhYppXGQX5s/rxRqpwwqFMDKHGq0ou4BktHYzdhJf6k43fecyYsptaDmkCOI1PKkMzcGOorgOO1nRoyzDEi5y4Hs74iYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768754463; c=relaxed/simple; bh=WShuIAPyE68nfy0UjiL2DWEKFe79X2KK4RQCP1VjDNE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gDDUdmwySAaxNeRhtRYLKHqORA1159AF70MRVC1AYuq7/aDvtg3OUk13VrhW58xqYuA7l3mQehouQjrw2XIt7/KihvQwy4lrew5OgoOD6eOgIHhhIMuaqhXdgAA4BTdkkpzYoiLP2Xe0JQiY2CAA60YW6X+avQv9nr0f4Fbs5T8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XDxqmXnC; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XDxqmXnC" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768754459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T65OoKpCdEFFVP2+DiaAhKdFuag7lvxT1ZvELnGzBuM=; b=XDxqmXnCuH/JRYGM1O3YmnQvJdD5IkHuTPYgNlZTIrKzbgTF/xsrUKLNxn8n7pCsP1e0Ez GyWIZbQ1PoS7Q57MIkuqHH6ZzKB27QVPrt839tIYcBWFa9Qo5Fp+XnhqJ8Wn05PLWjKRTj 1t5+vc2JSaUkIOkbrk1su7vOrIuY01U= From: wen.yang@linux.dev To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , Jason Xing , Paolo Abeni , Wen Yang Subject: [PATCH 6.1 1/3] net: napi_schedule_rps() cleanup Date: Mon, 19 Jan 2026 00:40:31 +0800 Message-Id: <72f1345baff9fe5a296915d4b5a7a18bd304df68.1768754220.git.wen.yang@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Eric Dumazet commit 8fcb76b934daff12cde76adeab3d502eeb0734b1 upstream. napi_schedule_rps() return value is ignored, remove it. Change the comment to clarify the intent. Signed-off-by: Eric Dumazet Reviewed-by: Jason Xing Tested-by: Jason Xing Signed-off-by: Paolo Abeni Signed-off-by: Wen Yang --- net/core/dev.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 114fc8bc37f8..e35f41e75bdd 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4684,11 +4684,18 @@ static void trigger_rx_softirq(void *data) } =20 /* - * Check if this softnet_data structure is another cpu one - * If yes, queue it to our IPI list and return 1 - * If no, return 0 + * After we queued a packet into sd->input_pkt_queue, + * we need to make sure this queue is serviced soon. + * + * - If this is another cpu queue, link it to our rps_ipi_list, + * and make sure we will process rps_ipi_list from net_rx_action(). + * As we do not know yet if we are called from net_rx_action(), + * we have to raise NET_RX_SOFTIRQ. This might change in the future. + * + * - If this is our own queue, NAPI schedule our backlog. + * Note that this also raises NET_RX_SOFTIRQ. */ -static int napi_schedule_rps(struct softnet_data *sd) +static void napi_schedule_rps(struct softnet_data *sd) { struct softnet_data *mysd =3D this_cpu_ptr(&softnet_data); =20 @@ -4698,11 +4705,10 @@ static int napi_schedule_rps(struct softnet_data *s= d) mysd->rps_ipi_list =3D sd; =20 __raise_softirq_irqoff(NET_RX_SOFTIRQ); - return 1; + return; } #endif /* CONFIG_RPS */ __napi_schedule_irqoff(&mysd->backlog); - return 0; } =20 #ifdef CONFIG_NET_FLOW_LIMIT --=20 2.25.1