From nobody Mon Apr 13 12:01:51 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64D86C00140 for ; Fri, 12 Aug 2022 14:32:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238360AbiHLOcB (ORCPT ); Fri, 12 Aug 2022 10:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237689AbiHLOcA (ORCPT ); Fri, 12 Aug 2022 10:32:00 -0400 Received: from 7of9.schinagl.nl (7of9.connected.by.freedominter.net [185.238.129.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 146CC1CB10; Fri, 12 Aug 2022 07:31:58 -0700 (PDT) Received: from [10.2.12.24] (unknown [10.2.12.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by 7of9.schinagl.nl (Postfix) with ESMTPSA id 8257118639E5; Fri, 12 Aug 2022 16:31:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=schinagl.nl; s=7of9; t=1660314715; bh=D6RB9U1iKUoe2tUrXz01h0DPHQCF1eWpqhyWVKhnHA4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=P+n1Gnhl5UkCsJv6vHQRKHEZ91RhLOSySaxtS5GJTBk4v4M5baXPKsFDK9OA21+NU aL0Aa/w5UHpDdLMJ1sZ/Jo0C5iyMkb9/Yj/10rF+1jWO93hQbwoksKGLzvY2/wvTQS 86DHZ9ZluQ0BjbSRI9rWzTk/ofqIoLa1VEnxquBg= Message-ID: <6ec9eaa1-2bc2-a32f-6685-4a2a645a5a59@schinagl.nl> Date: Fri, 12 Aug 2022 16:31:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v2] dt-bindings: leds: Expand LED_COLOR_ID definitions Content-Language: nl To: Rob Herring , Krzysztof Kozlowski Cc: Jacek Anaszewski , Baolin Wang , Daniel Mack , Linus Walleij , Oleh Kravchenko , Sakari Ailus , Simon Shields , Olliver Schinagl , devicetree@vger.kernel.org, linux-kernel References: <7c688821-140b-4b05-651b-337f602dc1fe@schinagl.nl> From: Olliver Schinagl In-Reply-To: <7c688821-140b-4b05-651b-337f602dc1fe@schinagl.nl> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In commit 853a78a7d6c7 (dt-bindings: leds: Add LED_COLOR_ID definitions, Sun Jun 9 20:19:04 2019 +0200) the most basic color definitions where added. However, there's a little more very common LED colors. While the documentation states 'add what is missing', engineers tend to be lazy and will just use what currently exists. So this patch will take (a) list from online retailers [0], [1], [2] and use the common LED=20 colors from there, this being reasonable as this is what is currently available to=20 purchase. Note, that LIME seems to be the modern take to 'Yellow-green' or 'Yellowish-green' from some older datasheets. [0]: https://www.digikey.com/en/products/filter/led-lighting-color/125 [1]:=20 https://eu.mouser.com/c/optoelectronics/led-lighting/led-emitters/standard-= leds-smd [2]:=20 https://nl.farnell.com/en-NL/c/optoelectronics-displays/led-products/standa= rd-single-colour-leds-under-75ma Signed-off-by: Olliver Schinagl --- Changes since v1: Unbreak existing definitions. =C2=A0include/dt-bindings/leds/common.h | 28 ++++++++++++++++------------ =C2=A01 file changed, 16 insertions(+), 12 deletions(-) diff --git a/include/dt-bindings/leds/common.h=20 b/include/dt-bindings/leds/common.h index 3be89a7c20a9..04bf94523ea3 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -22,18 +22,22 @@ =C2=A0#define LEDS_BOOST_FIXED=C2=A0=C2=A0=C2=A0 2 =C2=A0/* Standard LED colors */ -#define LED_COLOR_ID_WHITE=C2=A0=C2=A0=C2=A0 0 -#define LED_COLOR_ID_RED=C2=A0=C2=A0=C2=A0 1 -#define LED_COLOR_ID_GREEN=C2=A0=C2=A0=C2=A0 2 -#define LED_COLOR_ID_BLUE=C2=A0=C2=A0=C2=A0 3 -#define LED_COLOR_ID_AMBER=C2=A0=C2=A0=C2=A0 4 -#define LED_COLOR_ID_VIOLET=C2=A0=C2=A0=C2=A0 5 -#define LED_COLOR_ID_YELLOW=C2=A0=C2=A0=C2=A0 6 -#define LED_COLOR_ID_IR=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 7 -#define LED_COLOR_ID_MULTI=C2=A0=C2=A0=C2=A0 8=C2=A0=C2=A0=C2=A0 /* For mu= lticolor LEDs */ -#define LED_COLOR_ID_RGB=C2=A0=C2=A0=C2=A0 9=C2=A0=C2=A0=C2=A0 /* For mult= icolor LEDs that can do=20 arbitrary color, -=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0 so this would include RGBW and similar = */ -#define LED_COLOR_ID_MAX=C2=A0=C2=A0=C2=A0 10 +#define LED_COLOR_ID_WHITE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0 +#define LED_COLOR_ID_RED=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 1 +#define LED_COLOR_ID_GREEN=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 2 +#define LED_COLOR_ID_BLUE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 3 +#define LED_COLOR_ID_AMBER=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 4 +#define LED_COLOR_ID_VIOLET=C2=A0=C2=A0=C2=A0=C2=A0 5 +#define LED_COLOR_ID_YELLOW=C2=A0=C2=A0=C2=A0=C2=A0 6 +#define LED_COLOR_ID_IR=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 7 +#define LED_COLOR_ID_MULTI=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 8 /* For multicol= or LEDs */ +#define LED_COLOR_ID_RGB=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 9 /* Fo= r multicolor LEDs that can do=20 arbitrary color, including RGBW etc. */ +#define LED_COLOR_ID_PUPRPLE=C2=A0=C2=A0 10 +#define LED_COLOR_ID_ORANGE=C2=A0=C2=A0=C2=A0 11 +#define LED_COLOR_ID_PINK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 12 +#define LED_COLOR_ID_CYAN=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 13 +#define LED_COLOR_ID_LIME=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 14 +#define LED_COLOR_ID_MAX=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 15 =C2=A0/* Standard LED functions */ =C2=A0/* Keyboard LEDs, usually it would be input4::capslock etc. */ --=20 2.37.1