From nobody Sun Apr 5 19:44:41 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADED6C6FA82 for ; Sat, 17 Sep 2022 04:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbiIQE0S (ORCPT ); Sat, 17 Sep 2022 00:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229681AbiIQEZy (ORCPT ); Sat, 17 Sep 2022 00:25:54 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E67F2A951 for ; Fri, 16 Sep 2022 21:25:51 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a26so24779302ejc.4 for ; Fri, 16 Sep 2022 21:25:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date; bh=P4IXbjpJGogB5bTg3j6LGjLbToM1KMQkj8lnneUfMDE=; b=NX8Ya4tB87jnzHdWuHENplKakLqBCRAgfp8c1MduGfLX4qWI5aM+Zxa8rReQkVw4UH 6hlTaK/zi5A23JCAx7hrYYCuvKtFf2UGBAiV3xhGB3E1RI3uQTzySmM+nJezDdvLPkS1 s5CxJak70R28Jbv4z5kOrHPsQ5XmZ3wTVQGOCL1SiqsN9LNXfHTrfeeaGOompCIxZUX+ +VnaZw6Lbl7nSoBQeI/5w0dO7HHm9vYwJ6fj2kDpCJcwL1dxBVfj1JFw3mK9tEoP2naa HGUZ5vT+5++Q8xxzvNhdK2wHrwK4ojhSA9ZGpCYjVkwlRciPrq3akt/6NjieAMrwVjcJ rWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=P4IXbjpJGogB5bTg3j6LGjLbToM1KMQkj8lnneUfMDE=; b=ue6I+vTXiqejhKx221n6bnT+s16gpcefQO+f7n3qUuRu6DPjhf5l2UtEYtQ9schbDl RgB1jziMLHCko74jVFgQcCYf1Lzfa5kAY44nxlkEC9ehNHseTot+ph/Z+/A5TGXbmwIT YCSJxMto2gEeVggzjOttKLayNWffBaA4mKwuzfbTgycy4WDGbx85TnPHen1qpZ0bT8le GO7QJgf5tOiPU/UyNmb+aChBPF7Qcz8YmAYNoOyB9Z5CdXHgs53Har5cLKQCIRT5Dc83 C5vL4AhL8Ns584k9jX1k7Va5IUQ5pDPfvaMmR/+GCO1FANJVsiaUgujSfGVIi1O34SCM EZLQ== X-Gm-Message-State: ACrzQf06R/xjQb8W/5Eq4krZ4ian3buFFbL8rUOthwmxlxZ4EO8HkqXP mz/eGiTjYRwPmCihtB+44sa6+C46KVc= X-Google-Smtp-Source: AMsMyM7TWi7Pyw+NtYWXDQ0hRdHci6YAuF7Y7j81PkLYtxj2QlRD2YJMS7Dg5ZtYsN2zlzc2AdZWUA== X-Received: by 2002:a17:907:6ea2:b0:779:8fc1:e5d8 with SMTP id sh34-20020a1709076ea200b007798fc1e5d8mr5467127ejc.731.1663388751168; Fri, 16 Sep 2022 21:25:51 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57ba2cf5.dip0.t-ipconnect.de. [87.186.44.245]) by smtp.gmail.com with ESMTPSA id b2-20020a1709063ca200b00777249e951bsm11544672ejh.51.2022.09.16.21.25.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 21:25:50 -0700 (PDT) Date: Sat, 17 Sep 2022 06:25:48 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] staging: rtl8192e: Remove ftrace-like logging in rtl_ps.c Message-ID: <6d942ba65f62643af2ff7104911f7947cca21790.1663387785.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove "Unnecessary ftrace-like logging" as requested by checkpatch. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_ps.c | 34 ---------------------- 1 file changed, 34 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_ps.c index 966debd99296..d752bbc310d1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_ps.c @@ -23,13 +23,9 @@ static void _rtl92e_hw_sleep(struct net_device *dev) spin_lock_irqsave(&priv->rf_ps_lock, flags); if (priv->rf_change_in_progress) { spin_unlock_irqrestore(&priv->rf_ps_lock, flags); - RT_TRACE(COMP_DBG, - "%s(): RF Change in progress!\n", __func__); return; } spin_unlock_irqrestore(&priv->rf_ps_lock, flags); - RT_TRACE(COMP_DBG, "%s()=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>come to slee= p down\n", __func__); - rtl92e_set_rf_state(dev, eRfSleep, RF_CHANGE_BY_PS); } =20 @@ -50,14 +46,11 @@ void rtl92e_hw_wakeup(struct net_device *dev) spin_lock_irqsave(&priv->rf_ps_lock, flags); if (priv->rf_change_in_progress) { spin_unlock_irqrestore(&priv->rf_ps_lock, flags); - RT_TRACE(COMP_DBG, - "%s(): RF Change in progress!\n", __func__); schedule_delayed_work(&priv->rtllib->hw_wakeup_wq, msecs_to_jiffies(10)); return; } spin_unlock_irqrestore(&priv->rf_ps_lock, flags); - RT_TRACE(COMP_PS, "%s()=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>come to wake = up\n", __func__); rtl92e_set_rf_state(dev, eRfOn, RF_CHANGE_BY_PS); } =20 @@ -110,15 +103,10 @@ static void _rtl92e_ps_update_rf_state(struct net_dev= ice *dev) struct rt_pwr_save_ctrl *pPSC =3D (struct rt_pwr_save_ctrl *) &(priv->rtllib->PowerSaveControl); =20 - RT_TRACE(COMP_PS, "%s() --------->\n", __func__); pPSC->bSwRfProcessing =3D true; - - RT_TRACE(COMP_PS, "%s(): Set RF to %s.\n", __func__, - pPSC->eInactivePowerState =3D=3D eRfOff ? "OFF" : "ON"); rtl92e_set_rf_state(dev, pPSC->eInactivePowerState, RF_CHANGE_BY_IPS); =20 pPSC->bSwRfProcessing =3D false; - RT_TRACE(COMP_PS, "%s() <---------\n", __func__); } =20 void rtl92e_ips_enter(struct net_device *dev) @@ -133,7 +121,6 @@ void rtl92e_ips_enter(struct net_device *dev) if (rt_state =3D=3D eRfOn && !pPSC->bSwRfProcessing && (priv->rtllib->state !=3D RTLLIB_LINKED) && (priv->rtllib->iw_mode !=3D IW_MODE_MASTER)) { - RT_TRACE(COMP_PS, "%s(): Turn off RF.\n", __func__); pPSC->eInactivePowerState =3D eRfOff; priv->isRFOff =3D true; priv->bInPowerSaveMode =3D true; @@ -153,7 +140,6 @@ void rtl92e_ips_leave(struct net_device *dev) rt_state =3D priv->rtllib->eRFPowerState; if (rt_state !=3D eRfOn && !pPSC->bSwRfProcessing && priv->rtllib->RfOffReason <=3D RF_CHANGE_BY_IPS) { - RT_TRACE(COMP_PS, "%s(): Turn on RF.\n", __func__); pPSC->eInactivePowerState =3D eRfOn; priv->bInPowerSaveMode =3D false; _rtl92e_ps_update_rf_state(dev); @@ -210,7 +196,6 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev,= u8 rtPsMode) if (priv->rtllib->iw_mode =3D=3D IW_MODE_ADHOC) return false; =20 - RT_TRACE(COMP_LPS, "%s(): set ieee->ps =3D %x\n", __func__, rtPsMode); if (!priv->ps_force) priv->rtllib->ps =3D rtPsMode; if (priv->rtllib->sta_sleep !=3D LPS_IS_WAKE && @@ -221,8 +206,6 @@ static bool _rtl92e_ps_set_mode(struct net_device *dev,= u8 rtPsMode) priv->rtllib->sta_sleep =3D LPS_IS_WAKE; =20 spin_lock_irqsave(&(priv->rtllib->mgmt_tx_lock), flags); - RT_TRACE(COMP_DBG, - "LPS leave: notify AP we are awaked ++++++++++ SendNullFunctionData\n"= ); rtllib_sta_ps_send_null_frame(priv->rtllib, 0); spin_unlock_irqrestore(&(priv->rtllib->mgmt_tx_lock), flags); } @@ -236,12 +219,6 @@ void rtl92e_leisure_ps_enter(struct net_device *dev) struct rt_pwr_save_ctrl *pPSC =3D (struct rt_pwr_save_ctrl *) &(priv->rtllib->PowerSaveControl); =20 - RT_TRACE(COMP_PS, "%s()...\n", __func__); - RT_TRACE(COMP_PS, - "pPSC->bLeisurePs =3D %d, ieee->ps =3D %d,pPSC->LpsIdleCount is %d,RT_C= HECK_FOR_HANG_PERIOD is %d\n", - pPSC->bLeisurePs, priv->rtllib->ps, pPSC->LpsIdleCount, - RT_CHECK_FOR_HANG_PERIOD); - if (!((priv->rtllib->iw_mode =3D=3D IW_MODE_INFRA) && (priv->rtllib->state =3D=3D RTLLIB_LINKED)) || (priv->rtllib->iw_mode =3D=3D IW_MODE_ADHOC) || @@ -252,10 +229,6 @@ void rtl92e_leisure_ps_enter(struct net_device *dev) if (pPSC->LpsIdleCount >=3D RT_CHECK_FOR_HANG_PERIOD) { =20 if (priv->rtllib->ps =3D=3D RTLLIB_PS_DISABLED) { - - RT_TRACE(COMP_LPS, - "%s(): Enter 802.11 power save mode...\n", __func__); - if (!pPSC->bFwCtrlLPS) { if (priv->rtllib->SetFwCmdHandler) priv->rtllib->SetFwCmdHandler( @@ -275,15 +248,8 @@ void rtl92e_leisure_ps_leave(struct net_device *dev) struct rt_pwr_save_ctrl *pPSC =3D (struct rt_pwr_save_ctrl *) &(priv->rtllib->PowerSaveControl); =20 - - RT_TRACE(COMP_PS, "%s()...\n", __func__); - RT_TRACE(COMP_PS, "pPSC->bLeisurePs =3D %d, ieee->ps =3D %d\n", - pPSC->bLeisurePs, priv->rtllib->ps); - if (pPSC->bLeisurePs) { if (priv->rtllib->ps !=3D RTLLIB_PS_DISABLED) { - RT_TRACE(COMP_LPS, - "%s(): Busy Traffic , Leave 802.11 power save..\n", __func__); _rtl92e_ps_set_mode(dev, RTLLIB_PS_DISABLED); =20 if (!pPSC->bFwCtrlLPS) { --=20 2.37.3