From nobody Mon Dec 1 23:04:11 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81039274FD3 for ; Sat, 29 Nov 2025 14:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427860; cv=none; b=FNgzsLZnUHMP/LR3zkxhGuH2elOUyCYqHbt5LTkDUp5ENZdBX18+tWD5bgBU7KCsWfaKfFflXIwMd35I8ex9Y70r9pii0qzNddNEvijoaWNOsX2qCw15T1SqQNHvgYK9V5M7ONOH52rbxNiL5rX7QBwiY9YMbD2OEMiVusVKYKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764427860; c=relaxed/simple; bh=kJAVYd2/PPlXFLOf6bOfuTDn5AtW65rQSCFJWrlTfDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s02lvMrq+o5dvmIMaiSSidR0AjRSBoQ6w+RblH6CR9uOyXvQ/XT5KXbeJU41+MLBlvnQ0JmjseOrZfGb28709Xa/at8qSt9IOOl8jRPQONzz3teba9MfyXuA3Dr6uriDl9kiLDX+XLOdjTyaXdJV2GvcPjlKVmoXr+EHAiUzMms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W/Qx3XDM; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W/Qx3XDM" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so1914065f8f.2 for ; Sat, 29 Nov 2025 06:50:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764427857; x=1765032657; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5roHuQegQf4KvGy0xBz6y0ubzRCDlqFmvzi3L2AWogw=; b=W/Qx3XDMWS1ds9QdnTvdp2EazQKt2QvWbGq+Oz5cZIPAnny/0obCp/TMzLTcx7G/Dl 1/DyEOg8aKg1/+cwX7yUJg90U7s0QCM3ggawgrJyeRqT8snKDOHGJadgjo/RcC8L6Mj0 4RuJyXgRVSei3CyAYLngQzTfQHJeBCZinYKHoSU9M5WF2XO+/Sco7oZ+aWRxh/d392Ug MUmmJnfY+A+vVz/CflTebjGmsYZZgB29EOgtChAB2fNYQqjVfWAvOSPfts78IFu6cBIE tcDtgrxVxBjc8D1ELRBZBg1eY5TbTKA7JbxXPAmgdo/BJ4DZ1y/LisyCd5KVMZWm06o8 mmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764427857; x=1765032657; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5roHuQegQf4KvGy0xBz6y0ubzRCDlqFmvzi3L2AWogw=; b=fQJvW65dm9SesiiKpF74tfkzNNLQtYOwNjfwFxvioY2VCbtBNJYqgPwaoinP/aiAQQ 4LCulbwVXm7ni3sIsA9NZIoVzwwUC3BBZdh5Ov3G4nItXsJptffLu3+Chat3rndWKRij FM72m8v3zFix1jT7ROTSqSRyyNp+ytUyXyJFe5NibxRgEA8extzbbGCtEjnFpM/N43J5 vXfaubhYen/KgsXZTvbiA+Ifj8IOznboKfIEcRa/Ndxt2OhQ9zprbbirKkP6AEnjWJ/W wXlI/vjhsyzu5r74s7rH92b5blfa5M2v7U15EousCUOYDtPQCp5ID7RRIaiBZ8s+MA7T o3Kg== X-Forwarded-Encrypted: i=1; AJvYcCWLx7ttMyGehn+FOw892vBx2MpUmAbRwRu/uhrSHyr104qmI8v7z1xf9wzixMOjHMBlfsjn0mo/TO26xfA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/nOv6r0ppq+C5d/5Yt5JV4YhqZyewGAwdXbH6SvQyg/Cjy7Ap fw0hOlNW5wyh0jv1crB+s9Xt4l+SOA7czsSMQAwtpHn3k5oICF5tb6OQgf3rax5Z4pU= X-Gm-Gg: ASbGncvd4CHt79oVfTZP9x1u/F9wfVMxDkepz830AGv5Y6S4Zq9cXuOs8qBwjv8raZ+ Y3+/5ai4lqOZ9ovllrxmMR2VxAvAZIGTFdjhhwwBRpOrw0Y6iw7U21UfUPGw9Uke4RRLTYVu41g zGeU4lHoiCZDh2q0jJIKyxclFj3SdqCNirEmaDVB6C0dlxatJ6qlF7mJYKWqLyexYBGncmRDdF3 5y78UoVAmlxCHfFZ+42H/SWusOZgztSYcTKlpz44DmMVEBnSzW7NUlEe/p48xWt/z49oTE8SZIe 1wMfxysujML1+obaA7xdO2oITMQLdiYoR2MtltJtECXGFbB7oUbruzpPBABedc0M5OcPUFWDTGq OWMOYs8ggDrOLZ86klh4ZSWsg4p8XXtsR2T8df8GraGmyBnagIBVviNsRzOEHgbaX4a6Ncbdfg4 Y5OfZGWmiAA6Vp3KAzKTNvy1xowbY= X-Google-Smtp-Source: AGHT+IF17rmdp5RFNg6kmMqYr9tYvGHfwa2QHnZkDzl2I/vBSSLY/k6vA/+nMv85qGYklo9B258YMw== X-Received: by 2002:a05:6000:61e:b0:429:d6dc:ae30 with SMTP id ffacd0b85a97d-42cc1d19914mr34066767f8f.46.1764427856782; Sat, 29 Nov 2025 06:50:56 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-42e1c5c3016sm15993129f8f.1.2025.11.29.06.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 06:50:56 -0800 (PST) Date: Sat, 29 Nov 2025 17:50:53 +0300 From: Dan Carpenter To: Rob Herring Cc: Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] remoteproc: qcom_q6v5_adsp: Fix a NULL vs IS_ERR() check in adsp_alloc_memory_region() Message-ID: <6d6b1b0fb6a61b5155a640507217fd7e658858cf.1764427595.git.dan.carpenter@linaro.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The devm_ioremap_resource_wc() function never returns NULL, it returns error pointers. Update the check to match. Fixes: c70b9d5fdcd7 ("remoteproc: qcom: Use of_reserved_mem_region_* functi= ons for "memory-region"") Signed-off-by: Dan Carpenter --- drivers/remoteproc/qcom_q6v5_adsp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_= q6v5_adsp.c index d3933a66ed3d..b5c8d6d38c9c 100644 --- a/drivers/remoteproc/qcom_q6v5_adsp.c +++ b/drivers/remoteproc/qcom_q6v5_adsp.c @@ -637,9 +637,10 @@ static int adsp_alloc_memory_region(struct qcom_adsp *= adsp) adsp->mem_phys =3D adsp->mem_reloc =3D res.start; adsp->mem_size =3D resource_size(&res); adsp->mem_region =3D devm_ioremap_resource_wc(adsp->dev, &res); - if (!adsp->mem_region) { + if (IS_ERR(adsp->mem_region)) { dev_err(adsp->dev, "unable to map memory region: %pR\n", &res); - return -EBUSY; + return PTR_ERR(adsp->mem_region); + } =20 return 0; --=20 2.51.0