From nobody Tue Jun 23 13:01:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0281C433EF for ; Fri, 4 Mar 2022 12:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239679AbiCDMHC (ORCPT ); Fri, 4 Mar 2022 07:07:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233619AbiCDMHB (ORCPT ); Fri, 4 Mar 2022 07:07:01 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10C9E1B309F; Fri, 4 Mar 2022 04:06:13 -0800 (PST) Received: from kwepemi100010.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4K96166pp3z9sjD; Fri, 4 Mar 2022 20:02:34 +0800 (CST) Received: from kwepeml100006.china.huawei.com (7.221.188.192) by kwepemi100010.china.huawei.com (7.221.188.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 20:06:10 +0800 Received: from kwepeml500003.china.huawei.com (7.221.188.182) by kwepeml100006.china.huawei.com (7.221.188.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 4 Mar 2022 20:06:10 +0800 Received: from kwepeml500003.china.huawei.com ([7.221.188.182]) by kwepeml500003.china.huawei.com ([7.221.188.182]) with mapi id 15.01.2308.021; Fri, 4 Mar 2022 20:06:10 +0800 From: "Zhangjiantao(Kirin,Nanjing)" To: "jingoohan1@gmail.com" , "gustavo.pimentel@synopsys.com" , "lorenzo.pieralisi@arm.com" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Caiyadong , guhengsheng , "zhangjianrong (E)" Subject: [PATCH] PCI: dwc: solve returning success but actually failed Thread-Topic: [PATCH] PCI: dwc: solve returning success but actually failed Thread-Index: AdgvwBRDx2FzmehYQAqHeO4j8ZwdwQ== Date: Fri, 4 Mar 2022 12:06:10 +0000 Message-ID: <6d26f16646294836b87611f4dc5fe763@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.136.108.160] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When dma_mapping_error returns error because of no enough memory available,= dw_pcie_host_init will return success, which will mislead the callers. Signed-off-by: zhangjianrong Signed-off-by: zhangjiantao --- =C2=A0drivers/pci/controller/dwc/pcie-designware-host.c | 1 + =C2=A01 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index f4755f3a03be..ac691d733848 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -393,6 +393,7 @@ int dw_pcie_host_init(struct pcie_port *pp) =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 if (dma_map= ping_error(pci->dev, pp->msi_data)) { =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2= =A0=C2=A0 dev_err(pci->dev, "Failed to map MSI data\n"); =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2= =A0=C2=A0 pp->msi_data =3D 0; +=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 ret =3D -1; =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2= =A0=C2=A0 goto err_free_msi; =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 } =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 } -- 2.17.1