From nobody Mon Feb 9 11:07:18 2026 Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89A251FC7F6 for ; Wed, 5 Feb 2025 16:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738772917; cv=none; b=ib8cf4w7VYAzn16lo2vrdadCq7HU99NmLmDAEXHwkFrmAGDBZVp+8p3MspAV5sESpu3LIIfYr0JQiOrxCvhSdMsBuBjv9enlva3FkW0algKG/k62DuJ1H2P99BXBL/o10MGJBADXFOyFx/pqxcAQhuyeV/AAar5fVX6IzR01WCU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738772917; c=relaxed/simple; bh=EttioCEzotPWFiddBHkBE0AJBG8efcrrqir3XlI9I80=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=EPQ6XGVrZCBLwa5N5Jg6zPoPiMg88MsBUPL/S4l96OR+xgprkJtgoEa6TiiRuAgjsPX9WMSR4Lde4n8AUSjCxV5i/UVqnzWd7CHI4gBTgkT+UOuGyVavkW9RR5gt0FlusuDlAdru52D6zvSO7fLDUb7QXt3gOhVeC3oMMdKBZ1I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dvyukov.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FxVmE1DF; arc=none smtp.client-ip=209.85.218.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dvyukov.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FxVmE1DF" Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-aa689b88293so294482066b.3 for ; Wed, 05 Feb 2025 08:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738772913; x=1739377713; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6mES9zlK4q0Abt8GXLMsE8pcYClHIX0RrLwiPkvwA/U=; b=FxVmE1DFOjVySRaSZy2dg+ytsmSiX3HuCUUIwBVsGWM62AJyZlmv9jsRVTLErQrQtZ sB/CarAXtk2NUCEyMp+8YX2t3KDGCcZudfKgkG09mOvY1YyaIyUgdd6odHa2MSkwSe1O hGAGeRv5Lk0paEdDqWUoEdeHZbw4bVmisCTHWDK96JDdxRb2WdhX3QoUkGrVGPd8g7Mn XIukEFMMJgXEkQ0BcDo3Ej+odQNuriu7uMQyIDOnZM6jRCHFJMZSuUcL8aXM+4PAVzQ7 7OuHhXerWYq+pGqAvPWIQzuwWKUYPB9I+tpLqwY1laHDR6c+jVstT6DQYNNROdeUBYt5 +kHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738772913; x=1739377713; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6mES9zlK4q0Abt8GXLMsE8pcYClHIX0RrLwiPkvwA/U=; b=HgdIpzBTnOHZzbLZod6dxaD1luf6Mr/EBW6mxeJbD0sPvEA00Q6QIOozyVO1A+36z0 0Ly5SIZcxiGnQYelEAcIMR24H6mAau9PTPp/uAAR5Y9gYmf3XSLKbP5nXj49MHGjoyjD yP00p22SZ1ZbP5XROk9A3w1azBEAAAyS0sFp7dMkbSsxXtd7HFAZA1SYCZVOOBJoEVER LHIe+OqW/DBd6QdASpok0Kt48oA1etMgT+lDODJ2zeZHB6d2Ry7yoM1rdj5FSTpS7rI4 R/0EgxPl1UizyetKSKxShSgk/2TcOBDTUqjQ6BURm4KvAqoYNh0/GiceAkyMKLLyHGov DgRw== X-Forwarded-Encrypted: i=1; AJvYcCU+pGbk9JK/tu5IBDVSkQZJRogqnSWmaQLdrOVPcyxUlD7eHO6mbHO37x8ZL1bXejNzUkjdIU7exo6Bo2U=@vger.kernel.org X-Gm-Message-State: AOJu0YyA5pIcddCYysY0s3gWKy7Kijkbkt6xSJohuT20lOco+8BD4aSw kHAnfC34fEXXIaCx74F2XZSjPfE2Y+HlPHA0b/gWC3t7B/3TSMfpCkW3rg8qlr/44zqZ15NT7am XoIM1bQ== X-Google-Smtp-Source: AGHT+IEO002sEP2tAcE1es3lzHcp552u1N9eSedG+5a9pqj3xDRDruIrADWaB9Xm5GoOz77Xf2midHQ2rbG6 X-Received: from ejcrg9.prod.google.com ([2002:a17:907:6b89:b0:ab6:8ef1:7284]) (user=dvyukov job=prod-delivery.src-stubby-dispatcher) by 2002:a17:906:856:b0:ab7:6606:a8d5 with SMTP id a640c23a62f3a-ab76606b5camr238720966b.48.1738772912988; Wed, 05 Feb 2025 08:28:32 -0800 (PST) Date: Wed, 5 Feb 2025 17:27:42 +0100 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.48.1.362.g079036d154-goog Message-ID: <6b1197cf7daac315b998e8c96042822b56d4bd25.1738772628.git.dvyukov@google.com> Subject: [PATCH v5 3/8] perf report: Switch filtered from u8 to u16 From: Dmitry Vyukov To: namhyung@kernel.org, irogers@google.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Vyukov , Arnaldo Carvalho de Melo Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We already have all u8 bits taken, adding one more filter leads to unpleasa= nt failure mode, where code compiles w/o warnings, but the last filters silent= ly don't work. Add a typedef and switch to u16. Signed-off-by: Dmitry Vyukov Cc: Namhyung Kim Cc: Arnaldo Carvalho de Melo Cc: Ian Rogers Cc: linux-perf-users@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- tools/perf/util/addr_location.h | 3 ++- tools/perf/util/hist.c | 2 +- tools/perf/util/hist.h | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/addr_location.h b/tools/perf/util/addr_locatio= n.h index 36aaa45445f24..f83d74e370b2f 100644 --- a/tools/perf/util/addr_location.h +++ b/tools/perf/util/addr_location.h @@ -3,6 +3,7 @@ #define __PERF_ADDR_LOCATION 1 =20 #include +#include "hist.h" =20 struct thread; struct maps; @@ -17,7 +18,7 @@ struct addr_location { const char *srcline; u64 addr; char level; - u8 filtered; + filter_mask_t filtered; u8 cpumode; s32 cpu; s32 socket; diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index cafd693568189..6b8f8da8d3b66 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -585,7 +585,7 @@ static struct hist_entry *hist_entry__new(struct hist_e= ntry *template, return he; } =20 -static u8 symbol__parent_filter(const struct symbol *parent) +static filter_mask_t symbol__parent_filter(const struct symbol *parent) { if (symbol_conf.exclude_other && parent =3D=3D NULL) return 1 << HIST_FILTER__PARENT; diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h index a6e662d77dc24..4035106a74087 100644 --- a/tools/perf/util/hist.h +++ b/tools/perf/util/hist.h @@ -33,6 +33,8 @@ enum hist_filter { HIST_FILTER__C2C, }; =20 +typedef u16 filter_mask_t; + enum hist_column { HISTC_SYMBOL, HISTC_TIME, @@ -244,7 +246,7 @@ struct hist_entry { bool leaf; =20 char level; - u8 filtered; + filter_mask_t filtered; =20 u16 callchain_size; union { --=20 2.48.1.362.g079036d154-goog