From nobody Wed Apr 8 02:51:49 2026 Received: from mail-dy1-f169.google.com (mail-dy1-f169.google.com [74.125.82.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 154BC39DBFE for ; Tue, 10 Mar 2026 15:46:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773157575; cv=none; b=rybXn+yz+jfrnYf3tKijzojasCpZdL4Tc+sfhw41hQRCOdXIditbQFT2SVZhdhHxKmsIjh+QultlLNFphbTPw14eBpKgCS9nVL4zeJA+XYlv4xen5wABv3UFJCl98fnHnaTGwazibw+5qMDdU6uGGJLVya+C2k8J8nwcaEgJVws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773157575; c=relaxed/simple; bh=mkzV9oFnLvNGAdS5sbKtcJbOHGY/3jjTz7sQR6sodTg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=aTBqGn40sBCsnI6/QPYitozMVNU0iAVvLwt4wrDOO35FCTVaXaazs9oxtL4bycY6/siCS4YFZpB+i4qUwLPSWRt3UUqpx26CoXCj0JVrB1Gre1mNhHWlHXscuSXn0sHd44zOS5vCuqQrCWr2hC5DL7J7RpLwJy8cUV+r7ev+Ygo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wbinvd.org; spf=pass smtp.mailfrom=wbinvd.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b=Rg3WrgRx; arc=none smtp.client-ip=74.125.82.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wbinvd.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wbinvd.org header.i=@wbinvd.org header.b="Rg3WrgRx" Received: by mail-dy1-f169.google.com with SMTP id 5a478bee46e88-2be1b5fe11cso10448753eec.0 for ; Tue, 10 Mar 2026 08:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wbinvd.org; s=wbinvd; t=1773157573; x=1773762373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eWrM4zr6HsvGxIBz42uj8X29XvQLF5lH3Zcfuwu6Bmo=; b=Rg3WrgRxzjPBk+UDXEJsTSVkhhA+FdRsnHAArPo6t7ouT91Q370kKcMcWBNuQBHMGT J3Xvgg0CG0V8vvx3jS9gwbLr1ooQlWg+OwUTybxkqUFTSGDveOGc8mCjHGrtNLra+0mP 0MNKP3XIwwJF4v3fPzsFbyrNmREX3hMXbThia1NDQ09s8aYX+wXaKvFgHigXnSI5nFhH RSk4BYeN730KUgwvKdzrktr2gXcPy4VJBqp3ke0tB+zWmVe7JRSsbDVD0qO1kr9LiHm/ dX7AS4xxbS2DmlJ41rmC6Vv3rrPAUkut1oFprHjb8FxHbgibngparDrlOTDFcpxRI2A2 bZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773157573; x=1773762373; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eWrM4zr6HsvGxIBz42uj8X29XvQLF5lH3Zcfuwu6Bmo=; b=pCcutY9jR2M+io0zD9LLrULpgUI+MYN00yeThHJxEpEuPbOHqXI+75jiW13VfZGiSq zpuC3jsJy3e+Pa52B1QJcCjabYef9hK/GOdpC/m+8WVQuWOOnIfNB5aCdHZ1LHT3zCGR awrgStHEMHhQnWxkRk6v/ObOnFg15Cu6bU6VSEzmPTPq34fxqWdHJuwEgbQhctgLWqe8 Ptg/jRqqnUP6IJqLmJSpBA9djneZb0ts+7fqe4mQK4PCsAh0xoGt2nh7V9NhrvSSvRZI g7esZ6BXx3l/iMXfwUvjbhWDmNRQBhPGEjKOIdaCc6uwWTSyBM2n97ZaMh+oWuCIAcmD pKDA== X-Gm-Message-State: AOJu0Yw98/7bkKq0dY1ZDxlpvdnoWI1z3dXMx+4fRcJ3eMxRwl01bduV o1bupCwzEX/lPMFOSktraJ7uTS5MtKyyScO5QF5oH4NQ46dl74herA0IoKZ0jlZa+dpLpbTA/Yi /M1L77K4= X-Gm-Gg: ATEYQzwNCTsae7/my+uwiFGIj5UBF83T+pvZ8LKXlPpD3YWuviTIB/uerDqgd9QUes4 1H0nuEGOIQxNFvEJJyALfIkr6RwfX0WDH1z9xdFBMA6toB6scItrSag0ElSdiFtcZnvqI+6oWp/ 1SLexIXAdyMquGaMdCp/s0qhLbUMgv9/Vss5thTI/5y1fV82qUMHVbJf7m/zHAw0vyrX3KYLc04 r46s3nx3Xy89jOgVZzrn83xtAgCwvM5p2yDk85jqsI6mMf979JVLlTn0Oacuspblc4qO5ZRLl0p kLVCSMMJRHe5rbE5L0pEEe6i0JSkljRkXS+B1QIP3MJXbcQFbr0K83ZjO3G621LmKM4xWa1jaz/ RMWLidRIDqhVfZWuYHwwezriUsJVFg6Z+TfcmVpzAkqQAeaSERJW72EULucaNAhBmlyLoznRnSd XiVG80KK0tn5wW2y3QtLTG0GDGOoS4oGpViHI= X-Received: by 2002:a05:7300:a887:b0:2be:198e:438 with SMTP id 5a478bee46e88-2be4e01914fmr6497991eec.16.1773157572941; Tue, 10 Mar 2026 08:46:12 -0700 (PDT) Received: from mozart.vkv.me ([2001:5a8:468b:d015:38dd:9485:6087:683]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be645c89bfsm9743296eec.13.2026.03.10.08.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 08:46:12 -0700 (PDT) From: Calvin Owens To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian Koenig , David Airlie , Simona Vetter Subject: [PATCH] drm/amd/display: Fix a benign uninitialized variable warning Date: Tue, 10 Mar 2026 08:46:06 -0700 Message-ID: <6aaf2cf4bd19363a85f35e649685d7bdae400253.1773157137.git.calvin@wbinvd.org> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable This warning shows up with GCC at W=3D2: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3229:32: wa= rning: =E2=80=98r=E2=80=99 may be used uninitialized [-Wmaybe-uninitialized] 3229 | return r; | ^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3133:13: no= te: =E2=80=98r=E2=80=99 was declared here 3133 | int r; | ^ The compiler can't know drm_atomic_helper_suspend() doesn't return NULL, so GCC is technically correct, that case would return `r` uninitialized. Fix the warning by using PTR_ERR_OR_ZERO() on the return value from drm_atomic_helper_suspend() like i915 does. Signed-off-by: Calvin Owens --- This is pretty nitpicky and obviously benign IMO, I just happened to spot it while debugging [1]. No argument from me if you don't want it :) [1] https://lore.kernel.org/lkml/ef7266eb7802ce6d68ebd9356477e9671f0c94e0.1= 773116305.git.calvin@wbinvd.org/#t drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index b3d6f2cd8ab6..9c5dce8d38b6 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3133,12 +3133,11 @@ static int dm_cache_state(struct amdgpu_device *ade= v) int r; =20 adev->dm.cached_state =3D drm_atomic_helper_suspend(adev_to_drm(adev)); - if (IS_ERR(adev->dm.cached_state)) { - r =3D PTR_ERR(adev->dm.cached_state); + r =3D PTR_ERR_OR_ZERO(adev->dm.cached_state); + if (r) adev->dm.cached_state =3D NULL; - } =20 - return adev->dm.cached_state ? 0 : r; + return r; } =20 static void dm_destroy_cached_state(struct amdgpu_device *adev) --=20 2.47.3