From nobody Thu Apr 2 12:22:26 2026 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB751F872D for ; Sat, 28 Mar 2026 16:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774714625; cv=none; b=Fi+Jpqn6fUTYaPb8Y8cu02F/brOCQALmDGxc+Un9B+TF5o9pehwWevhBix1qLIu8j3Vpcdto+Rx1h2XXQg1gOmpE98pHc4JgIhi8s+KaQ1s/c0Uz9IrdJHQARv5DGOWdgn+6JP5WxpQLwNwJecI2MjNf3c7GngnTpOiYnf9aYgA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774714625; c=relaxed/simple; bh=B8XuDfDXtpij5Aw7QigHPShnJWZR05Hguh7FX2efcFw=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=FzPprAhEP/yr1CSafAHuQRVTINNXQ+gULEkHlDDU3cIgJIwbay5cai57voo7w6NqvIcN65WqYjyfwFY4JD91p//rTygZN8lyswNIuF/CGELgp1HsczJfC6zKWtr4pyyIYE83rhFWGbfjdihYKiZL8BgZqsACu1iiuDfF7SO+hQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-67e0df20fc1so9984309eaf.3 for ; Sat, 28 Mar 2026 09:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774714623; x=1775319423; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TL39utibUpi0y0/YJxUxbE5ABTTSWvPsqvMYhv4IJSQ=; b=W2eaZFkBVobiNkBGggOqmedzi1h3BXq4wbEffZRAd4vk8DB59R0KI/orcbF6dEFIgY try6zWrdeT+/TI+XPyjdSoiK0x8XhuszVcsXsk/ETQubYwDgcNAw6kIQQyoaq6XaKKUY aFjxdq1hp3Ii4zg2l+j+6qHIHO4TTxXOHiZKN64PLftJjzeZXx1Bqa1JbavZ9Ita/RIm FdfGTw+0VjHIK03e3V5Sa2zGaI+hlsaiKQGtf6365WJG7KppaJxXoKoFz56M/mLiEzKs fySXN3yMgko0/CyYkSZ4FSuOz0B+/v3G3OaqjiK61xoS6cT3qkZNTciGn7bRyPpoBojT FYSw== X-Gm-Message-State: AOJu0YxLhWwFx/0lgwOihK25cRMQk36zHRehc9OrRXZOCAYYuLvc2Ipe H4lP33DZjd/f0WG5jMWAl60JlOux0Zx5bmrXZjIBjRtmQ2GqxsIDIZTg/0SwlJ9MOl5LRGbbxtT 9RtZY8ce5LOi5L45vfXe7T5dSkJdHdfAMAUch85j9/rM3oNsJJNUZIWfT6Wo= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:138f:b0:67c:de6:d95b with SMTP id 006d021491bc7-67e1860ab12mr3528559eaf.19.1774714623079; Sat, 28 Mar 2026 09:17:03 -0700 (PDT) Date: Sat, 28 Mar 2026 09:17:03 -0700 In-Reply-To: <6982985a.a00a0220.37c87e.0017.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69c7feff.050a0220.2521b9.004e.GAE@google.com> Subject: Forwarded: Re: [syzbot] [f2fs?] kernel BUG in clear_inode From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] [f2fs?] kernel BUG in clear_inode Author: kth5965@gmail.com #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it master diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 0a1052d5ee62..92fcadf6d2cc 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -53,8 +53,8 @@ bool f2fs_sanity_check_inline_data(struct inode *inode, s= truct folio *ifolio) if (!f2fs_has_inline_data(inode)) return false; =20 - if (inode_has_blocks(inode, ifolio)) - return false; + if (!f2fs_exist_data(inode) && inode_has_blocks(inode, ifolio)) + return true; =20 if (!support_inline_data(inode)) return true; @@ -142,6 +142,17 @@ int f2fs_read_inline_data(struct inode *inode, struct = folio *folio) return 0; } =20 +static void f2fs_clear_inline_inode(struct dnode_of_data *dn) +{ + f2fs_folio_wait_writeback(dn->inode_folio, NODE, true, true); + clear_inode_flag(dn->inode, FI_DATA_EXIST); + clear_inode_flag(dn->inode, FI_INLINE_DATA); + set_raw_inline(dn->inode, F2FS_INODE(dn->inode_folio)); + folio_mark_dirty(dn->inode_folio); + folio_clear_f2fs_inline(dn->inode_folio); + stat_dec_inline_inode(dn->inode); +} + int f2fs_convert_inline_folio(struct dnode_of_data *dn, struct folio *foli= o) { struct f2fs_io_info fio =3D { @@ -157,8 +168,10 @@ int f2fs_convert_inline_folio(struct dnode_of_data *dn= , struct folio *folio) struct node_info ni; int dirty, err; =20 - if (!f2fs_exist_data(dn->inode)) - goto clear_out; + if (!f2fs_exist_data(dn->inode)) { + f2fs_clear_inline_inode(dn); + goto out; + } =20 err =3D f2fs_reserve_block(dn, 0); if (err) @@ -206,10 +219,8 @@ int f2fs_convert_inline_folio(struct dnode_of_data *dn= , struct folio *folio) =20 /* clear inline data and flag after data writeback */ f2fs_truncate_inline_inode(dn->inode, dn->inode_folio, 0); - folio_clear_f2fs_inline(dn->inode_folio); -clear_out: - stat_dec_inline_inode(dn->inode); - clear_inode_flag(dn->inode, FI_INLINE_DATA); + f2fs_clear_inline_inode(dn); +out: f2fs_put_dnode(dn); return 0; } @@ -232,9 +243,7 @@ int f2fs_convert_inline_inode(struct inode *inode) if (err) return err; =20 - folio =3D f2fs_grab_cache_folio(inode->i_mapping, 0, false); - if (IS_ERR(folio)) - return PTR_ERR(folio); + set_new_dnode(&dn, inode, NULL, NULL, 0); =20 f2fs_lock_op(sbi, &lc); =20 @@ -246,14 +255,23 @@ int f2fs_convert_inline_inode(struct inode *inode) =20 set_new_dnode(&dn, inode, ifolio, ifolio, 0); =20 + if (f2fs_has_inline_data(inode) && f2fs_exist_data(inode)) { + folio =3D f2fs_grab_cache_folio(inode->i_mapping, 0, false); + if (IS_ERR(folio)) { + err =3D PTR_ERR(folio); + folio =3D NULL; + goto out; + } + } + if (f2fs_has_inline_data(inode)) err =3D f2fs_convert_inline_folio(&dn, folio); =20 - f2fs_put_dnode(&dn); out: + f2fs_put_dnode(&dn); f2fs_unlock_op(sbi, &lc); - - f2fs_folio_put(folio, true); + if (folio) + f2fs_folio_put(folio, true); =20 if (!err) f2fs_balance_fs(sbi, dn.node_changed);