From nobody Thu Apr 2 14:10:34 2026 Received: from mail-oa1-f70.google.com (mail-oa1-f70.google.com [209.85.160.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EBA133D6D6 for ; Sat, 28 Mar 2026 15:41:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712510; cv=none; b=QExmwVq63Fkn+7BfAkghms9ZjIy2KPHyM6aG1pR6kKALeR+G9F/sFthpM2SycAJ3zWBlOSgW6dTDiA0FtbKGf0gU0LHcWL4JziOQMOW7aW90/UL2uj0YanWg/u/LUlsgLRP9HyxTcUPseI+3QJ1GwZwSp2D/q3BCnXXineJ5J4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774712510; c=relaxed/simple; bh=P6OKwaK0G00gDbZgznPuAQCngodgykj6LxwFEaat61k=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=GmeHM9+uRZKtNeQIBM8O5EcxVKkRKAsJLZzdKbklTWpaxuVDxz9ZzO2euhQ3mcbG87cCdqLZUsNPT/L0+cNw7L2/5FRvLPIvBKhPL4Uw55RusAUPasBM/QddyskpuRijrzrc3HXaJF+KAHmzxNnxtnkPkajd5CA0beUnVo+Tyos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.160.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oa1-f70.google.com with SMTP id 586e51a60fabf-40efa542b8aso6930539fac.2 for ; Sat, 28 Mar 2026 08:41:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774712508; x=1775317308; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+MgNoitmpjj4URJLOpz0qMiLtF8CKDUidjKzktmdvlA=; b=bpH4AIvzRJLPk3qWhtXRoUaSdNZH18+U4QoVRKHXwyav75bWzGixjJANzkwwvtLXS1 X8jYHBpRv1cEi2TjrL1rHlpztYqNV/JRg/j+SP4XoYT8OgAu5arSPGOzf0LcsToc0L7s ogR/RvcUJRfl2HwcFLRVLII9wrFYJbKG8/P/f5pFopWo6i9nnqlRfIGbIwPrRf7dgnSZ C+ngU2KeXQFwOw9PBBqo8gU5Po1+MhtG2PfX9tSdbAm73LlfCdJgd4gW6bYFUUkkyhi0 VDn2LBnU9E0rf+19tgcXGNZgw/yqg9E1h2bqF5/Bs+Y/4JtcpYIfr2RFdpYGbH/XW2Ux A3LA== X-Gm-Message-State: AOJu0Yz28t+RX2Zjm9DqSxmcIJDjhwmDAo9OfGIIVOx+52P0CEgStM9F z8BPj8yrelkvNymmGQ5bQTbSOHKkMlg7lTS2/2wuaWOGGgrn9zAyfiD5AZA/2ZkwUdMcbp9bQKp dWYp7m0kQfGt59gN/d/XcS18jgEAiAZ1NCwWeQ19P6kA4E/dddtfmKbWDSlU= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:615:b0:67e:160c:3699 with SMTP id 006d021491bc7-67e186536e2mr3275351eaf.30.1774712508547; Sat, 28 Mar 2026 08:41:48 -0700 (PDT) Date: Sat, 28 Mar 2026 08:41:48 -0700 In-Reply-To: <6982985a.a00a0220.37c87e.0017.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <69c7f6bc.050a0220.183828.0002.GAE@google.com> Subject: Forwarded: Re: [syzbot] [f2fs?] kernel BUG in clear_inode From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [syzbot] [f2fs?] kernel BUG in clear_inode Author: kth5965@gmail.com #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g= it master diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c index 0a1052d5ee62..92fcadf6d2cc 100644 --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -53,8 +53,8 @@ bool f2fs_sanity_check_inline_data(struct inode *inode, s= truct folio *ifolio) if (!f2fs_has_inline_data(inode)) return false; =20 - if (inode_has_blocks(inode, ifolio)) - return false; + if (!f2fs_exist_data(inode) && inode_has_blocks(inode, ifolio)) + return true; =20 if (!support_inline_data(inode)) return true; @@ -142,6 +142,17 @@ int f2fs_read_inline_data(struct inode *inode, struct = folio *folio) return 0; } =20 +static void f2fs_clear_inline_inode(struct dnode_of_data *dn) +{ + f2fs_folio_wait_writeback(dn->inode_folio, NODE, true, true); + clear_inode_flag(dn->inode, FI_DATA_EXIST); + clear_inode_flag(dn->inode, FI_INLINE_DATA); + set_raw_inline(dn->inode, F2FS_INODE(dn->inode_folio)); + folio_mark_dirty(dn->inode_folio); + folio_clear_f2fs_inline(dn->inode_folio); + stat_dec_inline_inode(dn->inode); +} + int f2fs_convert_inline_folio(struct dnode_of_data *dn, struct folio *foli= o) { struct f2fs_io_info fio =3D { @@ -157,8 +168,10 @@ int f2fs_convert_inline_folio(struct dnode_of_data *dn= , struct folio *folio) struct node_info ni; int dirty, err; =20 - if (!f2fs_exist_data(dn->inode)) - goto clear_out; + if (!f2fs_exist_data(dn->inode)) { + f2fs_clear_inline_inode(dn); + goto out; + } =20 err =3D f2fs_reserve_block(dn, 0); if (err) @@ -206,10 +219,8 @@ int f2fs_convert_inline_folio(struct dnode_of_data *dn= , struct folio *folio) =20 /* clear inline data and flag after data writeback */ f2fs_truncate_inline_inode(dn->inode, dn->inode_folio, 0); - folio_clear_f2fs_inline(dn->inode_folio); -clear_out: - stat_dec_inline_inode(dn->inode); - clear_inode_flag(dn->inode, FI_INLINE_DATA); + f2fs_clear_inline_inode(dn); +out: f2fs_put_dnode(dn); return 0; } @@ -232,9 +243,7 @@ int f2fs_convert_inline_inode(struct inode *inode) if (err) return err; =20 - folio =3D f2fs_grab_cache_folio(inode->i_mapping, 0, false); - if (IS_ERR(folio)) - return PTR_ERR(folio); + set_new_dnode(&dn, inode, NULL, NULL, 0); =20 f2fs_lock_op(sbi, &lc); =20 @@ -246,14 +255,23 @@ int f2fs_convert_inline_inode(struct inode *inode) =20 set_new_dnode(&dn, inode, ifolio, ifolio, 0); =20 + if (f2fs_has_inline_data(inode) && f2fs_exist_data(inode)) { + folio =3D f2fs_grab_cache_folio(inode->i_mapping, 0, false); + if (IS_ERR(folio)) { + err =3D PTR_ERR(folio); + folio =3D NULL; + goto out; + } + } + if (f2fs_has_inline_data(inode)) err =3D f2fs_convert_inline_folio(&dn, folio); =20 - f2fs_put_dnode(&dn); out: + f2fs_put_dnode(&dn); f2fs_unlock_op(sbi, &lc); - - f2fs_folio_put(folio, true); + if (folio) + f2fs_folio_put(folio, true); =20 if (!err) f2fs_balance_fs(sbi, dn.node_changed); diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index e7942e6e312c..e0f850b3f0c3 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -1006,13 +1006,6 @@ void f2fs_evict_inode(struct inode *inode) } out_clear: fscrypt_put_encryption_info(inode); - /* - * Defensively truncate any remaining page cache, e.g. - * f2fs_convert_inline_inode() called from f2fs_truncate() - * may leave page #0 behind in the page cache when the - * inline conversion takes the clear_out success path. - */ - truncate_inode_pages_final(&inode->i_data); clear_inode(inode); }