From nobody Sat Feb 7 11:31:06 2026 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991EB429810 for ; Fri, 6 Feb 2026 18:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.70 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770402515; cv=none; b=Y8L/qTKcyHaEYD0m9JYzryVGqgKkftp2FJ/7uOT+pa1zl2CI8cC6ARqA2pb3uMrWt6ITx95oDHl3GNlheSEiDHJ8sKAzg8qO4ktye38pyv5dCFxhOJULLcKS/KDFJkiPTrsiNc1ffm8eIEs/oNCbyL657OfwfXSbOleUUPAqFX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770402515; c=relaxed/simple; bh=rq+LV1lDBiL647/nTiwEUNqFwdT9VjEdkWs1HX/P58M=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=JoMD+GELKl1s8MHaJf5cdmTyG6SOJrE6ktWrS16ezy/8U+dMyw5XMZzngSZipJKqA5DQ4lXibUa1iyo5KyIrpsZ5hvVP9wjAyTKV94+s8+b8UYs2+AdE1aqmd5qYdMzptu4OwDUK+IsW91YG7h/SV2amQ/+maoMY5/52ilQ7G3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.161.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-66ad91bd85bso9839758eaf.3 for ; Fri, 06 Feb 2026 10:28:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770402514; x=1771007314; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NiA8tdIJgLnbwOSru+qZ1VgowA7pa4KEwjxHI2jzQks=; b=g63iX36A/DBh6M/DKMlMYYP08y+9XXrOB4QFRpIhqelcd8QKP9l24EbNKkYnRFifG0 f/NPgjbP5v4lquBKOd/vJ4vczNcsTH57Gn9TadUh9Wp+VWal3p7eTtWpZgKBkO3SINVr IqkC9Rvkp0VBX2on0PqRh3LQWL6QcB99gayDdY0hMhOwRX2wGYbtiT/yDptNGw1HrePT Vbelul2aXo3nVW55rtyJ3MHdGBMe6KDAvwv0zhPJH3FElHl8haeqqSIBFA7sImZ3tW3o iBCM3niSmBdcSD/EOGdKZGpUADLsDzMKpBpVNEO1P36cTKXyvNAViMFuUXf8RSeb+tnf jryw== X-Gm-Message-State: AOJu0Yzm6d6gx1wf5/cpNekKOvnzcqrQvZx/3LB224VuhfhCR6l3a01F XgN2YUzMDO/aIZbi/AA9ccndiN3evsbAiVn/J9ka8xS7YHQ2uV/ALfooxtAzlyD7Zw39ucIroJO AVnkD6zXY9wDME3IfYeQ60rEJyAJ9bA2rQ+QT3w2O6WESNCpJynJlfglRnws= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6820:2103:b0:663:1f2:3e16 with SMTP id 006d021491bc7-66d0c950cb9mr1834210eaf.66.1770402514553; Fri, 06 Feb 2026 10:28:34 -0800 (PST) Date: Fri, 06 Feb 2026 10:28:34 -0800 In-Reply-To: <68c3c675.050a0220.2ff435.0353.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <698632d2.050a0220.3b3015.0044.GAE@google.com> Subject: Forwarded: Test for 5a66db916cdde0dbcc1c From: syzbot To: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org. *** Subject: Test for 5a66db916cdde0dbcc1c Author: syoshida@redhat.com #syz test diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h index 596ab9791e4d..ff6d2bcb2cca 100644 --- a/include/net/flow_offload.h +++ b/include/net/flow_offload.h @@ -673,6 +673,8 @@ int flow_block_cb_setup_simple(struct flow_block_offloa= d *f, flow_setup_cb_t *cb, void *cb_ident, void *cb_priv, bool ingress_only); =20 +void flow_block_cb_remove_driver(struct flow_block_cb *block_cb); + enum flow_cls_command { FLOW_CLS_REPLACE, FLOW_CLS_DESTROY, diff --git a/net/core/flow_offload.c b/net/core/flow_offload.c index bc5169482710..137a44af5e1c 100644 --- a/net/core/flow_offload.c +++ b/net/core/flow_offload.c @@ -334,6 +334,8 @@ bool flow_block_cb_is_busy(flow_setup_cb_t *cb, void *c= b_ident, } EXPORT_SYMBOL(flow_block_cb_is_busy); =20 +static DEFINE_MUTEX(flow_block_cb_list_lock); + int flow_block_cb_setup_simple(struct flow_block_offload *f, struct list_head *driver_block_list, flow_setup_cb_t *cb, @@ -341,6 +343,7 @@ int flow_block_cb_setup_simple(struct flow_block_offloa= d *f, bool ingress_only) { struct flow_block_cb *block_cb; + int err =3D 0; =20 if (ingress_only && f->binder_type !=3D FLOW_BLOCK_BINDER_TYPE_CLSACT_INGRESS) @@ -348,32 +351,52 @@ int flow_block_cb_setup_simple(struct flow_block_offl= oad *f, =20 f->driver_block_list =3D driver_block_list; =20 + mutex_lock(&flow_block_cb_list_lock); + switch (f->command) { case FLOW_BLOCK_BIND: - if (flow_block_cb_is_busy(cb, cb_ident, driver_block_list)) - return -EBUSY; + if (flow_block_cb_is_busy(cb, cb_ident, driver_block_list)) { + err =3D -EBUSY; + break; + } =20 block_cb =3D flow_block_cb_alloc(cb, cb_ident, cb_priv, NULL); - if (IS_ERR(block_cb)) - return PTR_ERR(block_cb); + if (IS_ERR(block_cb)) { + err =3D PTR_ERR(block_cb); + break; + } =20 flow_block_cb_add(block_cb, f); list_add_tail(&block_cb->driver_list, driver_block_list); - return 0; + break; case FLOW_BLOCK_UNBIND: block_cb =3D flow_block_cb_lookup(f->block, cb, cb_ident); - if (!block_cb) - return -ENOENT; + if (!block_cb) { + err =3D -ENOENT; + break; + } =20 flow_block_cb_remove(block_cb, f); list_del(&block_cb->driver_list); - return 0; + break; default: - return -EOPNOTSUPP; + err =3D -EOPNOTSUPP; + break; } + + mutex_unlock(&flow_block_cb_list_lock); + return err; } EXPORT_SYMBOL(flow_block_cb_setup_simple); =20 +void flow_block_cb_remove_driver(struct flow_block_cb *block_cb) +{ + mutex_lock(&flow_block_cb_list_lock); + list_del(&block_cb->driver_list); + mutex_unlock(&flow_block_cb_list_lock); +} +EXPORT_SYMBOL(flow_block_cb_remove_driver); + static DEFINE_MUTEX(flow_indr_block_lock); static LIST_HEAD(flow_block_indr_list); static LIST_HEAD(flow_block_indr_dev_list); diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_of= fload.c index fd30e205de84..d60838bceafb 100644 --- a/net/netfilter/nf_tables_offload.c +++ b/net/netfilter/nf_tables_offload.c @@ -414,7 +414,7 @@ static void nft_indr_block_cleanup(struct flow_block_cb= *block_cb) basechain, &extack); nft_net =3D nft_pernet(net); mutex_lock(&nft_net->commit_mutex); - list_del(&block_cb->driver_list); + flow_block_cb_remove_driver(block_cb); list_move(&block_cb->list, &bo.cb_list); nft_flow_offload_unbind(&bo, basechain); mutex_unlock(&nft_net->commit_mutex);