From nobody Wed Oct 8 17:34:33 2025 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5121C2D877E for ; Wed, 25 Jun 2025 15:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750864993; cv=none; b=NoETtHVLbSI38UDALYgZeeqlyTHBAkM0dwyS0iaKkjEIMFKmMNa7Yi+BiXcY1ehcb76qbiiFPHyrcPyGsmmqwrD57VUuF/TIdzgJbljkwxGEWehJbY2St5mtnxljfULHnNM7dQ0K84td/QoloO1ECWnh+LOpgWc1PVcUae59SEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750864993; c=relaxed/simple; bh=5O2/4BpQHfklLSAAZ+OUfTKYve/rhKype+tQDUVh+no=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=RO722doFwVmSv8VwZWB7qmtvmguXwGi6etYqYQZXo7sh3bLO5rjAhNz8Sc5Wmk3N35ymNGwzS0hKF+8ap/1BB120jLE+gCM93MrSntDlGWcx/3kJFfMiydNA8sesC3Y/ZO2mleCIoeh148gNCSK0j/z4RicG8CZmfhHsWTxHI+w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gopCmP7l; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gopCmP7l" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-72c09f8369cso565668a34.3 for ; Wed, 25 Jun 2025 08:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750864991; x=1751469791; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=RscgyY7zr0J0heuodisQOvqSQWiux2P+I5t0Y0pHfw4=; b=gopCmP7lQbciQsrEixvDxNRXOALsnIT2oVDTnaldRPWO/cvurg1e/doGdO7JkVk7KR 9jIjSCbJ0WB4/3BAUlvJEfn6zG3pUqleX6fI9HAhWAzCoOR65VzVdoEnouPG7dF24owP afVOis9bpICpAWOapd8oBx/bESglX1ysYX1BG1yOTdInAA3LtP7wjvEsIjeL/3OXe9oP nbaPNT2ikwFK9XDxnuR28wt6FCLtIVbXSPcDRF9mofL2UwHJ1KLj8gdyGjA4RMEvaw3n cGrw6hElsP4LSXm1tGHEjhg0uiEwKjvnIdaTmpcar24CR0ya0kIvBLXxDjLjYw0pQTNC gHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750864991; x=1751469791; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RscgyY7zr0J0heuodisQOvqSQWiux2P+I5t0Y0pHfw4=; b=US60X2PdMTSpsqSdisLU7P94wWmvxOa/ZEwixVCRrZn6jfgPTy+AKlVZfEjSDej0ba 70oephdcquK4rud0xRqzs3+ywVNGru0mg5OF2pVWPjJH/GGWvBHdDOttL/H43UEM7e1H cOnS/2aUlr0k/G7eKVMWFhvgp+RSFbMNymQ1E6ed/zYiEIln88/4Hg0yaYVD+9qgWZBd ECF4K+PfTRkHRmezIifU2L3pZ+aCZwDiGtwXf4v3nLDZ0mlTYPB6B49OQ3P/mc4tRLpl Sg2gzX7dyCjlgB93Dw44aadfdwI+OckJn+d55kZh5XpCpZQxxohT/yoDyLkQLRJKKdAO Ck8A== X-Forwarded-Encrypted: i=1; AJvYcCUCyKn8TtVD9SOEABkoJ4OZusQ8M1zQDllLi4o5vwbTsWq5OV71IVLH4pUXjgOvqAlz63H+RElUWrF7cFA=@vger.kernel.org X-Gm-Message-State: AOJu0YxCE2qKuJdZ6i4TRhvtjP72JC3cr3oO2HTeCLH4fFfcideCRsEk hzLwEnLohPGTo/oSMjK4V+TRK+V/kgzHSrrZAXQOJ6fRhTqxinSS3oH10QHuTEJGSufTBXQm7pG +IkL1 X-Gm-Gg: ASbGnctzSb/kkuG1c0e5phisL6LXkY0TY8cmeiHznuvbu8jopkh8UmXbBaXh/Ojmdc/ K4iRxzVp4k8sS2ezLTpGfL9lPEE08y2Lmsnp8UTmmi/X4wvlt+bHVhN2sS2dC+XqJjhIixosO1e Kf/Gtzwe6qgvhxbXoFdze6XF8JhwgZMUZ0rUenJLgDKXjdNHniY9bGn518rQ+HYfpncmltpj9jP oKyMXTcITfCjIhbNlVXaSw+9KUQkZ0We5qCBnucc5lvnyORSPX958ukpyZe/T8ipG3Rys09+yQH 9MitmxvhFAUP9tM8KkWEhOWIhaXqrlfn2yGizHIhh9FukdfdByooAempuMmVNyW2eUf7fA== X-Google-Smtp-Source: AGHT+IFW4wlR0wlfzJlAh8x3qk2Cx37JojTQFFpNrPClMsltnG4YGIKmiULYONmufRuAqIk5456wBg== X-Received: by 2002:a05:6830:2113:b0:731:cac7:364e with SMTP id 46e09a7af769-73adc811af9mr2506085a34.22.1750864991484; Wed, 25 Jun 2025 08:23:11 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:1fca:a60b:12ab:43a3]) by smtp.gmail.com with UTF8SMTPSA id 46e09a7af769-73a90ca9c12sm2237043a34.50.2025.06.25.08.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:23:11 -0700 (PDT) Date: Wed, 25 Jun 2025 10:23:10 -0500 From: Dan Carpenter To: Nicolas Dufresne , Ezequiel Garcia Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Detlev Casanova , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] media: rkvdec: Fix a NULL vs IS_ERR() bug in probe() Message-ID: <696219e9-a1c7-4c87-b15c-1ffd42c95d58@sabinyo.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The iommu_paging_domain_alloc() function doesn't return NULL on error it returns error pointers. Update the check and then set ->empty_domain to NULL because the rest of the driver assumes it can be NULL. Fixes: ff8c5622f9f7 ("media: rkvdec: Restore iommu addresses on errors") Signed-off-by: Dan Carpenter Tested-by: Detlev Casanova --- drivers/staging/media/rkvdec/rkvdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/= rkvdec/rkvdec.c index d707088ec0dc..1b7f27e4d961 100644 --- a/drivers/staging/media/rkvdec/rkvdec.c +++ b/drivers/staging/media/rkvdec/rkvdec.c @@ -1162,8 +1162,10 @@ static int rkvdec_probe(struct platform_device *pdev) if (iommu_get_domain_for_dev(&pdev->dev)) { rkvdec->empty_domain =3D iommu_paging_domain_alloc(rkvdec->dev); =20 - if (!rkvdec->empty_domain) + if (IS_ERR(rkvdec->empty_domain)) { + rkvdec->empty_domain =3D NULL; dev_warn(rkvdec->dev, "cannot alloc new empty domain\n"); + } } =20 vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); --=20 2.47.2