From nobody Mon Feb 9 03:50:52 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B707D1CEEBA for ; Sat, 14 Sep 2024 09:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726307884; cv=none; b=Sc30+9eYLo0nxe2ATrCnbsJAea/nnWxVI96bD1T6TAYNj14JtPCTVppr3Ili6MpNcyi+80sJ4tt7+gnrtOtui1i9jX9zeOry2UElY3H8sXRb55piBnsMpZKVa0IAxFqoxI0Z9XZHbsKcnNGdQHUH5Zc+mrAD7340QG2vuoKdROw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726307884; c=relaxed/simple; bh=/5HMoiKsNQpQYsVih2u9baT8T81pGg0AoSnNhsPK+ck=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=I3fyxkAAtTJfZeDgL5LjSZ+FL427eQQUOJFzdKGB0aUteBOe2eUOz45L2FcWFhw3RxhMe/qsOv7wocMPCcrjObXYCl5T+4VpRgdHXvr52pXYiZ5OcTvER0f/ad3Ab0lSiu00Mq21skp7Uw7wdi2Liqmb9Q/6BN5fERXcTQCCQHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RFOWjVhI; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RFOWjVhI" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-42cb6f3a5bcso22803025e9.2 for ; Sat, 14 Sep 2024 02:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726307881; x=1726912681; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=88eCWCoJ6XR75TD+7uqwXik/mRXRbb4L/oRDMA8RVAc=; b=RFOWjVhIv6CimJ+dEyqLUMcW7ICZPRYhey9E0lbnoHsUn3lz3x9xc1kaa6tsJPFFSG myBuko0uhM8fvSYIf/c/5xxevBqZYjDBaRcutsuEGdLadZ2pC8/0RUn+rupIpYwo3eyL r7xmLAaKuTxxu7e80a/bzefhcWJ9xigFiKVx6wS6eEBFH1IW69uo3z/lJqjALP1wAQ5/ o0SQDVpIDT6EhB3vZV1CKY071eWCKzypoDNacwhiYRhwGQzvKNZOsGEJtyHz6+s1hYOG BcQNaxnMFtsuZSPWWB7G0CmqrkRS8g6VizrdDctNvPK0mXA0XGcgXpJOtyXINP+BQDAs 8O0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726307881; x=1726912681; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=88eCWCoJ6XR75TD+7uqwXik/mRXRbb4L/oRDMA8RVAc=; b=Kt5fK08VVOTJgz6TUEWG21x6B8k0KPWHoQoGhEe1l0KZ3mFBknByJ3erKmjKJBZTJj IlSGY6QNS8tMphDHJty6Bmg5C1Zke2u0urvxy+cc7IO4ObnYWhkVEGuhBjOg3my38MOx oImPFwwg7YYlG6wxJJ+9YQ5/vXBqQgJ24SeHfvfod8tN8oDbIv25812IjACLwOJPEKBg 9pIOWD1I2CjELTM0McmhkxOsvAgfXc3KdUfGypdh+BGfn3llSYCaGVjM8NUlbTyCitpY H/G7uSv3/UhfrfsbN/k2V2/uZ7l8PrpmWIPJBR23gqZ1iwOggsFs4UmC+74Sw2xJSotM uLgQ== X-Forwarded-Encrypted: i=1; AJvYcCVO4XbZw5XNQRm99UQ9/1eSSDcyDThaBW29WpXMI2IJJ8tQxEcvL7NDXZPs0V2oEJ0qZ7c5OA79qV5A3R0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6H8h+mhydMstfexTzO1ZX6PwFzSADjdmOOyvSGOO0eprrQc9c 9Fn+r8cCYty0EiyhiDfX5okrwCgStKJIxnTOFKpnmLC+Lg6vsBpEPuRnZblcla4= X-Google-Smtp-Source: AGHT+IH7GmXL2XmaP0VmzSlcMV8/a2NLWHWGYPOZMBM/UtK5vb5oZb81UImFpRwQaVXMv0UR3lG/Yw== X-Received: by 2002:a05:600c:83c6:b0:42c:b220:4769 with SMTP id 5b1f17b1804b1-42da2bd7679mr14208405e9.32.1726307881005; Sat, 14 Sep 2024 02:58:01 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a90612b3eb6sm60495966b.105.2024.09.14.02.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Sep 2024 02:58:00 -0700 (PDT) Date: Sat, 14 Sep 2024 12:57:56 +0300 From: Dan Carpenter To: Piotr Raczynski Cc: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jiri Pirko , Michal Swiatkowski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH net-next] ice: Fix a NULL vs IS_ERR() check in probe() Message-ID: <6951d217-ac06-4482-a35d-15d757fd90a3@stanley.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ice_allocate_sf() function returns error pointers on error. It doesn't return NULL. Update the check to match. Fixes: 177ef7f1e2a0 ("ice: base subfunction aux driver") Signed-off-by: Dan Carpenter Reviewed-by: Simon Horman --- drivers/net/ethernet/intel/ice/ice_sf_eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_sf_eth.c b/drivers/net/ethe= rnet/intel/ice/ice_sf_eth.c index d00389c405c4..75d7147e1c01 100644 --- a/drivers/net/ethernet/intel/ice/ice_sf_eth.c +++ b/drivers/net/ethernet/intel/ice/ice_sf_eth.c @@ -108,9 +108,9 @@ static int ice_sf_dev_probe(struct auxiliary_device *ad= ev, vsi->flags =3D ICE_VSI_FLAG_INIT; =20 priv =3D ice_allocate_sf(&adev->dev, pf); - if (!priv) { + if (IS_ERR(priv)) { dev_err(dev, "Subfunction devlink alloc failed"); - return -ENOMEM; + return PTR_ERR(priv); } =20 priv->dev =3D sf_dev; --=20 2.45.2